From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101100 invoked by alias); 17 Nov 2016 18:34:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 100443 invoked by uid 89); 17 Nov 2016 18:34:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bothers, HX-Exchange-Antispam-Report-CFA-Test:6072148, policy X-HELO: NAM03-BY2-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1479407648.908.72.camel@caviumnetworks.com> Subject: Re: [PATCH] Allow [f]statfs64 to alias [f]statfs From: Steve Ellcey To: Andreas Schwab , Steve Ellcey CC: Date: Thu, 17 Nov 2016 18:34:00 -0000 In-Reply-To: References: <201611072213.uA7MDcpB020773@sellcey-lt.caveonetworks.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CY1PR18CA0033.namprd18.prod.outlook.com (10.163.31.43) To CO2PR0701MB1062.namprd07.prod.outlook.com (10.160.8.141) X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;2:WMEakZ5IDsPzA3v0REv72iTRH7Eipv5avitG4Daafhlm+beJCaG2KDeYGNKkyIjXf3mUF4xIqakCBuBt/6QaRqjBMMma6PP2K3lOLizwzxgZYDV4BaADj0A/tPpcy+sAGewwD9/mbR/2DB5OZqIgaNnfswerOfHOQATn3WVc7nM=;3:DgyW3yQp9frZPlsW+lm6601dGCvjmZNy4NrKAiotIAreH96XIRoeWu9iadGclyrX1KutpYItigJOYzCxNl94ggmK7/+BqkLmu+cGSjZ2GGsa8KYIhzxjGpoWB6YHyqfQBAx6bZ2F4lOGoY+OTfpIttRTIpVNtV+Twx81FZfNWlM= X-MS-Office365-Filtering-Correlation-Id: 2fde6d7f-0c99-4d83-9d0e-08d40f185446 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CO2PR0701MB1062; X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;25:ydNQsdp+ZuKKFaPvX6keWP9kyo4D+Ni8/NrJqv3gLjfb4g1NJxl1xN7MabCdy+2jFn2teATxamqcUga7S5a+AP+UMTFAC1zRRK6hkQN9Rzz6woa92KxRY/g1orJHuraGP+VZMH5+foah43gKqWxb5kIIgevKNL+6obFzH2EsoZ/OZdBUpKMipeVUfTRYsXJ3pks+l+SxCPwn48cWTP7gIc3P7d9/ZG32x4kku/B4rdJrYJVA6nA1yRCL3B1hKvQFcaSEhYPJj3+tlsRL0Hv8NPhNkRPJgP4VP2l5LAFOb8ULZrVt9DsamSdHy0iqE2JKOm92JqIOZE7Gkte4rge8jbxKkNZsWOe8esdFO0oxhPcOkNuDFi4kRIRbdui4vUwlqrK2vlPFfVyUIYJbHvA1hTeOIelR1UYcpz15Y78WjyQ0TNgg1xxKvisXAe1rScPNRXsYEyB3zHujImcSfRhqYHdtx++pW7QdJlw8iuvpSkcr03/UJEHWsvrctZPpIn97YoqItmDpHru5MdPTBFz+49v98PCilQcFEH/0Xwirshe396X7H3nq94Wm9ICLal35TVa4328iXINsXRF+G3ZpFhDoMSk+9VdE3RiPeLydhLk4D16TKaeUMUs5Xmvp8NfRnXA/K5TwGJxn9S1JqHEpQw/Qc1b9y4eFZ4J9wvzQprVxNd3LpvNrjq/0NXPvq5dcWSSCFTWNn8kidSATkKi8faEMeFSDNxo/cBDYWWhkkM4hBEnHXHRHG6GRFGqRHhWxHmfy0kU8weOi+8PFwaDX9g== X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;31:pkSkxka1W2Nispu6U4NDeLWhdsEBqHS9tdU1fbOpIHoduANLbHRLCUHxpuLVCZjBlRO91LKO3XJTbnUwXaefl6K3LVpQStuuokG37h4DMZ/Sa0aX9Uv3X0+gN2Xa6LIEklU2gTNK3zit8S88anTX5NtP+JDVlFRxH0MoGVktRQZiTJQ0Ny92aEcg/YTRD1a9zA/tApycqG11sc0cEAeKRjjzfvk95LWD0ABoKCtU5CunCXG1yEuAFhQlzl1I0ywhSb1M240PGHrMBQYTNLY/qQ==;20:ELdnVtLd4drX0AqLNLO0qOYMBd7YIRfx6yYZ1LdyqQg+u2RIFFM9SBWWtpujpihMgdJkGwt2/4LOxd2jkF8K3xFX8gUnR09gNN4GyepQTxgz4CCAuerORgTlOgZWQP3+JrC8U2d9bbdjQti4VDOYD3un3kj25YntC23kajqM3xDdMkIAmAVi7vOHhyUHp7B7qH/dacSLPMEdjub9zIDDDtAwa3Zp/zFh7f3J/1i779g9fOPxxGGvpwy01a7J1JTHyK4yQ+2R5v9vGSuXf+vbW7/LGSjeLwcnrzIa5nwomUPcIfY731mMVynOIrAkDlPIUfoZaKBgFC1i+SxxIfmAKQC79SC1JhFr7F6lc++oazPFK/uMb1Q+oTE4ODtcpnAvxt4xQY1ZblCPN4kH2OpbW7/zth8/wQvgkmvB7y7jligld1LjmHJr9hV2ZPjdgcg1/EKKdzPM+kiCp/aNgTtzLUeFQ0FIMru9BHVSwSb3Nv2F+56pQmN/MrDOqarsmnthC+ir7a1ydQQff8FZC5Qn8UaxM4zi0Kr8EntLktof/1JhEww6EXoqFo8xtmfZ8s5FLBEgaCXBwCVm22YoUJOy8Xwllpex6h7GX5Q0wKpBdwI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040281)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6061324)(6041223)(6072148);SRVR:CO2PR0701MB1062;BCL:0;PCL:0;RULEID:;SRVR:CO2PR0701MB1062; X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;4:IH6KFDtN9Wf4MkBmYkasOyG/IYp1Fz0IHLEQEH3ZH8NLlBKK4iHFKwO64anyJIBsOArJGzAYZr/YTvpaj/+1NAJQ4ewoOX+H2q6fr66Pa0G5yD1Ma9OOGh03uO1oI2xJReUN+Ydgn19QhP5XIgRCOT/Fzl/maKpN4hPTUfs8+12Jq5ckDubmLhbgz/J6SqdlfMqKvJ/mn9VhAug27y7fZ3w7uz9+MVv/O/fjYxxwOvOpvQuLFluopAv/f3GxW2rI/O+vFlOSHQnQ4DtMrQh0dHBb9HNr06GCMkRibfxgAUUf6aMM/gQoCM69ITcs7BfLEBU7sJrUZ7Yzznf1B9tmMDye2sVQuO9TMctQYFMjo7EwWzyk1ZaiP9TsWzo5ESccYk0TZk5zP55+tS2HDHBzLnrj0Ae+iK5Kei54Ysjo5hOcRMnLNeW9kdaqI1CXhhHpPynTDfUk4jQbfeed/hSDXdeNYggoUXbObW3fGuYHqO4= X-Forefront-PRVS: 01294F875B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(377424004)(24454002)(199003)(189002)(66066001)(4326007)(6116002)(101416001)(106356001)(36756003)(2906002)(3846002)(105586002)(33646002)(53416004)(8676002)(76176999)(42186005)(103116003)(2870700001)(305945005)(7846002)(5820100001)(7736002)(23676002)(6666003)(81156014)(81166006)(5660300001)(68736007)(229853002)(2950100002)(92566002)(50226002)(5001770100001)(47776003)(6862003)(42882006)(4001150100001)(189998001)(50986999)(77096005)(69596002)(50466002)(97736004)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR0701MB1062;H:sellcey-lt.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjA3MDFNQjEwNjI7MjM6Tmh3b1VwNVZuR3Z3WkVhRnJ2N2lpOTJ2?= =?utf-8?B?MGhWYi9DeGpLcW1RTnhUVlJ2QUUxeTArMHlsNXUyUDI0dlN3WGZQQWZ1VEJW?= =?utf-8?B?MXVtMjNnWjlwMmJzUDRpcksxeVhURW41WmRHZ01rQzJuUXRtVHBXcjdWTFRl?= =?utf-8?B?MWI1aDZWN0tyVE9qSjQ1bThvWDhRbmZkak5HNVJqSzdSZ2Vnck5JV1NoUnBM?= =?utf-8?B?WHUxd2l4OTgrNktpSnYrSGp1cW5iQm0xSUtaWTBSOUw4czM4MmdJb1pXOEha?= =?utf-8?B?MHhvWFJwM2V1dUJZeFBUd3NNRks1TmNXYUZtODZYTGZMakRLUVdZMy9JVmF6?= =?utf-8?B?Sm1KZitqZlc2SmFHOWcrQmczbDZtZW50ODZjRlV0VFdtRE1OVHFwNGx5eTdF?= =?utf-8?B?OHJUT09abnFkMUN4RUtXRDVZTkszZjFDaHJUTkRYM2xPS1pwMGYyQTJEeU1y?= =?utf-8?B?aklDTlpOZ05VTlBKTTNVOHlTWTZZZ2h5S0tEYWExbGFJaGhWVGlQbktqV2Fo?= =?utf-8?B?bEdMQkE4UjdiRzNNcUlxQ1UvV2s0TzJKQTBrVkwwM2I2ZlNteFFJTVBHYXYy?= =?utf-8?B?Q2F5RGFHODZWNllHQjFZZjlRRmNnbGNWVzlpWmQ0dkwxaHZibHQxMjVXVVRI?= =?utf-8?B?MVVCL3B5OG1XejIvczlnSVlORWsvc2RrTEJ6RVcyek44b1ZZYTVFbFlBSDY3?= =?utf-8?B?dVpLOUZRcXFZdWJEWEswbWs4NGkwYkxnUCtXcXVFbTVhYnRaOUpRYTJ1eSt3?= =?utf-8?B?R3ZqOXM1WlNTZHhyWWlsZ0NoN2p5UDZLZC85RWxNeWZsaUJ4d2UybVIraHRL?= =?utf-8?B?ckJhUmhFdVRGTzNvS2FHSmlnc3R6bTZDMlFuZTR4L1Vaa3IwVnVMSHBabGNN?= =?utf-8?B?L3h2cXljdnFHanpoemxnYXlYWFpTSWpVQ0RlaFhBWERkNXlrN3gvS3lWUm1p?= =?utf-8?B?aVBQYSsvNWNld3dUV05HWXhJZ0RNamxOc2gwWHFjcFBaUkMxNU5aYTBIMEY0?= =?utf-8?B?cThIRE1FZCtDN1VLUlFwbXZzbVg3VjhlMm9PcmVyUWZrMnluamdTQmZ2K0dV?= =?utf-8?B?Wi9VNHRaQWVjNkFzdXpaa3RMMTRJNEthbk45UGp5ZFprdHJBTmU4Vzh0c2Z5?= =?utf-8?B?amVNeFlPYkUzL2tnZFBSeko3UGs3N2V2VEM5dldmM0lMeGtYUFo4V05UQ1hW?= =?utf-8?B?VnpXbGhFMHdpblBXMndWeU10YkUwM2FpRHZpaDM4ZmFJeW52T1pLWjZMYTJI?= =?utf-8?B?ODBPZm1uWWFIME1Yc0E4WnI1MUZQdzIxczFlMDF3Zk9JRkRJTXU3WFRENmNW?= =?utf-8?B?Yy9IOXZ3eUtGYUtxOXI4S2hkSkk3VWkzSzNzYXFXWmVsVzZyUU9yQTFFeVVw?= =?utf-8?B?ZjJzaGZSYmNNRHk3ZkpkMmZMZFlYTXNSS3E4LzRBS3pJSDM1RXI4ejhUSm9x?= =?utf-8?B?TE55NUQ2MWpraUhlWFQ4ZnRVa28rT3lLUmUzZThLNWUranFaaGFodEh1ekhL?= =?utf-8?B?ajEyZWRDTFo5Z1p2T29uNkJKcTlKM2FxN3JWcGEzcnRkQm9TSXlZSTdZUGNh?= =?utf-8?B?ejVPRnhqaW5aSXJ5amxFT1FEN3M4MUVFd28zZXBKWmZ0WFpxbXEyeDhNQk1B?= =?utf-8?B?Z2dzMUUyVDN2TjFuRnQwMlA1YVJ6NDdOUndHc1VYS0VxNUhaQkdCZG1uQlE9?= =?utf-8?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;6:OhBqYJqzSE8nb0GKwp4af7FSnSV1pDhofSNrY5esQR5BLOLMaARwELlDdRp8YyAgeOZZq6xLDXuIO0zCKma1DIGgkIny6++4CwoK8vgI6Dz7waUr44jr0s15LUEdiNueQ/zHJED2t2cC3quSFMNWZ4bF8taWGSo1rFiViUO3vKTPZaR3DGh/Ea1nseeWxQVO6xCciKLARHQq3xco7Q5VgOJVRtLl/o2JqGUJVniNfcFc5caPxvhd3u/LHiy8k/jmZz0hpTUyToVj/rVxLSlW3RfJBa4pJXIKT1JSszB8FvSvu9MRynnq+1XV+7Dx+siqblICpx0bE7ZLJPeNuaLrUBOFgGUMSWrbz8iL/UPQe6s=;5:gp+2MRHJJiem6li07sj19PiSLztRqUJX/crvQ2U/lomYcFDKRHVirYH+c2AMOTqt+ynjKp5Al3FxUttU9VL63zuCuMATfIUQNSn2GkpLIOP0MLvBstrD7Zf/iXxIIF+ULWb7BmF+yP6C916xA3Xs5aLXDl2mp1MoPGkyYvKEFf8=;24:/PxZhxvdQG5lu6XNVNVEf5zOE7LFuUWaeYOr7F82G1u+8nDaTueezLYbKRDr5La3ZDZI9VVOkzuxN1jTLljQI3Eyt0K1NNWQGmWkn5Og+XQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;7:TauaAXSnOdXw9/RKczX03gNf7S6u26HhCiwJ/ekxddKsuSQkbU2qZUwTvWonXJiVVnnwwtRAuy1hMjRsS1LbYl4q+fSSkWUK9vT0Ir26uB7TPzqE8cudNs4uzkUXetWCTSZ3nzhHsWTKUz3JtjKKluVVfR4vbpEf+PHLrSk1F7N25D7K7iQaOYU8EoxnRFbFgrKj/cFcnsb5c7WSL164I6X2UYLoWolpA9fABCWOhoFVqvB9xny1blhvKUUMc9TFVidWhe36RJmjdyoSz9XsQlqtC2PCmMULGJyEFF17Z2/CPw6jzB96EazCD4uifGIWLO2RA6Em7yS3TT4vJjywdPxzhJPvO1n0zM1pJJ7PKl4= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2016 18:34:13.0615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR0701MB1062 X-SW-Source: 2016-11/txt/msg00638.txt.bz2 On Thu, 2016-11-17 at 09:53 +0100, Andreas Schwab wrote: > On Nov 07 2016, Steve Ellcey wrote: > > > > > My main question is, is this an OK use of '#ifdef' or should the > > STATFS_IS_STATFS64 be defined on all platforms (presumably in > > kernel_stat.h) > > so that we can check the value instead of checking to see it is > > defined > > or not? > Since it is a new symbol it should follow the policy of always being > defined. OK, but since having STATFS_IS_STATFS64 be handled one way and XSTAT_IS_XSTAT64 handled a different way bothers my sense of consistency I am going to first submit a patch to always define XSTAT_IS_XSTAT64, then redo this patch.  Hopefully a patch to always define XSTAT_IS_XSTAT64 will be acceptable (after testing, etc). Steve Ellcey sellcey@caviumnetworks.com