From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57387 invoked by alias); 7 Dec 2016 17:05:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 57371 invoked by uid 89); 7 Dec 2016 17:05:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ellcey, Ellcey X-HELO: NAM03-CO1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1481130334.29811.57.camel@caviumnetworks.com> Subject: Re: [PATCH 2/2] Enable ILP32 mode on aarch64 (version 2) From: Steve Ellcey To: Andreas Schwab CC: , Yury Norov Date: Wed, 07 Dec 2016 17:05:00 -0000 In-Reply-To: References: <1481060942.29811.41.camel@caviumnetworks.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DM5PR21CA0039.namprd21.prod.outlook.com (10.172.92.153) To CO2PR0701MB1062.namprd07.prod.outlook.com (10.160.8.141) X-MS-Office365-Filtering-Correlation-Id: 750a2b06-5379-4118-c10f-08d41ec3457b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CO2PR0701MB1062; X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;3:aV4iewIllVME0x4Ijm4lAzFchAf3WeQR2BLrdPnwM0GM03+lMcy6I1Ltv3bNXkkVm32etRin64Dzi9nPGAh43aY/283JcY4BHq2GUv9k4/CTWVOeEj+Mz8qwp2P7PG2gE6FVFUP6QHRX81Iuq3TZPvOnjvCBI4iHHdlXMAoeMcFPh7wA/AA4V+03PeIOwbyApq4h+kw0OEsU6l7wowX4lnjEoUxO/m8rmrYoF4/ZItlGOxqR1HLYywgBj+IUZFS3qpKKulnfFv2VYmikm876iA== X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;25:Q637BRQApVQ6Roa0537vPWbPgmGOeYAeRDXJT8y6IjT8Z5V8EiWaymmRBPlhRExMECzGgEAI3uK1S30+XkJ7KnYBm4E93N40IE9Pr4yvd4GO390adUSXbXI+znX3eXHflNBLUBkJGPlh9Ix4/rdf1cj2cE/3vTaj6uYuRltSqNTXS5P+wVdoYfqQQKrv6nvTbB6MlH3oXJHwiiCVl4WWD7IW4vhBiQgbZKhYXrONU7GzgM1gJ9uC0COJt2qotbyl+ClCw96OsNqnjOGOKerrH/g/byJGorpwGAVqyCGmp9L/V8gGrbxErXmlx6x8GQxt2N1F0It9uDfGelAfjwyXgjkninJafXRKrO4N6I4mh0MPzibWKF0GmBF24eRQXE9wpqyWMZlHxewWl5A0ajFUCXXJyFnRHaKh4OcM5DbBcO7nuTBhrON79wm2RFCMkAuR4bqN7QwlJnaR3qLb2qsUsv4oFIvd/X60i+kru6YqNvJ0NR9FL/3Vd6Z3rBJaJDeeXiqD5EwExNXnN7AaWW5QbFS5dSp+HQC5tFv5q7nGdRkBm+2CgtG2cyKbWJI47fVFggzs0N46dq87ZJezTy8uPo37it2A9dq2gcZeE0PKWFuiqEJBLehRCExeXnS7E/LzX5xrmXmnujgYbrAXm0gqLK1HyOAzCeboyvI/9gZ46J19Ac6J8dC1cArAuPCRivhhEp938f0L85oBzo2VvgXtoHrX4UPmIqQGAFjNERS+17AL53cp65fgBS4yeeOts714UGp01ybKOTQl33vujLitVoKmIXnRQu+u74HUTlVU4Ig= X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;31:t4Fd6fCieiw6Z7FdaXxDkvY1wyJaMTd+p6WHUQZToG9yPOrBJPZQhKQ3UBSYp8x4NRvt/blUj/GmQ1++gwhOl35/WZuGXGfo3pUecJJoQbx2xlQCCNA1FyTlV8dT9vGvIDG5CRXqctd8qgfRnJ0KALD4omi2HWSz8KYQuTxzPWp0abIhPrJFf5j8YwXpVMUbtVVp//rbUJZY6VNlY2zXIJYBMni3TOFX3hen0GQ9pZX6ZeqFW+j01+d8j4kWUV2GFQFIECPuNPT6ru/kA65AtJIWNHwyCA3sYqAPIFDotO0=;20:Nko/pBaFXHRFqZruXl2vNEQqR8PIjL1tgpdA+Bc1w9acKuENiFp5ZDjIxVTDyqewibswUxqOJop14MFRi09d50ezaGDV9VLiyfrfWNImdDhWU+tZSCd4VRvSQ90C4JpkpP5ix9Z9AFMYEG7c+27FUSx1DuQvN+MS2siAH2vzr2EL7wnB8AEciHsN4tw7RC/s9ppZwvzfkZt4ztjIoOlwX8e9dCCiOugkEbyaiovfsc6fQV5xD+QoarMOjm+4jWJqnmpxOwWpAtzO/oDz9C2A5BrvtG9yAchQ7zDfo7MT+skfLsubVDSCopXomAXS5eZSymrjz/lg5L56MM44mn7rz5kqBE1r0uCmvo8aulDGXRz2O49h3CSn+wUkw2bWOZioMxR3bc0XUbx093SteYPVjosfQUzi8Patc+gZYMNTN4pRsuvBcBGtyBRzFTAZp0Aa7INZfubUIg1q2hLjUKtpoKEoF4VFGsJ79ymR3NtIRsPWV+aB/FFOoSetCuejSfLg3Td+YBUSP7aM/mlgfdNWlXwTkSWPfWGfFL6A77FN+BTAcqpkGU+9JqAyGjSWVn/4IAlwxSUy3LO/0/+MtsqBZOxYbBstIIYBr/owLIzYzpQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(6072148);SRVR:CO2PR0701MB1062;BCL:0;PCL:0;RULEID:;SRVR:CO2PR0701MB1062; X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;4:57LU1aujTDHmzTpx/UElDC1vk4InA1hwtwcvZdaBnaj5lyiJd76aQPKXGTXy/FBxSVtIPRoEKoyUN9wTEr/juxTXx5l/6Sv2QxGIoRMTv7SvbMSDEXhpcQuVgi8yd1WwnQo5aJjD8BAvNdQ71BZ6+kA9x0+aKXnDFzYENzc6Euz+Y+dUYHgfpoW7hGOHfVBFhbpsFpkWPGvol2WjR3MfSDvQDPFye2Iy/yeXd8OvzYbYy8Uf2bIyY/fsXrZflhA4X0eNA42I7ea/gPVbuZr4Cy76aTGuY2GhOMUb7y4vFsFA0A34q/b9NvneNf3qonO3ujltbvxrLJf9lv97zcYb7o3v79s/p9CH0HPSmvOYamZi9VIBIBomHRTFBU4JSaG/o8WypvtsritP7zS/Og6EWPQooHh+oC2T1PlxKbANWdntTPilLsuTuBYNIeWvFDTZGqOunWhKcO70fSbBPIe+72H0TTqu/dkronQFTosAAKiWKgqkdLYEevqpgMvc/GS7mvfm490FXDIP6JpjuViVbh28AeFfyMzwdIb52YiCDSj/kjpJG9/5mNnROre0YsOD6JARbdDKC8Z13GwMDbxhww== X-Forefront-PRVS: 01494FA7F7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(377424004)(24454002)(189002)(199003)(66066001)(7846002)(39840400001)(5820100001)(42882006)(101416001)(4326007)(6916009)(229853002)(36756003)(2950100002)(47776003)(6666003)(42186005)(39410400001)(6512006)(50466002)(38730400001)(6486002)(33646002)(39450400002)(733004)(6506006)(103116003)(81156014)(105586002)(81166006)(39850400001)(68736007)(189998001)(4001430100002)(6116002)(69596002)(107886002)(8676002)(92566002)(3846002)(2906002)(5660300001)(50986999)(2870700001)(50226002)(106356001)(23676002)(76176999)(7736002)(305945005)(110136003)(97736004)(53416004)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR0701MB1062;H:sellcey-lt.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjA3MDFNQjEwNjI7MjM6ZG8weGU1L3VFVVEwQVhNa0J1WnNQSFpS?= =?utf-8?B?dHBwNmxUc3UzUzlicWY0eEd1aDc2UHgrZ3lwT09KeTNDc0JBRnR3VjkrN292?= =?utf-8?B?dVQxUXdKT01DWFlDNEM2ME52Ni9KM3BBRkxqeFBIclFqTytaME5qUC9KK2JX?= =?utf-8?B?aDZxS1lZZitTTjRZcmlWYmdUamMwMEZmMWNXSFFOQy9YNnA0ei9SV1RTbDdk?= =?utf-8?B?TGo1eHZlTmNUVjJqU1lPV0hYaW9qR1F0WEdNU3lheTZ6VXd3UVdJQnkzZlg1?= =?utf-8?B?Nk1PV2xnUytqbFB5QjhpRWlDeldwTXVQeVh4NXZ6MjVDM2htVnFNOXY0cEVN?= =?utf-8?B?dm1tNmwxaVBoK3FSOXliVnBGYlBxR0tQR0U2Q1U0cnA4TWcyOWh4azBoVGZC?= =?utf-8?B?VUdWc3ZEM1BZNzV5dE0rSExDZk4yWG5Bc05NVW5sU1RINjl0UTZYRjFCSnYv?= =?utf-8?B?cmJhZ0RFLzFKRElNRFdhTzVPTG1GK0xQRmVHV202MCtqWitNa2NUZk44TXh4?= =?utf-8?B?TkdkbWkwZVVxL3ZQd3BJQ0xrUWpSVEhLcXFkQW5DQytaM0diL1F5TFpQK0pp?= =?utf-8?B?em1xMFUzMjl4bmhPN3JrZ3JpSVhUNTNVclJPWnFVN3ZROTRSK2ZiWk9aaFJm?= =?utf-8?B?WWJYcmZZSmJEd2pqV1hWZG5mOHJ6ZlVldC9HT2VTRy9VWWpBSHRjQVpRM1ZJ?= =?utf-8?B?UEszTHpIaUpQQjlmVld4Z1BTRXJnV1pDMmQ5TTVjUlc5bThhSmd6VWttZTAy?= =?utf-8?B?eUxDSUtSWGw4WGVWZFJmT3hSZmw5b01kaUY4bzlXK2J5aWdiaHVmNW9qL3kv?= =?utf-8?B?Uy9IVllOVzZKeVNubWdOb1ZlSUNrS2ZpbklMY0U2VFhLcWtybFVRNGpqNjNi?= =?utf-8?B?S3Jnb2J1OGxqa2NVRlk1dHcrTG45ZEJQUEhDY3FHaWUybTk2Uk1RSEdxT1E1?= =?utf-8?B?anR2bUVTOE9MMVMvVmhIWm41UkdpeXp2VHhrVGI3eDVOSDJISmJzcjE3MGti?= =?utf-8?B?ZDJ3QzVmWnU2bHBGNVprY2xoc3VTaWdxRzM3eFpuaklIUGN0c1l1bnlHellZ?= =?utf-8?B?L1RUd0lSWVJmRlQ5UjJjeDZpY3NlM0VnZGo3YldIMzN6eTV2V2VHZGZ0eVhP?= =?utf-8?B?VDVkaTYxZThyaExYYnIrbjZNcHJTakJ0N3QzcWRNbnp1SjRHU0E1NGlaeHRn?= =?utf-8?B?YkF2ZUNhZlN3bFdlSTlyeWVGdmNva0IrYWV0TUQvMnQwOG92TXNyZlIyL2xF?= =?utf-8?B?aWkwSzBRckxkZFNPYkRGU1lGQ1FvWGVZZnhlM1MwRkQ3RzNLdVR6KytvL3U4?= =?utf-8?B?a0xVNG1USysrYktpTTNKc0xWdytTNW56TjZaYjNlNW5GNnRRQnpvL00rTE1q?= =?utf-8?B?VEpGUENkanArYWVwK09VWFdNL0VIcm1CTEdnbHp4YnNUS0xFUUNhYWl5aXJj?= =?utf-8?B?YW9BcERGWG41LzlWNThlWEtGVkE0ZHBQRUV0N2dYWWQrcEZIZ0liT0RVNGZj?= =?utf-8?B?M01XNmdLVnoyMVdPd1ZzZ3lGSGNkaVljSjM3YTlQQXZ3d2pxcE1QQjNuSmla?= =?utf-8?B?MktVVVBZd0Robjc3OWVjNjU5ajRRWHNZaGdYaE1xQWxtakNZTklyRDZMQUc1?= =?utf-8?B?TithTnZHdmpBdGVldCt3MGFNZWM1ZzIxeXl1aTA4dk03bFVxdWRpeU5NZWtD?= =?utf-8?B?YWlDWHpEbHBZbDMrYktVSk00TzdaaTgzSFUydXZHdW1oV2M5SzZmcDVIZjdU?= =?utf-8?B?THJGTWtKZ1FSbjVGV2g0L3F3VlErOWtYWTVQa0JpSnkvSm52eVNUcW5lenJw?= =?utf-8?B?S2FhQVBzbWIyNTVGVkFETHpQaG1GL0daR0l2UkpKSkk1RTJNYlRQVzdVQkpB?= =?utf-8?Q?ZXNKi/QpVkjNW83XQs/BB7pfApMEpYDp2K?= X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;6:9bn5T0uauMLASXdHnqmJYMCCDUQcYCpa6ov5VSUFAKVC8VTj5IZSlrAyKRcrjCqmdDk63adUhG9rZysThTjYaFcihwmqMbDwr2UZTx2iNEU/7Jy7NlIdfTIF1VWx6RZV0lRj66QenXaNXoQ9rmd4gWh7SqdY2abpch8lI4hrCbTKKUEtK7L+CEBY39lmcM5R0bh30Dvi5q/QG+Lff3EZe0ulWY8R4VTS7B2owAle8/ndSPHbL+yaI/60o5v06pUr9GZjBgPjONd4s0WfPsRb4o1QR4Mr/bBegNOhXfQWDfCL7Ah5luyl6xoYnSgIAiRFKUSgz8iqys5u4dZvzekB7FDBwOgBNbNLfaQgv1iN8amPbnbQbbYLvUxLT7PMJDJytuCXAS+uZ9KApmbbscYMTn+6i32AsFuMxlJo522/e0U=;5:1LUxfcwjyNqY76IwJFGw3aHmB/fzykwhmnsTu6HGoq0nhpdAC1JTyXi9MBY2P/yBVoOo3qG4FFK7UjR+Uz8enbeswlVX4uEMDBuwNjhYY5jBEOswFqYS8HoD5LuV+VnvZq0tT5SU2eRGpNrWLHB3mkCKOYchlytvpc1rgtn2FYA=;24:Jg4j+Htf7mOZE88nUjS5pURGTThnu1QK7FjB+qGdX1gcDx3CxYcbHAm0pZyC0X1rr/m8AsOz0fMUfmmpivoMeXVhH+ZofE3jw5hA7zZVN9E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB1062;7:5DRI/m+k2T+4242Qr/7Jra31xkve3hkCRLS6PU+sSwyX5YiuYkzrv/iiUoTHImixqe7RTiWQm2u6Um99cRMGBbGln7s+an/60Hds7vR21txIR/S8sT0Z3v8+u4VWsamLsEe9hqy5FhvpyifZ6A8/hfjzlmY+L26pYOdZOkyRnmtOKb6yXjXiK46qsAm/A9/IhHR50zKDFC699o913Tw0Z8pWtuhRQH47IQzPWc7xJMwxUTQJ2m2s++lNKJyk1TUTiWSb6v9nF3XrkHHRfIal9QBbVglO14VGvVWA6ikLT6yCNHyTARuydtd9QjH7dp2jN0sxad36LTVYd/ikEJIQB/YdmykH4Z6oHzbrUBztL7a+1NDS1HbYGQ2V9/ao8BRhirgSXouYHsJMuHJMr8e8Bc9nJslRQ1KtlAmtDzwwzWK02rhcBJ3Nr0bLgRK1nAjfDlLJD5AW9Tz+oTj9iWJLLQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2016 17:05:39.3662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR0701MB1062 X-SW-Source: 2016-12/txt/msg00250.txt.bz2 On Wed, 2016-12-07 at 12:52 +0100, Andreas Schwab wrote: > > > > +#define STATFS_IS_STATFS64 1 > This is a lie. You are using .../generic/bits/statfs.h, which assumes > that fsblkcnt64_t == 2* fsblkcnt_t (etc.), but ILP32 wants them to be > the same. So it looks like there are two choices, change STATFS_IS_STATFS64 to __STATFS_IS_STATFS64 so that I can use it to ifdef generic/bits/statfs.h without polluting the namespace or introduce a new aarch64/bits/statfs.h header to use instead of generic/bits/statfs.h.  Is there a preference one way or the other? My inclination is to create a new header file. Steve Ellcey sellcey@caviumnetworks.com