From: Torvald Riegel <triegel@redhat.com>
To: GLIBC Devel <libc-alpha@sourceware.org>
Cc: vl@samba.org, Michael Adam <madam@redhat.com>,
Rich Felker <dalias@libc.org>
Subject: [PATCH][BZ #20973] Robust mutexes: Fix lost wake-up.
Date: Thu, 15 Dec 2016 22:27:00 -0000 [thread overview]
Message-ID: <1481840825.14990.586.camel@redhat.com> (raw)
See patch for a description.
Tested on x86_64-linux with our tests and the test case from the
original bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1401665
OK?
I'm sending this minimal patch first to have something that's easy to
backport. I'll send further such patches for any other bugs I can find
for which a simple backport is possible. I then plan to follow this up
with a general clean-up of robust mutexes including proper documentation
of the concurrent code.
There's another bug that's probably just a glibc problem, one that is a
glibc problem but seems to happen to work currently (at least on
x86_64), one bug that is just in kernel code, and there's also a general
design flaw in the glibc/kernel synchronization algorithm that prevents
us from guaranteeing the mutex destruction requirements. I'll work on
the latter two subsequently and crosspost to LKML.
next reply other threads:[~2016-12-15 22:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 22:27 Torvald Riegel [this message]
2016-12-15 22:29 ` Torvald Riegel
2016-12-16 14:11 ` Florian Weimer
2016-12-16 14:45 ` Volker Lendecke
[not found] ` <CAJ+X7mT1cU1_2ON2JZM9oYMP_cak734tkf+PZJeo4MZg1i4gmw@mail.gmail.com>
2016-12-19 17:15 ` Florian Weimer
2016-12-16 22:13 ` Torvald Riegel
2016-12-19 19:47 ` Florian Weimer
2016-12-19 20:30 ` Carlos O'Donell
2016-12-20 15:03 ` Torvald Riegel
2016-12-19 18:20 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481840825.14990.586.camel@redhat.com \
--to=triegel@redhat.com \
--cc=dalias@libc.org \
--cc=libc-alpha@sourceware.org \
--cc=madam@redhat.com \
--cc=vl@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).