From: Torvald Riegel <triegel@redhat.com>
To: Martin Galvan <omgalvan.86@gmail.com>
Cc: siddhesh@sourceware.org, Joseph Myers <joseph@codesourcery.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v11] Add pretty printers for the NPTL lock types
Date: Fri, 23 Dec 2016 17:05:00 -0000 [thread overview]
Message-ID: <1482512736.14990.831.camel@redhat.com> (raw)
In-Reply-To: <CAN19L9GEmszxLiGmUAiMYbiTXjs92jZ=pE3v-3iLwygXRoRE8g@mail.gmail.com>
On Thu, 2016-12-22 at 20:39 -0300, Martin Galvan wrote:
> 2016-12-22 19:50 GMT-03:00 Torvald Riegel <triegel@redhat.com>:
> > I first thought it would pick the system gdb and not the one from $PATH.
>
> What would be the difference between the "system gdb" and the one from
> $PATH? Unless you altered your $PATH to make it point to the newly
> built gdb, I don't understand what you mean.
I thought it would not pick up the gdb from PATH. But it did, and the
problem was elsewhere (see below).
> > It seems that the new gdb is used, but the test script
> > still complaints that the gdb doesn't support python ('gdb must have
> > python support to test the pretty printers.'). pexpect should be
> > installed for the python that's used. What am I doing wrong?
>
> How did you come to the conclusion that the new gdb is being used?
system gdb is too old and fails earlier tests.
> In any case, I think it would be helpful to see the value of
> gdb_python_error before the test script exits.
After *lots* of poking, it seems that something in the pexpect/gdb
combination in my case was adding terminal escape sequences to the gdb
output. That made the error string look empty when printed, but it was
not a zero-sized string and thus does not evaluate to false.
I do not know what caused this, and whether the pretty printers script
should have filtered that out or pexpect/gdb shouldn't have produced the
escape sequence in the first place. The combination I used was:
pexpect from pip on system python 2.7.5, gdb 7.8.5 built wiht
--with-python, and I had ncurses-devel-5.9-13.20130511.el7.x86_64
installed (picked up in the gdb build).
Switching to gdb 7.12 does not require ncurses or a termcap library
anymore, and works with the existing pretty printers script.
I suppose raising the minimally required gdb version would be helpful.
It would also be helpful if scripts/test_printers_common.py would not
discard the error when it cannot load the pretty printer modules for
some reason. I've changed
for printer_file in printer_files:
test('source {0}'.format(printer_file))
to the following, but don't know whether that's the proper way to do it:
for printer_file in printer_files:
test('source {0}'.format(printer_file), '')
And nptl/test-mutex-printers fails in my setup, BTW.
next prev parent reply other threads:[~2016-12-23 17:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 3:04 Martin Galvan
2016-11-28 12:11 ` Stefan Liebler
2016-11-28 16:00 ` Martin Galvan
2016-12-04 12:41 ` Siddhesh Poyarekar
2016-12-04 20:56 ` Martin Galvan
2016-12-08 13:36 ` Siddhesh Poyarekar
2016-12-08 18:56 ` Joseph Myers
2016-12-08 21:01 ` Martin Galvan
2016-12-12 20:55 ` Martin Galvan
2016-12-12 23:15 ` Joseph Myers
2016-12-12 23:21 ` Martin Galvan
2016-12-14 18:20 ` Joseph Myers
2016-12-14 19:46 ` Martin Galvan
2016-12-17 18:10 ` Martin Galvan
2016-12-17 19:07 ` Siddhesh Poyarekar
2016-12-17 19:09 ` Martin Galvan
2016-12-22 16:35 ` Torvald Riegel
2016-12-22 16:44 ` Martin Galvan
2016-12-22 22:50 ` Torvald Riegel
2016-12-22 23:40 ` Martin Galvan
2016-12-23 17:05 ` Torvald Riegel [this message]
2016-12-23 17:40 ` Martin Galvan
2016-12-23 18:05 ` Martin Galvan
2016-12-23 18:48 ` Torvald Riegel
2016-12-23 19:38 ` Martin Galvan
2016-12-26 14:17 ` Martin Galvan
2017-01-02 12:48 ` Martin Galvan
2017-01-02 13:51 ` Joseph Myers
2017-01-02 14:35 ` Martin Galvan
2017-01-02 15:47 ` Torvald Riegel
2017-01-02 21:51 ` Joseph Myers
2017-01-03 7:27 ` Siddhesh Poyarekar
2017-01-06 21:58 ` Torvald Riegel
2017-01-09 19:37 ` Martin Galvan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482512736.14990.831.camel@redhat.com \
--to=triegel@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=omgalvan.86@gmail.com \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).