From: Martin Galvan <omgalvan.86@gmail.com>
To: libc-alpha@sourceware.org, siddesh@sourceware.org,
joseph@codesourcery.com, triegel@redhat.com
Subject: Re: [PATCH v11] Add pretty printers for the NPTL lock types
Date: Mon, 02 Jan 2017 14:35:00 -0000 [thread overview]
Message-ID: <1483367714-28081-1-git-send-email-omgalvan.86@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1701021347590.28945@digraph.polyomino.org.uk>
2017-01-02 10:51 GMT-03:00 Joseph Myers <joseph@codesourcery.com>:
> I'm seeing the following failures with current sources on x86_64. This is
> with system GDB on Ubuntu 16.04 (but a locally built compiler, configured
> as a cross compiler, for building glibc).
Yes, I'm seeing those too. They seem to be caused by a tabs/spaces mismatch introduced in commit ed19993b5b0d05d62cc883571519a67dae481a14.
The following patch should fix it:
ChangeLog:
2017-01-02 Martin Galvan <martingalvan@sourceware.org>
* nptl/nptl-printers.py: Fix tabs/spaces mismatches.
---
nptl/nptl-printers.py | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/nptl/nptl-printers.py b/nptl/nptl-printers.py
index 17463c4..77018e7 100644
--- a/nptl/nptl-printers.py
+++ b/nptl/nptl-printers.py
@@ -348,10 +348,10 @@ class ConditionVariablePrinter(object):
def read_attributes(self):
"""Read the condvar's attributes."""
- if (self.wrefs & PTHREAD_COND_CLOCK_MONOTONIC_MASK) != 0:
- self.values.append(('Clock ID', 'CLOCK_MONOTONIC'))
- else:
- self.values.append(('Clock ID', 'CLOCK_REALTIME'))
+ if (self.wrefs & PTHREAD_COND_CLOCK_MONOTONIC_MASK) != 0:
+ self.values.append(('Clock ID', 'CLOCK_MONOTONIC'))
+ else:
+ self.values.append(('Clock ID', 'CLOCK_REALTIME'))
if (self.wrefs & PTHREAD_COND_SHARED_MASK) != 0:
self.values.append(('Shared', 'Yes'))
@@ -409,10 +409,10 @@ class ConditionVariableAttributesPrinter(object):
clock_id = (self.condattr >> 1) & ((1 << COND_CLOCK_BITS) - 1)
- if clock_id != 0:
- self.values.append(('Clock ID', 'CLOCK_MONOTONIC'))
- else:
- self.values.append(('Clock ID', 'CLOCK_REALTIME'))
+ if clock_id != 0:
+ self.values.append(('Clock ID', 'CLOCK_MONOTONIC'))
+ else:
+ self.values.append(('Clock ID', 'CLOCK_REALTIME'))
if self.condattr & 1:
self.values.append(('Shared', 'Yes'))
--
2.7.4
next prev parent reply other threads:[~2017-01-02 14:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 3:04 Martin Galvan
2016-11-28 12:11 ` Stefan Liebler
2016-11-28 16:00 ` Martin Galvan
2016-12-04 12:41 ` Siddhesh Poyarekar
2016-12-04 20:56 ` Martin Galvan
2016-12-08 13:36 ` Siddhesh Poyarekar
2016-12-08 18:56 ` Joseph Myers
2016-12-08 21:01 ` Martin Galvan
2016-12-12 20:55 ` Martin Galvan
2016-12-12 23:15 ` Joseph Myers
2016-12-12 23:21 ` Martin Galvan
2016-12-14 18:20 ` Joseph Myers
2016-12-14 19:46 ` Martin Galvan
2016-12-17 18:10 ` Martin Galvan
2016-12-17 19:07 ` Siddhesh Poyarekar
2016-12-17 19:09 ` Martin Galvan
2016-12-22 16:35 ` Torvald Riegel
2016-12-22 16:44 ` Martin Galvan
2016-12-22 22:50 ` Torvald Riegel
2016-12-22 23:40 ` Martin Galvan
2016-12-23 17:05 ` Torvald Riegel
2016-12-23 17:40 ` Martin Galvan
2016-12-23 18:05 ` Martin Galvan
2016-12-23 18:48 ` Torvald Riegel
2016-12-23 19:38 ` Martin Galvan
2016-12-26 14:17 ` Martin Galvan
2017-01-02 12:48 ` Martin Galvan
2017-01-02 13:51 ` Joseph Myers
2017-01-02 14:35 ` Martin Galvan [this message]
2017-01-02 15:47 ` Torvald Riegel
2017-01-02 21:51 ` Joseph Myers
2017-01-03 7:27 ` Siddhesh Poyarekar
2017-01-06 21:58 ` Torvald Riegel
2017-01-09 19:37 ` Martin Galvan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483367714-28081-1-git-send-email-omgalvan.86@gmail.com \
--to=omgalvan.86@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=siddesh@sourceware.org \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).