From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30831 invoked by alias); 2 Jan 2017 14:35:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 29822 invoked by uid 89); 2 Jan 2017 14:35:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=2.7.4, 34810, 348,10, Hx-languages-length:1910 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-qk0-f194.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=cI2RrL5t8NqueBQ4KN8xitZxjJm5TEJdEDsdmQt55Do=; b=OxJoCvGYoRYvhPhlh9KvqexUvApX0hoaYqOiWzavp3UZRFGsqUA1cDAT6fNIhhZC/b 5Dj2mPVOuG6jNv7Tj0gTPBEm3HhjL68KAsNe+ZgZaUQfb5jw8rV5RMpaKk8l3YITTIJ0 oM3+QEd1mDOzYNN5AeP+Obt/qtLje0HsYUDxu3kXat89p/9E10hhT0hohIP3NjDrYpSK TsbVHCgExSLN3ZgjJ09xvR+v2F4R2kabZvz8swsHG5rwgYGHO6ofVptwHM0pWYGG5dpu PMsqlyu5Ws0coAdFVKJ1wu2QTSld5n3eltCOA0SKVKKXs2mrDfaDSlwtiQMwkmqtYpN3 M7+Q== X-Gm-Message-State: AIkVDXKLqH6EPgtH5SO/E79SaO4i6aNs6qzaHfOFwbjJURpzv9GoBRiIR/nyFZwDQliNww== X-Received: by 10.55.5.145 with SMTP id 139mr57211795qkf.77.1483367720702; Mon, 02 Jan 2017 06:35:20 -0800 (PST) From: Martin Galvan To: libc-alpha@sourceware.org, siddesh@sourceware.org, joseph@codesourcery.com, triegel@redhat.com Subject: Re: [PATCH v11] Add pretty printers for the NPTL lock types Date: Mon, 02 Jan 2017 14:35:00 -0000 Message-Id: <1483367714-28081-1-git-send-email-omgalvan.86@gmail.com> In-Reply-To: References: X-SW-Source: 2017-01/txt/msg00029.txt.bz2 2017-01-02 10:51 GMT-03:00 Joseph Myers : > I'm seeing the following failures with current sources on x86_64. This is > with system GDB on Ubuntu 16.04 (but a locally built compiler, configured > as a cross compiler, for building glibc). Yes, I'm seeing those too. They seem to be caused by a tabs/spaces mismatch introduced in commit ed19993b5b0d05d62cc883571519a67dae481a14. The following patch should fix it: ChangeLog: 2017-01-02 Martin Galvan * nptl/nptl-printers.py: Fix tabs/spaces mismatches. --- nptl/nptl-printers.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/nptl/nptl-printers.py b/nptl/nptl-printers.py index 17463c4..77018e7 100644 --- a/nptl/nptl-printers.py +++ b/nptl/nptl-printers.py @@ -348,10 +348,10 @@ class ConditionVariablePrinter(object): def read_attributes(self): """Read the condvar's attributes.""" - if (self.wrefs & PTHREAD_COND_CLOCK_MONOTONIC_MASK) != 0: - self.values.append(('Clock ID', 'CLOCK_MONOTONIC')) - else: - self.values.append(('Clock ID', 'CLOCK_REALTIME')) + if (self.wrefs & PTHREAD_COND_CLOCK_MONOTONIC_MASK) != 0: + self.values.append(('Clock ID', 'CLOCK_MONOTONIC')) + else: + self.values.append(('Clock ID', 'CLOCK_REALTIME')) if (self.wrefs & PTHREAD_COND_SHARED_MASK) != 0: self.values.append(('Shared', 'Yes')) @@ -409,10 +409,10 @@ class ConditionVariableAttributesPrinter(object): clock_id = (self.condattr >> 1) & ((1 << COND_CLOCK_BITS) - 1) - if clock_id != 0: - self.values.append(('Clock ID', 'CLOCK_MONOTONIC')) - else: - self.values.append(('Clock ID', 'CLOCK_REALTIME')) + if clock_id != 0: + self.values.append(('Clock ID', 'CLOCK_MONOTONIC')) + else: + self.values.append(('Clock ID', 'CLOCK_REALTIME')) if self.condattr & 1: self.values.append(('Shared', 'Yes')) -- 2.7.4