From: Torvald Riegel <triegel@redhat.com>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: GLIBC Devel <libc-alpha@sourceware.org>,
Waiman Long <longman@redhat.com>,
Carlos O'Donell <codonell@redhat.com>
Subject: Re: [PATCH] rwlock: Fix explicit hand-over.
Date: Sat, 25 Mar 2017 20:39:00 -0000 [thread overview]
Message-ID: <1490474164.26906.386.camel@redhat.com> (raw)
In-Reply-To: <87inmxkt67.fsf@mid.deneb.enyo.de>
On Sat, 2017-03-25 at 21:17 +0100, Florian Weimer wrote:
> * Torvald Riegel:
>
> > + bool registered_while_in_write_phase = false;
> > if (__glibc_likely ((r & PTHREAD_RWLOCK_WRPHASE) == 0))
> > return 0;
> > + else
> > + registered_while_in_write_phase = true;
>
> Sorry, this doesn't look quite right. Isn't
> registered_while_in_write_phase always true?
It's intended and I think it's correct, but I agree it's not pretty :)
I'll fix this by cleaning up the code a little more in v2 of this patch.
next prev parent reply other threads:[~2017-03-25 20:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 19:50 Torvald Riegel
2017-03-25 20:17 ` Florian Weimer
2017-03-25 20:39 ` Torvald Riegel [this message]
2017-03-25 23:01 ` [PATCH v2] " Torvald Riegel
2017-03-27 16:09 ` Waiman Long
2017-03-27 17:54 ` Torvald Riegel
2017-03-27 18:16 ` Waiman Long
2017-03-27 18:59 ` Waiman Long
2017-03-27 19:11 ` Waiman Long
2017-04-06 10:51 ` Torvald Riegel
2017-04-06 10:47 ` Torvald Riegel
2017-04-06 10:51 ` Ping! " Torvald Riegel
2017-07-28 5:41 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490474164.26906.386.camel@redhat.com \
--to=triegel@redhat.com \
--cc=codonell@redhat.com \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).