From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117101 invoked by alias); 27 Mar 2017 13:43:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 117086 invoked by uid 89); 27 Mar 2017 13:43:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=sorts, Hx-languages-length:1008 X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EDABA3D97F Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=triegel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EDABA3D97F Message-ID: <1490622199.26906.437.camel@redhat.com> Subject: Re: [PATCH 2/6] Move mutex and condition variable definition to common header From: Torvald Riegel To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Date: Mon, 27 Mar 2017 13:43:00 -0000 In-Reply-To: <1490103612-9401-3-git-send-email-adhemerval.zanella@linaro.org> References: <1490103612-9401-1-git-send-email-adhemerval.zanella@linaro.org> <1490103612-9401-3-git-send-email-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00617.txt.bz2 On Tue, 2017-03-21 at 10:40 -0300, Adhemerval Zanella wrote: > This patch sorts out pthread_mutex_t and pthread_cond_t in new files, > so new C11 types could be based on pthread types without corrupting > namespaces and exposing pthread symbols. > > Common pthread types like pthread_mutex_t and pthread_cond_t are now > defined in arch specific bits/pthreadtypes-common.h headers, while the > internal implementation is moved to bits/thread-shared-types.h. File > pthreadtypes.h is cleaned up of those definitions and some related macros > and structures. If we are moving declarations in pthreadtypes.h around, can we just merge those that are common? Most of the archs just use the same generic code or at least the same underlying data structure; most of the differences I remember where some additional alignment requirements, which probably could be handled by an additional macro that arch-specific files have to define.