From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69465 invoked by alias); 6 Apr 2017 20:48:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 69314 invoked by uid 89); 6 Apr 2017 20:48:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Style X-Spam-User: qpsmtpd, 2 recipients X-HELO: NAM02-SN1-obe.outbound.protection.outlook.com Authentication-Results: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <1491511695.4217.22.camel@caviumnetworks.com> Subject: Re: [Patch] aarch64: Thunderx specific memcpy and memmove From: Steve Ellcey To: Wainer dos Santos Moschetta , libc-alpha Cc: Siddhesh Poyarekar , Adhemerval Zanella Date: Thu, 06 Apr 2017 20:48:00 -0000 In-Reply-To: References: <1490397926.19074.73.camel@caviumnetworks.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN6PR13CA0047.namprd13.prod.outlook.com (10.171.172.33) To CY1PR07MB2444.namprd07.prod.outlook.com (10.166.195.21) X-MS-Office365-Filtering-Correlation-Id: c99acbef-640a-4afc-37ed-08d47d2e4221 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY1PR07MB2444; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2444;3:OTutsc1Im+LKo5CUwQ+ygxkljMe3HziFniMiseVG/XayNtOSxMe2YiK3UDqeVUBW0rhVIlpQBdcZ60kf/bMbqlClO/6B+DgAKBQ1A7gLxsSyKiPSQegUlRGuVTaKGmSvkIm4XvG0sDMBvW79JEkwilh/7TcjjS1N3Vq8EmYWrK8mXb0lfdVhAKeC9YXT5ZE81TQ7KJj2c13id/gQqvitPPrmjPrAEuIEJMmcNXQU2bJeqS2Enbda2iaRmINQmZE2+64Bzg24bTZFXSJhc8AiI40NOn7r+5hj2QW64qJidafuPWTTV5jH1E8Qw5Pq4rk68sShQvixncNbOCXcSiKnYg==;25:u/wYU6ukuAtzy7dFJH/9vk3YvSUjVkBEquwdEvEjEnoVr+1/Gcl2uev/WF3vYoxZw5oz9q5jKKsnVN8+sCJiEBEGwDDFWws3VydpX4XmaetVz3ULNx6uSSjZMc8JJIr56Af3SvK0ixpWk+hLVpvp5FsnyVMvyJiv33KJJnH/0sbcWZEqJx9tUz5Ah67McaEPdUvTGLTPMHjcEKOxFXhqhnSlokBw1hvvZOgUloRWxx9I2csQTrzedTN27ewdhNqff9aEhuXtxfxVErgjpqptVm7gOyV0ygi+4Lion65oS86Q4q+zPro1mF2++TKYOXu/C2QtH/yQB7F0M9oDtFZtNOXvZEWfDp1UsDHxKlZlmx/4hNViH1BlLBJBx+LQM+c0M13JWd+3bSNwkws+VkmiN8u/bAu4lqtvebaqIjDzg2ASLBjyMCWdYa7pMZcVioBnakpg6XRZUPQKXmtSiSS1CQ== X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2444;31:NA0x4NkvroNRbKx897iZVY/W617MurXMUs5iXdYlM/RnSvZqZuhp0S7g89GlviX0KvCFK4SOiBw/c9xSmN796gxDyzKbkjX60Gsx5CxmI5Of3LS23MEYK+jcSXYnfHmOyndAUC1+mTNPtecI0yQ+qA/j7Pw+uiMtSGoOfdwirWVP/fsluvQKriZo7EgmfpxJHE1cJEcXuWMrQq40nitM2JNMlDTXP4jKWTP0xBZR8AJ75BK0FRiiJAAXLCaLJlyDlAhNiO3LvthycB93LMF+nA==;20:lR/0z0AJznNUx0pWvwFUFy7FWauH6LX5Kjc9VUSiKM8eX/VakeiO8nDn8k0WGP9qaqaIWARpTfKVUoL0F2zNKGYVHR3rsrOethP1cj9whKpqFZ1u1FHVS+IvznlmjDGij4NBN7Br48T+n+FnQrUpIMbTsQoZu4M7rxbfDzY+OtkxslLI0t6s0min2uLQBf2osMJFGdq8a70OLRx88i1UugVwULwPwUTT1PUcVvMIESgFrB8xcScREXvvSDl8RFE1eM4j4MVJ6R6CqGjHojUviz+MBEXfVeMfA5yWte4BDx4dMtraekF5dPHosbpnCDovaUN2Z7z6/XCyH3u5PDjYmh2DHj4K1WwuRaygi7+ogmWhQrZr+F2uBJv7IXV8aZnic845+NjDeoYEmfcrEfwgFeCO/WCZZsOJKhL83qO+kD4eh0FfDnYiSNJt2M5tatSAvEbX6PSFHC9MwOVgTHerQ7AvyfjueSnC3KE9FzdnnW1ADUUMdhkJsU2qKYosmGkIQ59MmnuekzCg9PivK/aBwZxsBuPgKTGGe4xffB8pgIaDYoRgYVTb3VNt2sNLxv1pAyruOAKp+yjfeP5/aqmFjSYC35P0T1UtOjT6WsTabxU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(6072148);SRVR:CY1PR07MB2444;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2444; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2444;4:klY5FR8eMh3ABK3O0t66oJahShvBrETVLqP2SwgurBDsel5slNeKvy5CCHk4//s8oNWoI2xPjFnpXxLQr9NFmWfmDGsQk9vQy+tNy2xmwirA7bmfBqIyWnrp6b1CzHSR2D8EZENe8gmTJdHkSQmGH3TcioVINfwJZ9e9UUmjV5NsRPTpYRuqR6ovCIfpMAePPRLUVq+cgxYpdNNuOVyO4dQtmdfT+ZS3X5u7nSN4bL8bBniNADu2NHWz2sxsOS+TIeYS3U7dxb6DTTBhJd/E9tQdbRJbrflI6IxY3q+x4ApWRQ2tu0wn+t7x8q3PmPFAQmNYkHgD1tZwKjLUZIuvk7H7mLM+xhpjCCG26LvCVfAL7UWZsFtQTQxqqmgdXZcxH95Pg/PKA3EM1mpHxTH6liIl9K0puHVoiCsLOF1Y2o/Uc02wj7PmybEteUVf05wJsYqYjSBWRsMwJqXQeaPmotxCH8VuJkXVwkRNnt+oWq4bhozjsffMPIDc3TFTtdEn0eU4cGSeUSMKAPoFsCdZYDnBuqKkNq5qLZb8+QkFP+q8Bo6sGa3nfg2adFH6JaYDu4v9bMRsisbetlJBv1H19AxY4POM7Gxm4kBX2xVldpKB6+YYIcwTeEBYSr1Mo109Cd9aHFihooL/sTIdu/lN2CFkxlprIPt/9HCm4gjcTpjdAW6R3bpgdOeSXhrZ140uMjzWvn90fBDKCC/DsStV9A== X-Forefront-PRVS: 02698DF457 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39840400002)(39450400003)(39410400002)(39400400002)(39850400002)(24454002)(377424004)(42882006)(36756003)(2950100002)(6666003)(47776003)(2870700001)(25786009)(3846002)(6486002)(50226002)(66066001)(6512007)(81166006)(8676002)(2906002)(103116003)(54906002)(53936002)(38730400002)(4326008)(229853002)(6506006)(189998001)(5660300001)(42186005)(23676002)(50466002)(50986999)(76176999)(33646002)(53416004)(7736002)(305945005)(6116002)(5820100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2444;H:sellcey-dt.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjA3TUIyNDQ0OzIzOmtiODZFYzF0VVg3SU1aSVM1VjhUYzRjTEZi?= =?utf-8?B?aXY0WHljN2puTXhLQ24yZVpCVXhQeDYrdXp4VlFxTkoyWFlIRm41RFMyTitS?= =?utf-8?B?bDhTbk94Q3dZQ0t6SCtBK3FYUW83bkNSY0srcS95cFVxbFN6M0RueDlJaGxK?= =?utf-8?B?WjZMZjZTQ3FoamRGU1RtVzhZbG9CVEREV3F1cktWZUZqRWF4Z1ZTY1MwUmhZ?= =?utf-8?B?STNUb1pOdjVPNFB2YUUzQ0lMbVpoc1NoNlY1aEwxa1psdER6WjllaWhLSXU3?= =?utf-8?B?TUdYeW5TYnRvZEk2VjhxRHpKWmJxcXIwaVNjUmhHWFVGcFNvb1d5VzNQWVRC?= =?utf-8?B?NkJKNEhZeUk1Tnd0VUZzT3RxRmFjc2tQeUQwTnh1bXc1b0c0RWtqdUZqYVpo?= =?utf-8?B?YlliUjdXelRSc0QzLzB1Z0M4TVAvSitNL01NaSt2dnc5b1lEaExuWjdYZWUw?= =?utf-8?B?YnFiY2x2L0ErdmJoUExoT0JnZ0k4Rm1mM0dFYW1SNDFlRER1QmhxZklSWWtB?= =?utf-8?B?NFJaRjZQRkxwWHBqRytDRmg3TWV0VE5hbWw5eFBjVWZycVM1ZEpiVkJmblZU?= =?utf-8?B?T0pKUkgrbWI2T3BQWTFZR0F3ZFJobWQyWjEyeEtPdVhWM2thTkZvWnhYS09j?= =?utf-8?B?SkVGY0JjVm9RVUMwbTk3ZkluOVNyVWlHT21RZXpTK096M3UyV2pucmY5NFZ4?= =?utf-8?B?aTVNQWVjRm9wdEFPbWYzOFI2VnRnZkVvQW9RbzRMNHlSU0VGMDU0ditXSFJK?= =?utf-8?B?UmhwUUM0bTQ0TUllNEpzS0FGZ29tZjhlVE1VUDBsajM3ZXlUdzRwVDhUS0J6?= =?utf-8?B?ZU83UFgrUVF6MDFzZ09sQzZlVEpUakxPY01VekwxalFtZnVZeUY3dlk2cnFw?= =?utf-8?B?SHQ0Wk13dXpYbmJYdE1LT2lnYjZsRGlHOURGaEw0eDJEWU9JZlRWYWlhd3k5?= =?utf-8?B?Z3Y4OGgrNW1IV01hcFFKWmRkTzBLeXIxWmloKzFnQVUrY2NZRkx1UytTTFpl?= =?utf-8?B?ckNzejJNWDVDRnowbjh4ZzUyR1BCQ1dLUXZKN3hMclFoN3BRU3BxdlBKNk1n?= =?utf-8?B?SmxQaG5zT0tkN1NFL2JTQmF5WnNQbXlVbE1EQks3TlNHUEFuQncvSng5eHBP?= =?utf-8?B?RlE3UEV0YVFzMHRLRVZsYnFCYUJ5d2x0TlpxaFpmLytPQnVLcEcvcGFVMlBM?= =?utf-8?B?bC9zbTkwZWtLQ1RvU3BoQ1hPMjlLbFlqc3lLbU5DNUFEb0Ftb091SVhSTHZp?= =?utf-8?B?RWlKVUFnTDltMFBVSjZQV1FFQWJTQjhlS0IwNVg0dTBzVjU1eUI3bWVuZ3c2?= =?utf-8?B?M2dvaFpleFpZNDVTTnVYUnE4cXNaZXRXMFJZTVVwUll5ZkZkMktXTTQzY0o5?= =?utf-8?B?dDVIU0hUbDFxTExRVHRXUFExTzdCNDhrTzU5Y2tITVY3Sk13dHJCNUlYbUNV?= =?utf-8?B?QUZHbmVwaXlUMGVXd0ROeVJSYnJGY2Fza1RabTJNU2xjbUFWek9rUFNYWVpp?= =?utf-8?Q?qaBCHmfAVDtyp7jiGQ377Qcwk=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2444;6:9trhDDzPxxDK/XiWY3mYWCv+CrrXQD6rZI0eYOsX6u/juaTsaCtV1EOer7zV9zb4hNopXK+Diro481QYePjyYfpD5M9q64M88CYrFFRJ7z3kQR85VID+3SPWC0RuMhIL3/KEtxF2xyqvZ/IDXUWuCiA9Q1RKnKnFMW+nZ9l9sKg0oL+bonD1DT3jm8fp9/m84XfQQ1PFbI2RnRAcHyBcl7/BRuiazN/LhPffBUuyvKWwtdQBu/F1dHsOTFoc+r1aRASznO+T4R+5JaOoIphoq3/hOs8EHtPBBcxU/AMx3kAm6HJkoWhQLCI56ZTdMIcHJocjtv/TwfDFV72WP+LN5ptTCVkFXGR9yiW5fTT9slwnrGo/9McqO19SKT+12NyC2cnS6M9KRn2Ez0D8SBa9FA==;5:94WmHhZQaTg4N3MdpoxvnmmaWqvV6yS/X0pttpmSMI7sOfL+ZH4eed3Eutoh2Ydc5BrxBj8xO+s9s2ct+Gw0ef2vYFvNf/mnQcTC8Pmb67rKi/6W3b4DfEvEPFmxixQLrTzU4cSYdFLk8NlFykurFJMkUwEAYJ0mfW/O2LHOeMw=;24:U0ps96tTtG81ht9HmvK2VFIMHwkHph04v6vTjuAT13c1YyQmSQDnLvG2NHyA5N4r/xtqxXYgmAv4yckedgx6z2+48p/q6R75qhP6sWiggrc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2444;7:fhxPsUXVELq0529sYFcwAfm8b1dLi7KK7Pkrc0rwOJDucdA6Hoa7rgiSxt0T8ZK+/qiWyNYbtW4gK0Y8Y6G8epnXA6i44jPgwGRbHMMfYueiyFMk9qQpwuu4U9UiKGJRRUnIgwJkN80TzZTfAfUfEx5UL/C3tNjTAS1aKNIxJLRNG/w/MY+iBlhyCq99+l+0xyRtA+PMm126aRhJzdlyOvnBXJq7xw8sy0sSXFwkegRKSt/TUospQ+cjpja26AJTtnLUnecu9DB/WIiFoIyPjT5p+GPLHdVL8/z8QAQa7kGOZLXKC76KSRH8wOrQu3/CAb2xB1F0kObeE/z28o4lZQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2017 20:48:18.9436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2444 X-SW-Source: 2017-04/txt/msg00122.txt.bz2 On Sat, 2017-04-01 at 21:01 -0300, Wainer dos Santos Moschetta wrote: > In sysdeps/aarch64/multiarch/memcpy_generic.S, it has: > +#include "../memcpy.S" > > Is it ok to use relative path here? or rather it's recommended use of > the full path since sysdeps? I think its OK.  I don't see any preference listed in the Coding Style page of the glibc wiki for one way or the other.  I see other includes of relative paths, the most common one is '#include "../test- skeleton.c"' but I also see other examples: sysdeps/sparc/sparc64/multiarch/rtld-memset.c:#include "../rtld-memset.c" sysdeps/sparc/sparc64/multiarch/rtld-memcpy.c:#include "../rtld-memcpy.c" sysdeps/wordsize-64/ftw.c:#include "../../io/ftw.c" sysdeps/wordsize-64/fts.c:#include "../../io/fts.c" sysdeps/unix/sysv/linux/sparc/sparc64/xstat.c:#include "../../i386/xstat.c" sysdeps/unix/sysv/linux/sparc/sparc64/fxstat.c:#include "../../i386/fxstat.c" sysdeps/unix/sysv/linux/sparc/sparc64/fxstatat.c:#include "../../i386/fxstatat.c" sysdeps/unix/sysv/linux/sparc/sparc64/lxstat.c:#include "../../i386/lxstat.c" sysdeps/unix/sysv/linux/aarch64/readelflib.c:#include "../arm/readelflib.c" sysdeps/unix/sysv/linux/wordsize-64/statvfs.c:#include "../statvfs.c" sysdeps/unix/sysv/linux/wordsize-64/getdirentries.c:#include "../getdirentries.c" sysdeps/unix/sysv/linux/wordsize-64/fstatvfs.c:#include "../fstatvfs.c" sysdeps/unix/sysv/linux/wordsize-64/aio_write.c:#include "../../../../pthread/aio_write.c" sysdeps/unix/sysv/linux/wordsize-64/openat.c:#include "../openat.c" That seems more common than using: sysdeps/unix/sysv/linux/s390/s390-32/updwtmp.c:#include "sysdeps/gnu/updwtmp.c" sysdeps/unix/sysv/linux/s390/s390-32/getutmp.c:#include "sysdeps/gnu/getutmp.c" sysdeps/x86_64/fpu/e_sqrtl.c:#include "sysdeps/i386/fpu/e_sqrtl.c" sysdeps/x86_64/fpu/e_atan2l.c:#include "sysdeps/i386/fpu/e_atan2l.c" sysdeps/x86_64/fpu/s_atanl.c:#include "sysdeps/i386/fpu/s_atanl.c" sysdeps/x86_64/fpu/e_acosl.c:#include "sysdeps/i386/fpu/e_acosl.c" Steve Ellcey