* Fix wrong comments in struct ip_mreq_source
@ 2017-05-03 19:42 Phil Blundell
2017-05-03 19:53 ` Carlos O'Donell
0 siblings, 1 reply; 2+ messages in thread
From: Phil Blundell @ 2017-05-03 19:42 UTC (permalink / raw)
To: GNU C Library
The member names in this struct are fairly self-explanatory, but were
contradicted by the comments. Â This patch swaps the comments around so
that they match.
I verified that the order of the elements does match the corresponding
uapi header from the Linux kernel.
OK to commit? Â (I wasn't quite sure whether this was obvious enough to
count as a "trivial fix".)
p.
2017-05-03  Phil Blundell  <pb@pbcl.net>
        * inet/netinet/in.h (struct ip_mreq_source): Correct misplaced
        comments.
diff --git a/inet/netinet/in.h b/inet/netinet/in.h
index 365bc6878e..e064188721 100644
--- a/inet/netinet/in.h
+++ b/inet/netinet/in.h
@@ -275,10 +275,10 @@ struct ip_mreq_source
     /* IP multicast address of group.  */
     struct in_addr imr_multiaddr;
Â
-    /* IP address of source.  */
+    /* IP address of interface.  */
     struct in_addr imr_interface;
Â
-    /* IP address of interface.  */
+    /* IP address of source.  */
     struct in_addr imr_sourceaddr;
   };
 #endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fix wrong comments in struct ip_mreq_source
2017-05-03 19:42 Fix wrong comments in struct ip_mreq_source Phil Blundell
@ 2017-05-03 19:53 ` Carlos O'Donell
0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell @ 2017-05-03 19:53 UTC (permalink / raw)
To: Phil Blundell, GNU C Library
On 05/03/2017 03:42 PM, Phil Blundell wrote:
> The member names in this struct are fairly self-explanatory, but were
> contradicted by the comments. This patch swaps the comments around so
> that they match.
>
> I verified that the order of the elements does match the corresponding
> uapi header from the Linux kernel.
>
> OK to commit? (I wasn't quite sure whether this was obvious enough to
> count as a "trivial fix".)
>
> p.
>
> 2017-05-03 Phil Blundell <pb@pbcl.net>
>
> * inet/netinet/in.h (struct ip_mreq_source): Correct misplaced
> comments.
OK. This counts as a trivial fix. Even if you'd gotten it wrong the comment
change could just be another commit away from being right.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-03 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03 19:42 Fix wrong comments in struct ip_mreq_source Phil Blundell
2017-05-03 19:53 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).