From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id F08D539A0014 for ; Fri, 4 Jun 2021 19:31:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F08D539A0014 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-544-S_AtR6MENsaiC1_Ce9mZ_A-1; Fri, 04 Jun 2021 15:31:35 -0400 X-MC-Unique: S_AtR6MENsaiC1_Ce9mZ_A-1 Received: by mail-qv1-f72.google.com with SMTP id n4-20020ad44a240000b029021cbf9668daso7362343qvz.23 for ; Fri, 04 Jun 2021 12:31:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=7OEzcrYJ3ft1i1B0BpmbZxtnShs426Gz+y3o2xfPCkg=; b=B69axnE8QlwEsSwcK4p53rNyd+eP3C/XMQYhTJhqttWZPoafsVHrVe9oEurh+bc3mF PZSfklLVG+slge0RnppHOp6iTBE/EukWTG21vdN+jVOpZ4T69DAoQSf/4YHJrYzBoElT ncGj4DyXlONGZvd8DH2v/gZRSK81DKC4WDSqbIErsaQgOnVm49vToecPzU1u+0UGevoZ eSqI/0+Au+kWIdQMGXjVwXwlt5G1o0wzq/bbFXTW6YeuBR5eBWuaQk7k0mWlqyvzHw6M X5nwprtevFgBqMojhuYevyGJBxU0JbojF/8SqwVd8WFWPC2ma6hxYbCDJYzJxirG2H2U pYYg== X-Gm-Message-State: AOAM530bgWhbEfVHdEfJO+g8TZ4IY+Ta2DGGP9yCpukUZYJfKRfKpXGu HIcl2mpxgSVyfMcvr9X3mXUnPCKhifFizuoUm+1XGsjgI7rgB6PfFyUivllQM2YhFFlRz1+REqw 9/QyM5AY4GyO9JSwLvx/h X-Received: by 2002:a0c:a323:: with SMTP id u32mr6562775qvu.14.1622835094838; Fri, 04 Jun 2021 12:31:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwWG6D74/Nhnz/3BbvgpQldr3JDfqu45MN+lfJ/FmPJXU9sh//WlNmHzQ1xDt9aIjPuu1Sdg== X-Received: by 2002:a0c:a323:: with SMTP id u32mr6562763qvu.14.1622835094661; Fri, 04 Jun 2021 12:31:34 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id b123sm4822957qke.87.2021.06.04.12.31.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 12:31:34 -0700 (PDT) From: Carlos O'Donell Subject: Re: [PATCH v2 11/25] y2038: Add __USE_TIME_BITS64 support for struct utimbuf To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20210518205613.1487824-1-adhemerval.zanella@linaro.org> <20210518205613.1487824-12-adhemerval.zanella@linaro.org> Organization: Red Hat Message-ID: <149ec5be-d2d2-8584-c899-49c6676a6d5b@redhat.com> Date: Fri, 4 Jun 2021 15:31:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210518205613.1487824-12-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2021 19:31:38 -0000 On 5/18/21 4:55 PM, Adhemerval Zanella wrote: > The __USE_TIME_BITS64 is not defined internally yet. LGTM. Reviewed utime usage in this case. No regressions on x86_64, i686, ppc64le, aarch64, s390x. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > --- > io/utime.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/io/utime.h b/io/utime.h > index df2299e406..c7612d0838 100644 > --- a/io/utime.h > +++ b/io/utime.h > @@ -35,8 +35,13 @@ __BEGIN_DECLS > /* Structure describing file times. */ > struct utimbuf > { > +#ifdef __USE_TIME_BITS64 > + __time64_t actime; /* Access time. */ > + __time64_t modtime; /* Modification time. */ OK. > +#else > __time_t actime; /* Access time. */ > __time_t modtime; /* Modification time. */ > +#endif > }; > > /* Set the access and modification times of FILE to those given in > -- Cheers, Carlos.