From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26166 invoked by alias); 3 Jun 2017 13:58:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 26146 invoked by uid 89); 3 Jun 2017 13:58:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-qk0-f193.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=yBMKJSxwRQoIpUCch6mJx+ZTgg+bS6RfeX4ponatke8=; b=Zom7zINxeRuBp6jGNXxuc/47AHqmAPmdz5NdYny4HsZBxSxa8tuquzsEGIIciHJhK+ 7L9nD5r6E37vAU+Ytn9vXTg+1BQTXG0WJpd3uW6BvdQshqvvkA6liFSvH+AYjzjYgjB8 jYNOTc97JCdUb9cO32Sx3MJC8KASg8IZbOcm/39totuBwHcZe2fl/NfVANwa9JQ6zJ3a Ujc9aSLc6O3kmkp/lkDevKgN/SLrU58IRF4oQbtf3uxSQfliSo8Se/X/hMJ4gI8KwJu2 AZQqDNGRFNLHtvt6McMZY/wUBi6qLJn/IsomG6EitzgiznfmC6Skci9TldeYB0hqnQ5k BNgg== X-Gm-Message-State: AKS2vOw8/Yn7oa5Gx/Pnd+zPpZoIDe49bchhFTnLzLQ8BwbtBfjddlGQ 8luqxQ9Q7ZV8kfW9r6w= X-Received: by 10.233.222.5 with SMTP id s5mr6791369qkf.190.1496498294994; Sat, 03 Jun 2017 06:58:14 -0700 (PDT) Subject: Re: [PATCH v3 2/2] posix: Implement preadv2 and pwritev2 To: "H.J. Lu" References: <1493901791-13438-1-git-send-email-adhemerval.zanella@linaro.org> <7412360d-c776-532b-e22c-dd3f0048cfba@linaro.org> <7f07b067-a074-d670-88b1-3da917451c71@redhat.com> <77f9ac84-620a-a408-c448-14a6978f5d2e@linaro.org> Cc: Florian Weimer , Andreas Schwab , Adhemerval Zanella , Siddhesh Poyarekar , GNU C Library From: Zack Weinberg Message-ID: <14aca656-8e0f-01b2-ead6-94a9f200f33e@panix.com> Date: Sat, 03 Jun 2017 13:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00156.txt.bz2 On 06/03/2017 09:52 AM, H.J. Lu wrote: > On Sat, Jun 3, 2017 at 6:48 AM, Zack Weinberg wrote: >> If nothing else, always passing the unused argument as 0 will reduce >> confusion when people inspect these syscalls, e.g. through the debugger >> interface or the seccomp filter interface. I think that's a sufficient >> reason to do it. These are all I/O syscalls that can block, it's the >> wrong place to be shaving cycles. > > LO_HI_LONG_FLAGS is still needed for x32, regardless what we > do with LO_HI_LONG. But x32 won't get the definition of LO_HI_LONG that expands to "(val), 0)" - that would be wrong - so why won't LO_HI_LONG(val), flags work? zw