From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Lirong Yuan <yuanzi@google.com>, Andreas Schwab <schwab@linux-m68k.org>
Cc: Lirong Yuan via Libc-alpha <libc-alpha@sourceware.org>,
Shu-Chun Weng <scw@google.com>
Subject: Re: [PATCH v2] locale: update _nl_C_LC_CTYPE_class and _nl_C_LC_CTYPE_class32 arrays to have types uint16_t and uint32_t respectively
Date: Thu, 1 Apr 2021 15:55:15 -0300 [thread overview]
Message-ID: <14bfab6d-8df0-96fa-2e32-a83e2adeb430@linaro.org> (raw)
In-Reply-To: <CADjx4C+E9SmYsKiJcCcMrgbWdEvfXH2CUf_f8YcG9rewROBNeA@mail.gmail.com>
On 01/04/2021 14:29, Lirong Yuan via Libc-alpha wrote:
> Thanks for the information! I have applied for a GCC Compile Farm account.
>
> "Since account moderation is done manually, it may take a few days before
> the request is reviewed."
>
> Regards,
> Lirong
I have checked this patch on powerpc64-linux-gnu and unfortunately it breaks
locale. Running localedef:
$ ./testrun.sh /home/azanella/projects/glibc/build/powerpc64-linux-gnu/locale/localedef --quiet -c -f UTF-8 -i en_US /home/azanella/projects/g
/home/azanella/projects/glibc/build/powerpc64-linux-gnu/locale/localedef: invalid option -- 'c'
Try `localedef --help' or `localedef --usage' for more information.
It fails on the argp_parse routine (I haven't dig into to check where exactly).
The first version that uses _alias does not trigger any regression so I think
it would be a better option. Another option is to define the arrays with a
macro that define it in the same layout regardless of the endianess, but the
alignas macro is clearly a simpler approach.
next prev parent reply other threads:[~2021-04-01 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 17:25 Lirong Yuan
2021-03-30 17:57 ` Andreas Schwab
2021-03-30 18:04 ` Lirong Yuan
2021-03-30 18:33 ` Andreas Schwab
2021-03-30 19:03 ` Lirong Yuan
2021-04-01 8:22 ` Andreas Schwab
2021-04-01 17:29 ` Lirong Yuan
2021-04-01 18:55 ` Adhemerval Zanella [this message]
2021-04-01 19:42 ` Lirong Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14bfab6d-8df0-96fa-2e32-a83e2adeb430@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=scw@google.com \
--cc=yuanzi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).