From: Mark Wielaard <mark@klomp.org>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] S390: Sync ptrace.h with kernel. [BZ #21539]
Date: Tue, 18 Jul 2017 14:40:00 -0000 [thread overview]
Message-ID: <1500388801.14595.393.camel@klomp.org> (raw)
In-Reply-To: <1500388111.14595.388.camel@klomp.org>
On Tue, 2017-07-18 at 16:28 +0200, Mark Wielaard wrote:
> On Tue, 2017-07-18 at 10:11 -0400, Carlos O'Donell wrote:
> > On 07/18/2017 09:39 AM, Dmitry V. Levin wrote:
> > > On Tue, Jul 18, 2017 at 09:31:49AM -0400, Carlos O'Donell wrote:
> > >> On 07/18/2017 06:20 AM, Dmitry V. Levin wrote:
> > >>> The following change fixes this and similar compilation issues that arise
> > >>> when sys/ptrace.h is included after linux/ptrace.h:
> > >>
> > >> This is a known conflict, and needs to be fixed properly using libc-compat.h
> > >> on the kernel side and the appropriate defines on the glibc side.
> > >
> > > No, there was no conflict between asm/ptrace.h and sys/ptrace.h on s390
> > > in glibc-2.25, and we should avoid introducing new conflicts.
> >
> > I have not verified that inclusion worked on both orders, if it did, then
> > this is indeed a regression.
>
> It used to work either way. We used asm/ptrace.h then sys/ptrace.h on
> s390[x] in elfutils. That broke with 2.26 in fedora rawhide. So we
> changed it to sys/ptrace.h then asm/ptrace.h. I verified that order
> works on both old and new glibc/kernel headers (aka on RHEL7 s390[x] and
> fedora rawhide s390x).
One more note. This really is only an issue for s390x since asm/ptrace.h
provides ptrace_area which is needed to use PTRACE_PEEKUSR_AREA. On
other architectures you only need sys/ptrace.h so it doesn't really
matter whether you can include them both.
See also the glibc testcase
sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c which also needs
to include both.
Cheers,
Mark
next prev parent reply other threads:[~2017-07-18 14:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 10:17 Stefan Liebler
2017-06-06 10:44 ` Andreas Schwab
2017-06-06 10:58 ` Dmitry V. Levin
2017-06-06 11:56 ` Stefan Liebler
2017-06-08 12:02 ` Stefan Liebler
2017-06-13 20:05 ` Dmitry V. Levin
2017-06-19 13:11 ` Stefan Liebler
2017-06-19 13:26 ` Dmitry V. Levin
2017-06-19 14:34 ` Stefan Liebler
2017-06-30 10:09 ` Florian Weimer
2017-07-04 8:22 ` Stefan Liebler
2017-07-04 9:41 ` Florian Weimer
2017-07-04 15:37 ` Stefan Liebler
2017-07-07 10:22 ` Stefan Liebler
2017-07-07 10:45 ` Florian Weimer
2017-07-07 13:54 ` Stefan Liebler
2017-07-11 8:39 ` Stefan Liebler
2017-07-18 10:20 ` Dmitry V. Levin
2017-07-18 13:31 ` Carlos O'Donell
2017-07-18 13:39 ` Dmitry V. Levin
2017-07-18 14:11 ` Carlos O'Donell
2017-07-18 14:28 ` Mark Wielaard
2017-07-18 14:40 ` Mark Wielaard [this message]
2017-07-20 7:38 ` Stefan Liebler
2017-07-20 8:07 ` Carlos O'Donell
2017-07-20 8:32 ` Stefan Liebler
2017-07-24 3:51 ` Dmitry V. Levin
2017-07-24 7:18 ` Stefan Liebler
2017-07-18 13:41 ` Stefan Liebler
2017-07-18 14:12 ` Carlos O'Donell
2017-07-18 14:16 ` Dmitry V. Levin
2017-07-19 8:40 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500388801.14595.393.camel@klomp.org \
--to=mark@klomp.org \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).