public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Steve Ellcey <sellcey@cavium.com>
To: libc-alpha <libc-alpha@sourceware.org>
Subject: [PATCH] Remove compat from DEFAULT_CONFIG lookup strings
Date: Thu, 17 Aug 2017 21:31:00 -0000	[thread overview]
Message-ID: <1503005428.2986.20.camel@cavium.com> (raw)

This patch is based on the discussion string at:

https://sourceware.org/ml/libc-alpha/2017-08/msg00531.html

Basically a change was made to remove the nss compat lookup
method by default from glibc.  It is available if glibc
is configured with --enable-obsolete-nsl.  Some tests were
still using the compat lookup method because DEFAULT_CONFIG
still included that method in the files below.  Depending on
how you test that might not cause any failures because if
libnss_compat could not be found in the glibc build directories
the dynamic linker would search the default host directories
and pick it up from there, only if it couldn't find it in
either place would the tests (grp/testgrp, nss/bug17079,
posix/globtest, and pwd/tst-getpwfail) fail.

This patch removes the compat lookup method from the
DEFAULT_CONFIG strings.  Tested on x86 and aarch64 with
no regressions.

OK to checkin?


2017-08-17  Steve Ellcey  <sellcey@cavium.com>

	* nss/grp-lookup.c (DEFAULT_CONFIG): Remove compat method.
	* nss/pwd-lookup.c (DEFAULT_CONFIG): Likewise.
	* nss/spwd-lookup.c (DEFAULT_CONFIG): Likewise.


diff --git a/nss/grp-lookup.c b/nss/grp-lookup.c
index 8cb00aa..256d2af 100644
--- a/nss/grp-lookup.c
+++ b/nss/grp-lookup.c
@@ -17,6 +17,6 @@
    <http://www.gnu.org/licenses/>.  */
 
 #define DATABASE_NAME group
-#define DEFAULT_CONFIG "compat [NOTFOUND=return] files"
+#define DEFAULT_CONFIG "files"
 
 #include "XXX-lookup.c"
diff --git a/nss/pwd-lookup.c b/nss/pwd-lookup.c
index 00040d4..8612c39 100644
--- a/nss/pwd-lookup.c
+++ b/nss/pwd-lookup.c
@@ -17,6 +17,6 @@
    <http://www.gnu.org/licenses/>.  */
 
 #define DATABASE_NAME passwd
-#define DEFAULT_CONFIG "compat [NOTFOUND=return] files"
+#define DEFAULT_CONFIG "files"
 
 #include "XXX-lookup.c"
diff --git a/nss/spwd-lookup.c b/nss/spwd-lookup.c
index 319a7bb..2c866d1 100644
--- a/nss/spwd-lookup.c
+++ b/nss/spwd-lookup.c
@@ -18,6 +18,6 @@
 
 #define DATABASE_NAME shadow
 #define ALTERNATE_NAME passwd
-#define DEFAULT_CONFIG "compat [NOTFOUND=return] files"
+#define DEFAULT_CONFIG "files"
 
 #include "XXX-lookup.c"

             reply	other threads:[~2017-08-17 21:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 21:31 Steve Ellcey [this message]
2017-08-18  0:18 ` DJ Delorie
2017-08-18 20:50   ` Steve Ellcey
2017-08-18 21:12     ` Joseph Myers
2017-08-18 21:35       ` Steve Ellcey
2017-08-18 22:12         ` Joseph Myers
2017-08-18 22:17           ` Steve Ellcey
2017-08-22 16:33           ` Steve Ellcey
2017-08-22 21:07             ` DJ Delorie
2017-08-28 20:23               ` Steve Ellcey
2017-08-28 20:48                 ` Joseph Myers
2017-08-28 21:50                   ` Steve Ellcey
2017-08-28 22:58                     ` Joseph Myers
2017-08-29 19:04                       ` Steve Ellcey
2017-08-29 20:23                         ` Joseph Myers
2017-08-29 20:57                         ` DJ Delorie
2017-08-31  7:21                         ` Andreas Schwab
2017-08-31 15:25                           ` Steve Ellcey
2017-09-11 20:01                             ` Steve Ellcey
2017-09-11 20:39                             ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503005428.2986.20.camel@cavium.com \
    --to=sellcey@cavium.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).