From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 16AF6384C90E for ; Tue, 6 Dec 2022 17:33:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 16AF6384C90E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670348011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dd6ND8//oxJcCuaOR6QXyOU9myCwVEy3A+Pa+nDYRBQ=; b=G8l1kF/fudxudJm/U4tWKaT5xY3o4gQnCKrsgPhBZEKNcfuOoQJhevnjfSxx9uqTnKhB+h m8yjfdVBPgVDyAy17tPjDegIvXAYv+ulOUGJ5imb0hVzPSVvoh7pNOl2Mzp6lp8jJEnMGw dV9oI7dfDCWAjqcUzx1ZDvIhszS5KBY= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-557-Wq7GghmfPxiYc91TWBfd8g-1; Tue, 06 Dec 2022 12:33:30 -0500 X-MC-Unique: Wq7GghmfPxiYc91TWBfd8g-1 Received: by mail-il1-f198.google.com with SMTP id k6-20020a92c246000000b003035797fa8cso6149327ilo.8 for ; Tue, 06 Dec 2022 09:33:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dd6ND8//oxJcCuaOR6QXyOU9myCwVEy3A+Pa+nDYRBQ=; b=MtwwIeyN4NctXHjV6PS733QEjBJZ8G5iNOUIcLUulsxbeIKzqjb+6eFM34J3ZcCg1T k2g+8eVU/KZ2HSz14y7ZcLD7LYB2Z7W90O/k9DNJPSGLbiYiHsPUPKj1k1TXc+eQUq8z ag7R7UDTEhsDO8xw3KQHRbCwI7fmA28F6rqFHjRi9LxRLhCdNTcSizG6Wle66uqUeE+S a1lrzwnzrI5+0Imn4EDSqBbMALBLutfDInPEm0rkvJuxeZZNx1ZRaQLTTWNGZy/RxyvH wWka4P4gKWp0H6U0jHRKFVtWzLxY3dQpqdtkFjLNb+aTtDD+OYXZt/XhBqi9RGtPWheX G3sw== X-Gm-Message-State: ANoB5pmVNa6vrIfhDZhe54rdwUkcLRm5ofWCE6a49yNniyQ3wRkbi1fy ThFEE9PHwmuJs/076nOYEGKdkqLF4Lav4UXSTTxpcifqlWiXprciy3lQA+nv4a/z2IGk1K6J28K UsRs6jMI494eHC3PCBpQE X-Received: by 2002:a05:6e02:78b:b0:303:14dc:b7d1 with SMTP id q11-20020a056e02078b00b0030314dcb7d1mr19237613ils.142.1670348009868; Tue, 06 Dec 2022 09:33:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf6Icoe+j+SK/GJ0krUNSb5rPKIqRMGGeFXCGWJAR5vdnTBfgVG5El77ev3rl2rJsaXhVz7O1A== X-Received: by 2002:a05:6e02:78b:b0:303:14dc:b7d1 with SMTP id q11-20020a056e02078b00b0030314dcb7d1mr19237604ils.142.1670348009651; Tue, 06 Dec 2022 09:33:29 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id c12-20020a02330c000000b0037508cc0bc2sm6804880jae.12.2022.12.06.09.33.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 09:33:29 -0800 (PST) Message-ID: <150a459a-c5ee-c240-9488-a785acac2851@redhat.com> Date: Tue, 6 Dec 2022 12:33:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 27/30] Linux: make generic xstatver.h the default one To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20221019221433.1082017-1-adhemerval.zanella@linaro.org> <20221019221433.1082017-28-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20221019221433.1082017-28-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/19/22 18:14, Adhemerval Zanella via Libc-alpha wrote: > And copy the current default one to required ABIs. LGTM. No regressions on x86_64 and i686. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > --- > sysdeps/unix/sysv/linux/{generic => arm}/xstatver.h | 11 +++++++---- > sysdeps/unix/sysv/linux/hppa/xstatver.h | 13 +++++++++++++ > sysdeps/unix/sysv/linux/sh/xstatver.h | 13 +++++++++++++ > sysdeps/unix/sysv/linux/xstatver.h | 11 ++++------- > 4 files changed, 37 insertions(+), 11 deletions(-) > rename sysdeps/unix/sysv/linux/{generic => arm}/xstatver.h (52%) > create mode 100644 sysdeps/unix/sysv/linux/hppa/xstatver.h > create mode 100644 sysdeps/unix/sysv/linux/sh/xstatver.h > > diff --git a/sysdeps/unix/sysv/linux/generic/xstatver.h b/sysdeps/unix/sysv/linux/arm/xstatver.h > similarity index 52% > rename from sysdeps/unix/sysv/linux/generic/xstatver.h > rename to sysdeps/unix/sysv/linux/arm/xstatver.h > index d8fd35beb6..8e1801b603 100644 > --- a/sysdeps/unix/sysv/linux/generic/xstatver.h > +++ b/sysdeps/unix/sysv/linux/arm/xstatver.h > @@ -1,10 +1,13 @@ > /* Versions of the 'struct stat' data structure used in compatibility xstat > functions. */ > -#define _STAT_VER_KERNEL 0 > -#define _STAT_VER_LINUX 0 > -#define _STAT_VER _STAT_VER_KERNEL > +#define _STAT_VER_LINUX_OLD 1 > +#define _STAT_VER_KERNEL 1 > +#define _STAT_VER_SVR4 2 > +#define _STAT_VER_LINUX 3 > +#define _STAT_VER _STAT_VER_LINUX OK. Matches. > > /* Versions of the 'xmknod' interface used in compatibility xmknod > functions. */ > -#define _MKNOD_VER_LINUX 0 > +#define _MKNOD_VER_LINUX 1 > +#define _MKNOD_VER_SVR4 2 > #define _MKNOD_VER _MKNOD_VER_LINUX OK. Matches. > diff --git a/sysdeps/unix/sysv/linux/hppa/xstatver.h b/sysdeps/unix/sysv/linux/hppa/xstatver.h > new file mode 100644 > index 0000000000..8e1801b603 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/hppa/xstatver.h > @@ -0,0 +1,13 @@ > +/* Versions of the 'struct stat' data structure used in compatibility xstat > + functions. */ > +#define _STAT_VER_LINUX_OLD 1 > +#define _STAT_VER_KERNEL 1 > +#define _STAT_VER_SVR4 2 > +#define _STAT_VER_LINUX 3 > +#define _STAT_VER _STAT_VER_LINUX OK. Matches. > + > +/* Versions of the 'xmknod' interface used in compatibility xmknod > + functions. */ > +#define _MKNOD_VER_LINUX 1 > +#define _MKNOD_VER_SVR4 2 > +#define _MKNOD_VER _MKNOD_VER_LINUX OK. Matches. > diff --git a/sysdeps/unix/sysv/linux/sh/xstatver.h b/sysdeps/unix/sysv/linux/sh/xstatver.h > new file mode 100644 > index 0000000000..8e1801b603 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/sh/xstatver.h > @@ -0,0 +1,13 @@ > +/* Versions of the 'struct stat' data structure used in compatibility xstat > + functions. */ > +#define _STAT_VER_LINUX_OLD 1 > +#define _STAT_VER_KERNEL 1 > +#define _STAT_VER_SVR4 2 > +#define _STAT_VER_LINUX 3 > +#define _STAT_VER _STAT_VER_LINUX OK. Matches. > + > +/* Versions of the 'xmknod' interface used in compatibility xmknod > + functions. */ > +#define _MKNOD_VER_LINUX 1 > +#define _MKNOD_VER_SVR4 2 > +#define _MKNOD_VER _MKNOD_VER_LINUX OK. Matches. > diff --git a/sysdeps/unix/sysv/linux/xstatver.h b/sysdeps/unix/sysv/linux/xstatver.h > index 8e1801b603..d8fd35beb6 100644 > --- a/sysdeps/unix/sysv/linux/xstatver.h > +++ b/sysdeps/unix/sysv/linux/xstatver.h > @@ -1,13 +1,10 @@ > /* Versions of the 'struct stat' data structure used in compatibility xstat > functions. */ > -#define _STAT_VER_LINUX_OLD 1 > -#define _STAT_VER_KERNEL 1 > -#define _STAT_VER_SVR4 2 > -#define _STAT_VER_LINUX 3 > -#define _STAT_VER _STAT_VER_LINUX OK. Move to the targets. > +#define _STAT_VER_KERNEL 0 > +#define _STAT_VER_LINUX 0 > +#define _STAT_VER _STAT_VER_KERNEL > > /* Versions of the 'xmknod' interface used in compatibility xmknod > functions. */ > -#define _MKNOD_VER_LINUX 1 > -#define _MKNOD_VER_SVR4 2 OK. Move to the targets. > +#define _MKNOD_VER_LINUX 0 > #define _MKNOD_VER _MKNOD_VER_LINUX -- Cheers, Carlos.