public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Juro Bystricky <juro.bystricky@intel.com>
To: libc-alpha@sourceware.org
Cc: joseph@codesourcery.com, ldv@sourceware.org,
	jurobystricky@hotmail.com,
	Juro Bystricky <juro.bystricky@intel.com>
Subject: [PATCH 0/1] improve build reproducibility
Date: Tue, 14 Nov 2017 21:51:00 -0000	[thread overview]
Message-ID: <1510696306-26199-1-git-send-email-juro.bystricky@intel.com> (raw)

There is a subtle non-determinism when building glibc.
Basically, under the same conditions (same build host, toolchain, etc.) we occasionally
ended up with slightly different binaries. This was eventually tracked down to the fact
that sometimes the libraries were built using the checked-in intl/plural.c and some other
times using a different version of intl/plural.c generated by Bison from intl/plural.y.
It seems that the generation of intl/plural.c is not quite deteministic, most likely due
to the fact that GIT does not preserve file modification time.

This patch proposes to unconditionally generate plural.c from plural.y

More on the subject (including a diffoscope output that demonstrates the differences) can
be seen here:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=12291

There is also bug filed in glibc Bugzilla:
https://sourceware.org/bugzilla/show_bug.cgi?id=22432


Juro Bystricky (1):
  intl/plural.c: improve reproducibility

 INSTALL       |    2 +-
 configure     |  128 ++--
 intl/Makefile |    3 +-
 intl/plural.c | 2011 ---------------------------------------------------------
 4 files changed, 65 insertions(+), 2079 deletions(-)
 delete mode 100644 intl/plural.c

-- 
2.7.4

             reply	other threads:[~2017-11-14 21:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 21:51 Juro Bystricky [this message]
2017-11-14 21:52 ` [PATCH 1/1] intl/plural.c: improve reproducibility Juro Bystricky
2017-11-14 21:59   ` Joseph Myers
2017-11-15  8:00   ` Rical Jasan
2017-11-15 16:45     ` Bystricky, Juro
2017-11-15 16:55     ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510696306-26199-1-git-send-email-juro.bystricky@intel.com \
    --to=juro.bystricky@intel.com \
    --cc=joseph@codesourcery.com \
    --cc=jurobystricky@hotmail.com \
    --cc=ldv@sourceware.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).