From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129950 invoked by alias); 15 Nov 2017 22:09:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 129938 invoked by uid 89); 15 Nov 2017 22:09:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: NAM02-BL2-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1510783744.1836.25.camel@cavium.com> Subject: Re: [PATCH] add attribute nonstring From: Steve Ellcey Reply-To: sellcey@cavium.com To: Martin Sebor , Joseph Myers Cc: GNU C Library , Paul Eggert Date: Wed, 15 Nov 2017 22:09:00 -0000 In-Reply-To: <11c4caec-df98-12e6-c6f5-cfc95eb8b8d6@gmail.com> References: <11c4caec-df98-12e6-c6f5-cfc95eb8b8d6@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MWHPR22CA0007.namprd22.prod.outlook.com (10.172.163.145) To BN6PR07MB3540.namprd07.prod.outlook.com (10.161.153.142) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c058aae6-1dee-43b9-b362-08d52c757e8e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:BN6PR07MB3540; X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3540;3:9pgEk6LaEn6p3hUQv+j10ASQZ20FNB/kQGeD2pUFvnvYjVzTBNe406gs7FyiVs/NyFTLjzmVi2cZwbQaCKWGurlq8JXOL5PBbBa1fJIah4pDdM2da756ukfZ8vXkuaOrIcscMGchpypLK26PF1nQvXperlIw1nl8Br+PwD2Lv8dYUBwR4VMTJ7qE+bZWRw7ANNqOx8gmzpUjWjyHfSkZHAeaBvdS26LWhA/AXEfTaFsv6ow418Zi0eKY1gDJwFgx;25:z/87xZY8TTfJ8ZKzjsK03uIzyl8kzDm0nCta6YiZ5laPU54wDM0yiwcBGZwbvwKsCx8Fyw5axygjlKatWUCwUDFMhU9piRGif5vEQDGeTc7xzrf/LhhwvLiEv6qVfrzslF1dwkywThAYkuyIu9yoTPl3on7fA6FZfcARRu3PYlOPgL1T0qRv3IzWJqZe0wEzfs7kwAptZq/YDDCL43XsuUM4LxJdXkXiD3/bdRK3DkfR+KNGLV3hN8/eu2851O3T9mw0CXUPemAG47IVVb47pb4i/xaCdo/qtYzmPNdle2dYXHXDuf8vhs+y4CiSaxG7ksZw5O8fFRom/0YW43EDWQ==;31:jIvqHXjea1kw9SJNNDfsKcDRZYGu+Nqzns+4fYCpuhtctwiZjcE8tJkZFkbM8zjfHTdyppFvkJ2QO054BL5vlPh0Ew9HLkxSNTAK24Ubjq5jmX90liyxwP3rmxlz30SFSNlb4zNScjtkUEaCTiG3vq+nKYe+3jUsh9fQsktdxDUg58VNcKoA0RTxQ0melg8DVurPSFxkaIfNoFilEZXoPlmMVXIn/Z3iiCIBlh2vrQU= X-MS-TrafficTypeDiagnostic: BN6PR07MB3540: X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3540;20:6PQai40RSQ1aJhjhSBBnOXx0i0P5+f8fJ4nANl0VdvjjR5BEUP6R/KIohWlaBQBNDxJXz0ZEK69xe1unNs2WTUqiGjRGkD+EEThrVtyKm6cingxUyQkjit97X74QPFJWYyhGOcK+or07uzhvY0Lf2sG+l4nwY84PoBB9JgB+7MLH9FkOoZ+CLIaZRwHc7GWAqW/zTmJg8Omnn3bSv+6QWaj8FBTpRBx7T1WyNmtG6922hIr5XRLRwHCfB/soqwoCufh8FE0CUZ8eAtPSusZ5ssvz9rZKHEhpgf+bEY2oDXFRAm+gC5MKuexA8uf+Hr6CfAHWM5tVUg1zeSmj/YSYcWJfmeT7+OCyyLbnlgFKkoUDHZd2AD91nxzBQYc5dT/TKLrtl/B2iWOpU8yY52jzfxPZgelK/W6xNXXQfvsetGnSr9EZZLiTW/KOMB/5gPOX5Ui4QA+3caQDfVssv+b+B43IhE8SAZt2yVIJ+Znh9wudQGA9nAhcRqI0gYnVdNtL;4:d6HE53+gWjY+BDoHKy4xl8YdV8NoWkVsYTFHgnkhNMkCfnjPt4qVhqM6U1yCNcrAztTB/ce8vKpPIkEIdet1nzSAr+RXLDGgheEY0M/7ysKcS1LPXXEh+1ucdDDjkfVjMe60eUTfYA1ApmFm4f2Bh31vwwkfcmjghcvMnOXWIjjnCwUnoOXYKO01ot2OtdQKXy28FgqLgKwr4tRTu6E/QnRbzx+XfpXPhXx35sVnJyaFl4UZHWMN/C3XRpURGhHXS55ce2ADqmfncnYnzf1Dtg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(3231022)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR07MB3540;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR07MB3540; X-Forefront-PRVS: 0492FD61DD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(377424004)(24454002)(189002)(199003)(69596002)(3450700001)(110136005)(54906003)(23676003)(53416004)(189998001)(101416001)(66066001)(6486002)(305945005)(97736004)(43066004)(7736002)(229853002)(2906002)(5820100001)(47776003)(2870700001)(103116003)(316002)(36756003)(4001150100001)(8676002)(50466002)(16526018)(50226002)(81156014)(2950100002)(6116002)(76176999)(5660300001)(50986999)(478600001)(53936002)(6666003)(105586002)(6506006)(33646002)(25786009)(6512007)(6246003)(4326008)(72206003)(81166006)(68736007)(39060400002)(106356001)(8936002)(3846002)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR07MB3540;H:sellcey-dt.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjA3TUIzNTQwOzIzOk41alZFc0hUUFRUNFVXZ0pNZVZnUUU3ZWIw?= =?utf-8?B?ME9RejhNR0FhNGNMQ25JY3cyVTRqZDRSeThZemFuV0dWNGFDay8wYUhiWFhK?= =?utf-8?B?bFBYWkdHUUdmTWVxc1JueUJtVk1iTFZNUUVZcUliL0t3R1N0d1Z2czFIc0FZ?= =?utf-8?B?SDYxUzhtU2FBZEZLdkVmYUE4VkJCdVFTL3hQYVYzVnhKalVtbEpqeFgxZWNB?= =?utf-8?B?M0VrNzRpOTFqcXIwNVliL3ZuR0NKc0dsRGlFTVJzeGlLWWE1V3loNkROYXpO?= =?utf-8?B?WGwyTjhZQll0WlE0bkU4NTNnRjROVXg1WldrTENoZFNnNElRNmNCSkwwa0Zv?= =?utf-8?B?MmsrUHkzeFQvMWZPOGk3a2kzL3lUOWIxeGk2OUc4SEFwckxvTEhUZC9pN3hy?= =?utf-8?B?VGFiT3FNaThKU0lXR3BJeGRna3NBZWh3NFhTYjRpek8rMnZsUTVxM05ZcHlF?= =?utf-8?B?MlBnKzNVeFNtLzBSSUJ5RmxubzJHdlR1aHdUeTJlVzZVZFZMUldjWG5pRlJx?= =?utf-8?B?TEFzdEJPOTB5Z0gzTTEyTThueFpiNUcrRmhyWElYTUVuMTUzNkZ3V1ZnZzJk?= =?utf-8?B?aHZPdXdhSkJGZ2MyMXJZVkFpbGRzbkMwbXpxWXorZ01pR0RMeTFTZXBlcXN3?= =?utf-8?B?VGF3Z0lpMlp0YXdiTWVHVXBWTm5SYW14eVFoWnRKQ1Z0QnRUZ0NQV09JdDNv?= =?utf-8?B?UHZOQUZMRnZOODhKN1VsazdIV3VqM3JQeUZEYUxxSVIraUdud3c5c01oeGky?= =?utf-8?B?c2dsZ1FZcHlwU1owbm1PelcvZHorQ21MVHRGYjBYWVFwbE13alN5MkF2emo0?= =?utf-8?B?d3hwKzVwWDhiQ2hyTHp5dUczdCtoYTVndktkNzRsVXovOUhuV01kaFhSRFFK?= =?utf-8?B?Y0lnSHowY2FnQ3JhRnpVVnBOMzYydVlBdStydzJaaCtaWVl1cDJhTkpNdTcw?= =?utf-8?B?UGoxWXZ5Zk9idW1CWlBXVWMzamhtMXRaVGhkKzhreEdvTWJjTUxRanVQYzlx?= =?utf-8?B?cnprdHFaR0tiVVY1NTE4MlRXS3ExeFlNREVKeGdmbjZFQ3lLb2QzbVFHVmlW?= =?utf-8?B?bEhnY2ZWSXdHMGJ0SFVoUmNYcWFzWEUzYXRqdkNjYXZLN0ZZeGhMd0UwenJ3?= =?utf-8?B?M2ZnRTZweVg2TGNFQ2tSYk9BdFRLK0IxWlNxTDZpUlBYUDM0UTJaYTlQYm8r?= =?utf-8?B?TjZDWGtZam9WUllNbkNMQ0JUZVErVUp6cVM3ZzBIQktEUHVqNDZhZ0p5Ulgx?= =?utf-8?B?aUFLV2RiNGw0MnJLZkRtWGxYdHV0M2FBQ3I2Vm5mY0E5M2J5c29lOFZKYzZ3?= =?utf-8?B?RW4vNEJEcVNVUVNVckJuTDlWb2FmUEszQWc1VU9SLzlXSDlJK0hCbXVLR3Rh?= =?utf-8?B?eVJ6Y2ZJMjJnZ1V3a3dWanRrYXFsZHZEODljTmxEUHFaSzlxcTVRZkY2WkFr?= =?utf-8?B?bGgwS3hDUk9BSmVVRFZsTFA4enA3cldIWmVZREtuYVh0WkdIUGtuWHlEYTRC?= =?utf-8?B?MUhaejJwOW5UMlloQXJocHcwRm5iMUxhMUgrazI0VVMwRThvYlJtdDFzcGJi?= =?utf-8?B?S0xRNUc4enpiclVScmowL3plUGwvajdmRER6cDJPVFV6SEpTbzY2c043Rzlm?= =?utf-8?B?QUJwcWlWeE5YOXV0S2FVOTV5Qk9nTVFQU1F2a05URVEzZjJKZktJeXN4N3RM?= =?utf-8?B?ZldONEVCeWJwZGkvQ2hSZC9tSk1zWjZIbis0UDBTT0FDa01DN08vQTlNL01S?= =?utf-8?B?UExoemFDRW53a2U2Y3NUTkNFV0JES2g2RXBXNjNXeERzYnpkWFduQlBocVlF?= =?utf-8?B?WFFTUUdWajk5WEdvZXFCdC93czJRTVFOb2xxSGpQYS91eGc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3540;6:eB9M1/2K5w8rqoLou0aeBHoCWi5a3m6S48kyyCsZOaayJ5a1p/jmhvatNSRGACyeSbN3D9uaEkBWLGpxJMpGoJIucE6MBh7s7svFOBORJwZqJQ2/ACKQTpyO/7e6IXNAGZSZZooT7S+IW4LhXEP9rTjenX/r0pambvgzWTcx7CbaLyi5ZqNynmjMDWbTveXiQMP+t9RVJZ/Q2cV8MkV3wQEUnPrhatuk0z64zbANds8wDNHE/Qtgi9loXdWTTjfyPmrY+2IUqmHIZQo5Cpe3h8RYl3NYGfZoQ2d0JMeUvKjECuSc2eLQ6lLIpEhxuAKooT8tn0E/taYK4D/qb4sCYmGyGq25cB/rOQjleCNlpX8=;5:ZlElsS+ZFk9RCE71xmHGKpjqUKPwLgxE7WMrlcCg3EXJfxYVukK23FMxUctkPKK/PaZeZRlTE1796kzFCl0tEWjkYaKBfgAzsnhwssn31Adg3Bj3B8xiUQRuc9okiO3YHo4l+PAy7yJKj2xgLt63QiL11xrEcf4PEShSSraNaIc=;24:9UOUoqzfN/ikJX+QzepwAuQfaOHpJ18+tyzCUPUKOTLMeTVB1761IMKfAOgk2i7GixJcff2R1FGZLYLpavYg3UXo1MrpSoZ3wJocQdPpCQY=;7:23nhOWPOSjbbHX7iu8DXtb7NuqM9hpRDm/kKjIzeJO90RTgnSJFDBw26Repwzr/0NLTO6xJcJ8Ixy8zLbLXNg6Z3pm8V+B7FB9C5/LmGgHgRugC7l7QZa4YChykJtLO7vpJXm+6PgezhAjP5BFtOTJMP7Fti+of09zxPnhPa5Os1kcWNntS54K5dnrqhGPr134ttUp7oeA0q1p9T1Zop4ILnLi0qTGd+TI5infWXuT8MA+OAfPFs0lMl6UtrL2UD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2017 22:09:08.2620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c058aae6-1dee-43b9-b362-08d52c757e8e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3540 X-SW-Source: 2017-11/txt/msg00552.txt.bz2 On Fri, 2017-11-10 at 16:11 -0700, Martin Sebor wrote: >  > Okay, thanks.  I've read that you run periodic Glibc builds with > the latest GCC so I wanted to give you a heads up on this change > and the patch to avoid breaking them.  Unless that's not a concern > (do you use -Werror in those builds?) what is the best way to > coordinate this update? > > I CC Paul for his input in case updating tzcode first is important. > > Martin Martin, were you going to update this patch with Joseph's comments and resubmit?  The tz changes are checked in and the ifreq struct is taken care of so all that remains are the changes to cdefs.h to define __NONSTRING and then to use in utmp.h.  I don't have any comments on that change beyond what Joseph made but I did do a build and run on aarch64 with the latest GCC to verify that those changes work for me. Steve Ellcey sellcey@cavium.com