From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97564 invoked by alias); 11 Apr 2018 22:12:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 97549 invoked by uid 89); 11 Apr 2018 22:12:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*r:4.87, H*F:U*pb, Hx-languages-length:827, HContent-Transfer-Encoding:8bit X-HELO: mail.pbcl.net Message-ID: <1523484770.1959.2.camel@pbcl.net> Subject: Re: [PATCH 4/4] arm: Enable ARM mode for armv6 strlen From: Phil Blundell To: Adhemerval Zanella , libc-alpha@sourceware.org Date: Wed, 11 Apr 2018 22:12:00 -0000 In-Reply-To: <1523481378-16290-4-git-send-email-adhemerval.zanella@linaro.org> References: <1523481378-16290-1-git-send-email-adhemerval.zanella@linaro.org> <1523481378-16290-4-git-send-email-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-04/txt/msg00202.txt.bz2 On Wed, 2018-04-11 at 18:16 -0300, Adhemerval Zanella wrote: > Current optimized armv6t2 strlen uses the NO_THUMB wrongly to > conditionalize thumb instruction usage.  The flags is meant to be > defined before sysdep.h inclusion and to indicate the assembly > requires to build in ARM mode, not to check whether thumb is > enable or not.  This patch fixes it by using the GCC provided > '__thumb__' instead. Is it ever useful to build for ARM-state when on armv6t2 (i.e. Thumb2 is guaranteed to be available)? It's not totally obvious from reading the source that the ARM version is going to be better in any way than the Thumb one. Assuming that this is indeed something worth supporting, I think the short log for the patch ought to say "armv6t2" not "armv6". p.