From: Phil Blundell <pb@pbcl.net>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] arm: Remove ununsed ARM code in optimized implementation
Date: Mon, 16 Apr 2018 14:55:00 -0000 [thread overview]
Message-ID: <1523890523.18801.178.camel@pbcl.net> (raw)
In-Reply-To: <1523877749-8457-1-git-send-email-adhemerval.zanella@linaro.org>
On Mon, 2018-04-16 at 08:22 -0300, Adhemerval Zanella wrote:
> This patch removes the ununsed ARM code path for armv6t2 memchr and
> strlen and armv7 memch and strcmp. In all implementations, the ARM
> code is not used in any possible build (unless glibc is explicit
> build with the non-documented NO_THUMB define) and for armv7
> the resulting code either produces wrong results (memchr) and throw
> build error (strcmp).
Thanks, looks good to me.
> Checked on arm-linux-gnueabihf built targeting both armv6 and
> armv7.
Can you confirm there were no changes in the generated binaries?
p.
next prev parent reply other threads:[~2018-04-16 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 11:22 Adhemerval Zanella
2018-04-16 14:55 ` Phil Blundell [this message]
2018-04-16 18:07 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523890523.18801.178.camel@pbcl.net \
--to=pb@pbcl.net \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).