From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32798 invoked by alias); 16 Apr 2018 14:55:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 32781 invoked by uid 89); 16 Apr 2018 14:55:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*r:4.87 X-HELO: mail.pbcl.net Message-ID: <1523890523.18801.178.camel@pbcl.net> Subject: Re: [PATCH] arm: Remove ununsed ARM code in optimized implementation From: Phil Blundell To: Adhemerval Zanella , libc-alpha@sourceware.org Date: Mon, 16 Apr 2018 14:55:00 -0000 In-Reply-To: <1523877749-8457-1-git-send-email-adhemerval.zanella@linaro.org> References: <1523877749-8457-1-git-send-email-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00266.txt.bz2 On Mon, 2018-04-16 at 08:22 -0300, Adhemerval Zanella wrote: > This patch removes the ununsed ARM code path for armv6t2 memchr and > strlen and armv7 memch and strcmp. In all implementations, the ARM > code is not used in any possible build (unless glibc is explicit > build with the non-documented NO_THUMB define) and for armv7 > the resulting code either produces wrong results (memchr) and throw > build error (strcmp). Thanks, looks good to me. > Checked on arm-linux-gnueabihf built targeting both armv6 and > armv7. Can you confirm there were no changes in the generated binaries? p.