public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: "Albert ARIBAUD (3ADEV)" <albert.aribaud@3adev.fr>,
	 libc-alpha@sourceware.org
Subject: Re: [PATCH v2 1/2] Y2038: Add 64-bit time for all architectures
Date: Mon, 30 Jul 2018 05:41:00 -0000	[thread overview]
Message-ID: <1532929264.21552.68.camel@codethink.co.uk> (raw)
In-Reply-To: <1532929095.21552.67.camel@codethink.co.uk>

On Mon, 2018-07-30 at 13:38 +0800, Ben Hutchings wrote:
> On Thu, 2018-06-14 at 15:51 +0200, Albert ARIBAUD (3ADEV) wrote:
> > * Add macro __TIMESIZE equal to the bit size of time_t.
> >   It equals the architecture __WORDSIZE except for x32
> >   where it equals 64.
> > 
> > * Add type __time64_t which is always 64-bit. On 64-bit
> >   architectures and on x32, it is #defined as time_t.
> >   On other architectures, it has its own type.
> 
> [...]
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/x86/bits/timesizes.h
> 
> [...]
> > +/* Both x86-64 and x32 use 64-bit time.  */
> > +#define __TIME64_T_TYPE		__TIME_T_TYPE
> 
> [...]
> 
> But won't this file be used for regular 32-bit x86 (i386/i686) as well?

Never mind, I see this got fixed in v5.

Ben.

-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom

  reply	other threads:[~2018-07-30  5:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 13:51 [PATCH v2 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD (3ADEV)
2018-06-14 13:51 ` [PATCH v2 1/2] Y2038: Add 64-bit time for all architectures Albert ARIBAUD (3ADEV)
2018-06-14 13:57   ` Joseph Myers
2018-06-14 18:51     ` Albert ARIBAUD
2018-06-14 16:56   ` Paul Eggert
2018-06-14 17:52     ` Albert ARIBAUD
2018-07-30  5:38   ` Ben Hutchings
2018-07-30  5:41     ` Ben Hutchings [this message]
2018-06-14 13:51 ` [PATCH v2 2/2] Y2038: make __tz_convert compatible with 64-bit-time Albert ARIBAUD (3ADEV)
2018-06-14 17:07   ` Paul Eggert
2018-06-14 17:52     ` Albert ARIBAUD
2018-06-14 18:52       ` Paul Eggert
2018-06-14 19:40         ` Joseph Myers
2018-06-16 14:03           ` Albert ARIBAUD
2018-06-16 14:23             ` Paul Eggert
2018-06-16 18:21               ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532929264.21552.68.camel@codethink.co.uk \
    --to=ben.hutchings@codethink.co.uk \
    --cc=albert.aribaud@3adev.fr \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).