From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 6A41B3858D33 for ; Mon, 29 Apr 2024 07:13:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A41B3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6A41B3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714374820; cv=none; b=Uc61Hl+Um0au3t44XzLJeGbfyUT1wGXNIuWwyIblYyGCDRv0jEmhJTQLb1dmR7pHF8AcwJ1ROUxIJ5v/20toDpE5MP8eEcEZ3Cc5EEO9uCzKmNasKaZg8hzhMT/Q/Ih15kpgDTTJoVPHrsEbcSOzB2coUhO9QK8a0j5KrsatnR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714374820; c=relaxed/simple; bh=Y0slMclOmNeVF7YNkLsZh4R6X++o8CKC9aimfo8d3rQ=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=XAuBklCSWbJdN9BtQOMfZM//sddSOTQRg46gWGWROMRxtfgtK+gpHul8+fD7LAkxCy9o+jqecKbR6P6rXSdGBaIksL9vlVMDxr3s32IY6Sx4qxsrKMcJhxRwB7X1Ot+zkp0EPRXra2g+wUx4ENg3MzSw2ebmk4ncf9cGEZ/HRrU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1714374818; bh=Y0slMclOmNeVF7YNkLsZh4R6X++o8CKC9aimfo8d3rQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ZvzASMqV13oej+HsqbGlu6T73t0mZ/Fe2skgF/LrL4JWjNjcpDLIpWXmn40MKqQVB ScGAbYCq82WTFBg0YgFXtwP5f+dNyfFcoTQ+MPC6G9qMt2RM9CAs5f+uy20G7zZdUG 4ei1pPKjwwIkL0aKXbhL4jt2ZDjNx1X2Kp0r5+as= Received: from [IPv6:240e:358:111a:3c00:dc73:854d:832e:7] (unknown [IPv6:240e:358:111a:3c00:dc73:854d:832e:7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id B0DF86715E; Mon, 29 Apr 2024 03:13:32 -0400 (EDT) Message-ID: <1549fe4e119f24921ac14fcca2e805e8a87d1df9.camel@xry111.site> Subject: Re: [PATCH v5] LoongArch: Add support for TLS Descriptors From: Xi Ruoyao To: mengqinggang , libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, xuchenghua@loongson.cn, caiyinyu@loongson.cn, chenglulu@loongson.cn, cailulu@loongson.cn, i.swmail@xen0n.name, maskray@google.com, luweining@loongson.cn, wanglei@loongson.cn, hejinyang@loongson.cn Date: Mon, 29 Apr 2024 15:13:26 +0800 In-Reply-To: <20240426070132.2764244-1-mengqinggang@loongson.cn> References: <20240426070132.2764244-1-mengqinggang@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2024-04-26 at 15:01 +0800, mengqinggang wrote: > +_dl_tlsdesc_dynamic: > + /* Save just enough registers to support fast path, if we fall > + into slow path we will save additional registers. */ > + ADDI sp, sp,-24 > + REG_S t0, sp, 0 > + REG_S t1, sp, 8 > + REG_S t2, sp, 16 So t3 is not saved in the fast path. And then... > +.Lslow: > + /* This is the slow path. We need to call __tls_get_addr() which > + =C2=A0=C2=A0 means we need to save and restore all the register that th= e > + =C2=A0=C2=A0 callee will trash.=C2=A0 */ > + > + /* Save the remaining registers that we must treat as caller save.=C2= =A0 */ > + ADDI sp, sp, -FRAME_SIZE > + REG_S ra, sp, 0 * SZREG > + REG_S a1, sp, 1 * SZREG > + REG_S a2, sp, 2 * SZREG > + REG_S a3, sp, 3 * SZREG > + REG_S a4, sp, 4 * SZREG > + REG_S a5, sp, 5 * SZREG > + REG_S a6, sp, 6 * SZREG > + REG_S a7, sp, 7 * SZREG Missing t3 here. This causes tst-gnu2-tls2 segfault. > + REG_S t4, sp, 8 * SZREG > + REG_S t5, sp, 9 * SZREG > + REG_S t6, sp, 10 * SZREG > + REG_S t7, sp, 11 * SZREG > + REG_S t8, sp, 12 * SZREG --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University