From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by sourceware.org (Postfix) with ESMTPS id 982B43858405 for ; Mon, 20 Dec 2021 12:23:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 982B43858405 Received: by mail-qt1-x82a.google.com with SMTP id f20so9509984qtb.4 for ; Mon, 20 Dec 2021 04:23:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4jO5+cs7wdVHdeFN4LYQwviplXidvOqkkFpzPl/zlEE=; b=RhuE9dgAkrSteIAk0E0W5ZnmzoDOYNStnt8Bfxx8T+KkzmKnzJHf/c4sT6i3cdGUtX 3xeQ/PXC6k3exo8HC5fxzr2ckgeYFSpRrlRgihj4Ks3oLjPL3+0CRfXW/WGXxHqnCJdj k/AgrRsKdju6DwS9G4eTkSRsCNcto6sju5X4M6d6CqZjmvBaNLauDAhgvhHwrex5S4zD FuwJlI2wPWvF4qLQLiLOjVYjyUwCKCgMU6FeNPUWtPYHsTapWvZrtuK9Xt85JO/L4DZr Ti8ICIg6DMzRYp2SNE/MFcihDW0/pIXz0dFIXzmo6UPIqIHOelUaaM7Njc7Qq6dbWBUc 5e6Q== X-Gm-Message-State: AOAM531TvM9MGl0CpbMPrcXY5JHbOUrEbMH/abdnbHuG+enSWrEUmFUv alOzrZe4QK/s2o+eGA3CfwU4oQ== X-Google-Smtp-Source: ABdhPJy/SH5MH5Ce6cpVlTwWauUmJbhnVuuWgLIEnkmV8f4X31SFy6+y/M/Io1NZ/28nyILPfSHWcw== X-Received: by 2002:a05:622a:28d:: with SMTP id z13mr12125511qtw.467.1640002986155; Mon, 20 Dec 2021 04:23:06 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:3b1e:762b:24f5:94b:4e15? ([2804:431:c7cb:3b1e:762b:24f5:94b:4e15]) by smtp.gmail.com with ESMTPSA id z10sm14841812qtw.71.2021.12.20.04.23.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Dec 2021 04:23:05 -0800 (PST) Message-ID: <1582d522-08ea-79d7-9128-2a64974dd200@linaro.org> Date: Mon, 20 Dec 2021 09:23:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v6 11/20] elf: Add audit tests for modules with TLSDESC Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-12-adhemerval.zanella@linaro.org> <87h7b5hhii.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87h7b5hhii.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 12:23:08 -0000 On 18/12/2021 15:53, Florian Weimer wrote: > * Adhemerval Zanella: > >> Checked on x86_64-linux-gnu, i686-linux-gnu, and aarch64-linux-gnu. > > The test module naming is a bit confusing. tst-auditmod-tlsdesc1.so and > tst-auditmod-tlsdesc2.so are not actually audit modules, but > tst-audit-tlsdesc-audit.so is. I have changed tst-auditmod-tlsdesc1 to tst-audit-tlsdesc-mod1, tst-auditmod-tlsdesc2 to tst-audit-tlsdesc-mod2, and tst-audit-tlsdesc-audit to tst-auditmod-tlsdesc. It should in par with the rest to audit names scheme. > > Otherwise the tests look okay. Not sure why I expected something with > *audit modules* that use TLSDESC. > > Thanks, > Florian >