From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Paul Eggert <eggert@cs.ucla.edu>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v2 00/18] posix: glob fixes and refactor
Date: Thu, 17 Aug 2017 18:07:00 -0000 [thread overview]
Message-ID: <15b5914d-f6bb-58c6-3a81-5d39cd975d7b@redhat.com> (raw)
In-Reply-To: <cbd73cac-752f-1181-0f43-000ad0c4085c@linaro.org>
On 08/17/2017 07:32 PM, Adhemerval Zanella wrote:
>
>
> On 17/08/2017 11:10, Paul Eggert wrote:
>> Adhemerval Zanella wrote:
>>
>>> I agree
>>> that decoupling should be a better strategy. I can update the 01/18 with
>>> a general cleanup or adding another upcoming patch with this change, which
>>> do you think it is better?
>>
>> I'd like to keep the code in sync as much as possible. Perhaps the best way to do this would be for you to present the "decoupled" version, then I can attempt to merge the Gnulib-needed changes into it, in such a way that they don't disrupt the mainline code.
>
> My understanding from Florian comment is the 'decoupled' version would be the
> code with both win32/amiga/etc code striped and LIBC defines set to only glibc.
Right. This would also remove the d_ino/d_type abstraction macros.
Thanks,
Florian
next prev parent reply other threads:[~2017-08-17 18:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 14:50 Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 16/18] posix: More check for overflow allocation in glob Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 03/18] posix: Consolidate glob implementation Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 01/18] posix: Sync glob with gnulib [BZ #1062] Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 13/18] posix: Remove all alloca usage in glob Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 12/18] posix: Use dynarray for globname " Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 08/18] malloc: Add specialized dynarray for C strings Adhemerval Zanella
2017-08-17 10:12 ` Florian Weimer
2017-08-17 12:39 ` Adhemerval Zanella
2017-08-17 14:48 ` Pedro Alves
2017-08-11 14:51 ` [PATCH 04/18] posix: Allow glob to match dangling symlinks [BZ #866] Adhemerval Zanella
2017-08-31 22:11 ` Paul Eggert
2017-08-11 14:51 ` [PATCH 05/18] posix: Rewrite to use struct scratch_buffer instead of extend_alloca Adhemerval Zanella
2017-09-01 23:50 ` Paul Eggert
2017-09-02 10:40 ` Paul Eggert
2017-08-11 14:51 ` [PATCH 11/18] posix: Remove alloca usage on glob dirname Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 18/18] posix: Fix glob with GLOB_NOCHECK returning modified patterns (BZ#10246) Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 09/18] posix: Use char_array for internal glob dirname Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 17/18] posix: Use enum for __glob_pattern_type result Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 06/18] posix: Remove glob GET_LOGIN_NAME_MAX usage Adhemerval Zanella
2017-09-02 22:50 ` Paul Eggert
2017-08-11 14:51 ` [PATCH 10/18] posix: Remove alloca usage for GLOB_BRACE on glob Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 02/18] posix: Adjust glob tests to libsupport Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 15/18] posix: Add common function to get home directory Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 14/18] posix: Use char_array for home_dir in glob Adhemerval Zanella
2017-08-11 14:51 ` [PATCH 07/18] posix: User LOGIN_NAME_MAX for all user names " Adhemerval Zanella
2017-08-17 10:19 ` [PATCH v2 00/18] posix: glob fixes and refactor Florian Weimer
2017-08-17 12:07 ` Adhemerval Zanella
2017-08-17 14:11 ` Paul Eggert
2017-08-17 17:32 ` Adhemerval Zanella
2017-08-17 18:07 ` Florian Weimer [this message]
2017-08-17 19:51 ` Paul Eggert
2017-08-17 20:05 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15b5914d-f6bb-58c6-3a81-5d39cd975d7b@redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).