From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id D90DC384CB97 for ; Tue, 21 May 2024 16:41:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D90DC384CB97 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D90DC384CB97 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716309687; cv=none; b=oecgjx6I9qeuB4Qh03LuNwYt+E6XlEWd9Mkpq0RlHREazKWYoo4JRRFPDAnq50ClAkl5fxgbVwdKfR1FKEozChoWMHBXrTgDPbwt8u9aBC8NL9EjJmOp5Q7epDVyWhmAhUiJ/mhOXqQrL6EE3P8qdIJkoOqQz+DnqkDk5RIu+P0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716309687; c=relaxed/simple; bh=EG+K8VdAw9buVMPkzTl95Ep0Sr4DRjiRGMp2vAxuyRA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=FmCEgDgjN/U0QZcxUU726wXZBlO96ahBmBp2zPgtJP6nv45ka+QjWxeu/OEpOwx4as8mn9PIboKbbIu7bXsA36ifa4MnoQmgg5rXywrP2VN0G8ww9IiFCKAhegrmbrs2vckP9+wKRL+XJo2aNeOnwT1NG4WmkVhx6kq11ww53ow= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1eca195a7c8so104307005ad.2 for ; Tue, 21 May 2024 09:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716309683; x=1716914483; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=sEuNmlZVmUT0HCgKu+No3aVzyDFU7EYstrp7kkkoGKg=; b=N79HxH2C/gwHdCQ5z+0OtbMe1Hx6oEWJcp/oKdQZd/0ljKXafK2P58jxI6Erx839GF GN1iW8cMO1Vuqj3dpCx5UN5k3ZsW6YWExQwZPHUtZk6S4VWKBH4qLt6sk3ONBB/P3+dK Uc8P0rv1sxKhHO30pBEUxzreKwDwOhpufvodjnDpSaGnQD9OXqffaf4cFz46v1cvqgD0 tF5gOyNX8pwYX/Gt4KRV1IMOFO/315AcXMZokNLVrzAl4RIkvOpCMFHChezqtX2hq41u Vtt1AO9EC3KpPbGieOBF9EGF+KdRdiEz4UJqdPtqd91p01Sv7j6MQVoTpxOXxjzcfPtA Vyxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716309683; x=1716914483; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sEuNmlZVmUT0HCgKu+No3aVzyDFU7EYstrp7kkkoGKg=; b=W0gVoa9LkXmZQ18b4G+tGp8uLkLgTRQzANUlRsPbVzo+JoCzsCcw4tndrKWwn9Q6OL YEaHBjuygg0iT4qM8hafA+vq5M9LXc4zIWDvwchxRe6uaLNyiT5JpvuOAyhbiNseoHiw gnVklNWcEG4HEySkQMIn4hSXBaH5T3NXPp6k6kFHQi+UA4NQ9r01dWYMNNVS0bM4ALlE TtaJsZu1KbBs/Rzu+8qb+qN0u6p5kAIbxu0cw0xYlffNWSfcDLgOxwPCuvvihuV3hBoJ AuEvbic7Csi86sIv3BUxD3Yn5AxMfI29eVVxB8RLGi/lzY8+3KF2IEoIqjnjL/JQQ3Ug Ov2w== X-Gm-Message-State: AOJu0Yxx49Bjc96mtK8d6SYQ6bvf3ENvMwnvtjgdQte9lAL1pQHrjjUF KPicmazxX7euYdkyhruBccuyDUPcMvJDRAKb7nL/rwuwQRwoDuHWraLh47zEYWw= X-Google-Smtp-Source: AGHT+IFqX/CLDEhMjUPBF0W1+qBHhH7lBNdYxT1q6I1ZY4wu/n+rS6SkkWgWBKi5rvCXxr4LFDkTTQ== X-Received: by 2002:a17:903:2404:b0:1e2:c8f9:4cd7 with SMTP id d9443c01a7336-1ef44059612mr258872085ad.64.1716309682738; Tue, 21 May 2024 09:41:22 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf? ([2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f30fe572f2sm14348715ad.131.2024.05.21.09.41.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 09:41:22 -0700 (PDT) Message-ID: <15bdbb7d-aa1c-4159-9c47-20c797047281@linaro.org> Date: Tue, 21 May 2024 13:41:18 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/7] math: Provide modf128 for static libm on alpha, s390, and sparcv9 To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-8-adhemerval.zanella@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/05/24 12:40, H.J. Lu wrote: > On Mon, May 20, 2024 at 12:07 PM Adhemerval Zanella Netto > wrote: >> >> >> >> On 20/05/24 13:59, H.J. Lu wrote: >>> On Tue, Apr 2, 2024 at 7:07 AM Adhemerval Zanella >>> wrote: >>>> >>>> Checked with a build for the affected ABIs >>>> --- >>>> sysdeps/ieee754/ldbl-64-128/s_modfl.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/sysdeps/ieee754/ldbl-64-128/s_modfl.c b/sysdeps/ieee754/ldbl-64-128/s_modfl.c >>>> index 7d7aeae111..ba3d31334a 100644 >>>> --- a/sysdeps/ieee754/ldbl-64-128/s_modfl.c >>>> +++ b/sysdeps/ieee754/ldbl-64-128/s_modfl.c >>>> @@ -1,10 +1,10 @@ >>>> #include >>>> #include >>>> -#if IS_IN (libc) >>>> +#if IS_IN (libc) && defined SHARED >>>> # undef libm_alias_ldouble >>>> # define libm_alias_ldouble(from, to) >>>> #endif >>>> #include >>>> -#if IS_IN (libc) >>>> +#if IS_IN (libc) && defined SHARED >>>> long_double_symbol (libc, __modfl, modfl); >>> >>> Doesn't this remove modfl from static library? >> >> As for copysignf128 and frexp128, this symbol is also provided by libc.a. >> Before this patch: >> >> alpha-linux-gnu$ readelf -sW libc.a | grep -w modf.* >> 19: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 modfl >> 17: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff32x >> 18: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff64 >> 19: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modf >> 17: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff32 >> 18: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff >> >> After this patch: >> >> alpha-linux-gnu$ readelf -sW libc.a | grep -w modf.* >> 19: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff64x >> 20: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff128 >> 21: 0000000000000000 572 FUNC WEAK DEFAULT [STD GPLOAD] 1 modfl >> 17: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff32x >> 18: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff64 >> 19: 0000000000000000 304 FUNC WEAK DEFAULT [STD GPLOAD] 1 modf >> 17: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff32 >> 18: 0000000000000000 244 FUNC WEAK DEFAULT [STD GPLOAD] 1 modff >> >> > > I am working on a patch to check missing symbols in static libraries. > I opened: > > https://sourceware.org/bugzilla/show_bug.cgi?id=31781 > > scalbnf128 seems also missing in alpha libm.a. > It seems so, the static tests I have added only cover for the auto-generated function from the libm-test-funcs-auto, libm-test-funcs-noauto, and libm-test-funcs-narrow; and the are some function that are not covered by these (scalbn for instance).