public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com>
To: Matheus Castanho <msc@linux.ibm.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v2 0/2] powerpc: Add support for system call vectored
Date: Tue, 08 Dec 2020 15:24:29 -0300	[thread overview]
Message-ID: <160745186973.2173056.16101593781770208473@localhost.localdomain> (raw)
In-Reply-To: <20201203171528.83180-1-msc@linux.ibm.com>

Hi Matheus,
Worked on top of Adhemerval's brk patch. But it fails if applied
directly on master.

Tested on a POWER9 with and without scv support.

Tested-by: Lucas A. M. Magalhães <lamm@linux.ibm.com>

Quoting Matheus Castanho via Libc-alpha (2020-12-03 14:15:26)
> This patchset enables the usage of system call vectored (scv) instruction by
> system calls for improved performance on POWER9 and later processors.
> 
> This new version dropped the patch to move brk to a C-based implementation, in
> favor of Adhemerval's patch [0]. So it should be applied on top of that.
> 
> Also, it modified the scv check mechanism to remove the thread pointer check as
> suggested by Florian. Now the dynamic loader always uses sc, static code still
> checks the thread pointer before accessing the TCB, and shared code (outside the
> dl) accesses the TCB directly.
> 
> Please check each patch for more details, specially 1/2 which explains the
> rationale and details of the runtime mechanism to choose between the old
> behavior (sc) and the new one (scv 0).
> 
> Tested on powerpc, powerpc64, and powerpc64le (with and without scv)
> 
> [0] https://sourceware.org/pipermail/libc-alpha/2020-November/119770.html
> 
> ---
> 
> v2:
>   - Fix typos and comments to match GNU style
>   - Remove the check for the thread pointer on shared code, and always use sc
>     when inside the dynamic loader
>   - Drop the patch implementing brk in C
> 
> Matheus Castanho (2):
>   powerpc: Runtime selection between sc and scv for syscalls
>   powerpc: Use scv instruction on clone when available
> 
>  sysdeps/powerpc/powerpc32/sysdep.h            |  15 ++-
>  sysdeps/powerpc/powerpc64/sysdep.h            | 120 +++++++++++++++++-
>  .../unix/sysv/linux/powerpc/powerpc64/clone.S |  36 +++++-
>  .../unix/sysv/linux/powerpc/powerpc64/vfork.S |   6 +-
>  sysdeps/unix/sysv/linux/powerpc/syscall.S     |  11 +-
>  sysdeps/unix/sysv/linux/powerpc/sysdep.h      |  93 ++++++++++----
>  6 files changed, 241 insertions(+), 40 deletions(-)
> 
> --
> 2.26.2

      parent reply	other threads:[~2020-12-08 18:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 17:15 Matheus Castanho
2020-12-03 17:15 ` [PATCH v2 1/2] powerpc: Runtime selection between sc and scv for syscalls Matheus Castanho
2020-12-10 17:28   ` Matheus Castanho
2020-12-10 18:07     ` Adhemerval Zanella
2020-12-30 21:29   ` Tulio Magno Quites Machado Filho
2020-12-03 17:15 ` [PATCH v2 2/2] powerpc: Use scv instruction on clone when available Matheus Castanho
2020-12-30 21:30   ` Tulio Magno Quites Machado Filho
2020-12-08 18:24 ` Lucas A. M. Magalhaes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160745186973.2173056.16101593781770208473@localhost.localdomain \
    --to=lamm@linux.ibm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=msc@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).