From: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com>
To: Andreas Schwab <schwab@linux-m68k.org>,
"Lucas A. M. Magalhaes via Libc-alpha"
<libc-alpha@sourceware.org>
Cc: tuliom@linux.ibm.com
Subject: Re: [PATCH v2] powerpc: Optimized memmove for POWER10
Date: Thu, 06 May 2021 13:35:13 -0300 [thread overview]
Message-ID: <162031891343.57806.15638758002668073354@localhost.localdomain> (raw)
In-Reply-To: <87eeej7vly.fsf@igel.home>
Quoting Andreas Schwab (2021-05-06 12:03:21)
> On Apr 29 2021, Lucas A. M. Magalhaes via Libc-alpha wrote:
>
> > diff --git a/sysdeps/powerpc/powerpc64/multiarch/bcopy.c b/sysdeps/powerpc/powerpc64/multiarch/bcopy.c
> > index 04f3432f2b..2840b17fdf 100644
> > --- a/sysdeps/powerpc/powerpc64/multiarch/bcopy.c
> > +++ b/sysdeps/powerpc/powerpc64/multiarch/bcopy.c
> > @@ -22,8 +22,17 @@
> > extern __typeof (bcopy) __bcopy_ppc attribute_hidden;
> > /* __bcopy_power7 symbol is implemented at memmove-power7.S */
> > extern __typeof (bcopy) __bcopy_power7 attribute_hidden;
> > +#ifdef __LITTLE_ENDIAN__
> > +extern __typeof (bcopy) __bcopy_power10 attribute_hidden;
> > +#endif
> >
> > libc_ifunc (bcopy,
> > +#ifdef __LITTLE_ENDIAN__
> > + hwcap2 & (PPC_FEATURE2_ARCH_3_1 |
> > + PPC_FEATURE2_HAS_ISEL)
> > + && (hwcap & PPC_FEATURE_HAS_VSX)
> > + ? __bcopy_power10 :
>
> Why does ISEL+VSX identify POWER10?
>
PPC_FEATURE2_ARCH_3_1 identify POWER10. However the
(PPC_FEATURE2_ARCH_3_1 | PPC_FEATURE2_HAS_ISEL) logic was a mistake.
There is already a patch to fix that under review.
---
Lucas A. M. Magalhães
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
prev parent reply other threads:[~2021-05-06 16:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 20:42 Lucas A. M. Magalhaes
2021-04-29 21:13 ` Matheus Castanho
2021-04-29 21:24 ` Raphael M Zinsly
2021-04-30 12:56 ` Raoni Fassina Firmino
2021-04-30 21:18 ` Tulio Magno Quites Machado Filho
2021-05-06 14:50 ` Andreas Schwab
2021-05-06 14:57 ` Florian Weimer
2021-05-06 15:55 ` Lucas A. M. Magalhaes
2021-05-06 16:04 ` Andreas Schwab
2021-05-06 18:29 ` Tulio Magno Quites Machado Filho
2021-05-06 18:34 ` Andreas Schwab
2021-05-06 18:53 ` Tulio Magno Quites Machado Filho
2021-05-06 19:51 ` Andreas Schwab
2021-05-06 15:03 ` Andreas Schwab
2021-05-06 16:35 ` Lucas A. M. Magalhaes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162031891343.57806.15638758002668073354@localhost.localdomain \
--to=lamm@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).