From: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com>
To: "Carlos O'Donell" <carlos@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] testrun.sh: Improve --help message
Date: Tue, 11 May 2021 09:19:02 -0300 [thread overview]
Message-ID: <162073554296.316372.11926568900853580975@fedora.local> (raw)
In-Reply-To: <b603ec20-49fc-03ee-f0c0-5c2e4e669f8d@redhat.com>
Hi Carlos. Can you push this for me?
Quoting Carlos O'Donell (2021-05-10 10:39:57)
> On 5/3/21 5:22 PM, Lucas A. M. Magalhaes via Libc-alpha wrote:
> > The testrun.sh --help message was missing the "container" option.
> > Besides just adding the missing option I decide to rewrite it in the
> > same layout as other tools.
>
> LGTM.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>
> > ---
> > Makefile | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 50f99ca611..242d36de91 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -144,8 +144,13 @@ builddir=`dirname "$$0"`
> > GCONV_PATH="$${builddir}/iconvdata"
> >
> > usage () {
> > - echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1
> > - echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1
> > +cat << EOF
> > +Usage: $$0 [OPTIONS] <program> [ARGUMENTS...]
> > +
> > + --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or
> > + container. The container will run within support/test-container.
> > +EOF
> > +
> > exit 1
> > }
> >
> >
>
>
> --
> Cheers,
> Carlos.
>
next prev parent reply other threads:[~2021-05-11 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 21:22 Lucas A. M. Magalhaes
2021-05-10 13:39 ` Carlos O'Donell
2021-05-11 12:19 ` Lucas A. M. Magalhaes [this message]
2021-05-25 4:52 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162073554296.316372.11926568900853580975@fedora.local \
--to=lamm@linux.ibm.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).