From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 77F373886C68 for ; Tue, 11 May 2021 12:20:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 77F373886C68 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14BC32fF105297 for ; Tue, 11 May 2021 08:20:09 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 38fq6yn8j4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 11 May 2021 08:20:09 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 14BC3W6U111937 for ; Tue, 11 May 2021 08:20:09 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 38fq6yn8hk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 08:20:09 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 14BCC91t016658; Tue, 11 May 2021 12:19:08 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma04wdc.us.ibm.com with ESMTP id 38dj995mvx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 12:19:07 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 14BCJ7Ti17695218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 May 2021 12:19:07 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 196F578063; Tue, 11 May 2021 12:19:07 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 966FF78060; Tue, 11 May 2021 12:19:06 +0000 (GMT) Received: from localhost (unknown [9.85.179.12]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 11 May 2021 12:19:06 +0000 (GMT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20210503212206.1699908-1-lamm@linux.ibm.com> Subject: Re: [PATCH] testrun.sh: Improve --help message From: "Lucas A. M. Magalhaes" To: "Carlos O'Donell" , libc-alpha@sourceware.org Date: Tue, 11 May 2021 09:19:02 -0300 Message-ID: <162073554296.316372.11926568900853580975@fedora.local> User-Agent: alot/0.9.1 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 9oWnqEg-WT-kkCLbU5Wtn0Rq0FbN5CiD X-Proofpoint-ORIG-GUID: bGi4ue6ESB9FyvtmBQt7YcFJhrKOXVda X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-11_02:2021-05-11, 2021-05-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105110094 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 12:20:12 -0000 Hi Carlos. Can you push this for me? Quoting Carlos O'Donell (2021-05-10 10:39:57) > On 5/3/21 5:22 PM, Lucas A. M. Magalhaes via Libc-alpha wrote: > > The testrun.sh --help message was missing the "container" option. > > Besides just adding the missing option I decide to rewrite it in the > > same layout as other tools. >=20 > LGTM. >=20 > Reviewed-by: Carlos O'Donell >=20 > > --- > > Makefile | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > >=20 > > diff --git a/Makefile b/Makefile > > index 50f99ca611..242d36de91 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -144,8 +144,13 @@ builddir=3D`dirname "$$0"` > > GCONV_PATH=3D"$${builddir}/iconvdata" > > =20 > > usage () { > > - echo "usage: $$0 [--tool=3Dstrace] PROGRAM [ARGUMENTS...]" 2>&1 > > - echo " $$0 --tool=3Dvalgrind PROGRAM [ARGUMENTS...]" 2>&1 > > +cat << EOF > > +Usage: $$0 [OPTIONS] [ARGUMENTS...] > > + > > + --tool=3DTOOL Run with the specified TOOL. It can be strace, valgri= nd or > > + container. The container will run within support/test-c= ontainer. > > +EOF > > + > > exit 1 > > } > > =20 > >=20 >=20 >=20 > --=20 > Cheers, > Carlos. >