From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by sourceware.org (Postfix) with ESMTPS id 32F2C386F824 for ; Fri, 2 Oct 2020 13:51:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 32F2C386F824 Received: by mail-qt1-x841.google.com with SMTP id n10so1238202qtv.3 for ; Fri, 02 Oct 2020 06:51:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=d1wehkJtezT3IVvQBuwnfMhyzMfZ3V+XbNQj8MzHDww=; b=pqs65sUvLr53X99X7Cjo/eOLF7v11B2ya0GQwExrSi/9mL6gRsmtwb8EdNG2k04m/y ZM3Ffnlb99A4VZAaczu5ro62gDh7Gb+GPX+EmH+bnv8F2hDd/gwlSB+2wtn9LVhRPQGp CTxLDKULeS3QZS/3BxOPW9Yqc4AY5nEmwBlXIUDV6tO0+1F8wZdq0mywPlwNIEiJ6csJ RKNthYfhafMPlid0Ex9tEt43Oxcy6yJ0CLaxbeAHkVmLg/fJKZbCpNuBjqJCi4QQ12+8 urcwzTYcsKmf++y2qK7qsZCdifBMcrpKKFfuWlhtxUgd0+SVbp8YafJs2zZ+VdrDGZl5 wMUw== X-Gm-Message-State: AOAM532G03l5y5u0f4GPLg9o5lqWXatjQ/J+mnf+ZhllvuYMkL+6Ukok Opa3R+b5udiCdcgsTYDNxSULjQ== X-Google-Smtp-Source: ABdhPJzvjFUsm4uW8KxUh7oq88Vcwghh5AyS52MfUmZ6D3r/TczCSUqJygx5HHgcnVZLXvrH8ruhkw== X-Received: by 2002:aed:3b78:: with SMTP id q53mr2377277qte.195.1601646718624; Fri, 02 Oct 2020 06:51:58 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id r64sm1069362qkf.119.2020.10.02.06.51.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2020 06:51:57 -0700 (PDT) To: Lukasz Majewski Cc: Joseph Myers , Paul Eggert , Alistair Francis , Arnd Bergmann , Alistair Francis , GNU C Library , Florian Weimer , Carlos O'Donell , Stepan Golosunov , Andreas Schwab , Zack Weinberg , Jeff Law References: <20200919130759.31916-1-lukma@denx.de> <20200919130759.31916-3-lukma@denx.de> <55d2e158-d3df-2c3e-757c-5673d436d4a2@linaro.org> <20200930151201.19522e3b@jawa> <9e934743-7a8f-36ce-7a9d-45808e647b02@linaro.org> <20201002141508.23f06238@jawa> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH v2 3/3] y2038: nptl: Convert pthread_rwlock_{clock|timed}{rd|wr}lock to support 64 bit time Message-ID: <162999e3-97c4-4dda-bac3-51a25068b0c5@linaro.org> Date: Fri, 2 Oct 2020 10:51:51 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201002141508.23f06238@jawa> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 13:52:00 -0000 On 02/10/2020 09:15, Lukasz Majewski wrote: > Hi Adhemerval, > >> On 30/09/2020 10:12, Lukasz Majewski wrote: >>>>> diff --git a/nptl/pthread_rwlock_rdlock.c >>>>> b/nptl/pthread_rwlock_rdlock.c index 04cecad395..2b8509a49c 100644 >>>>> --- a/nptl/pthread_rwlock_rdlock.c >>>>> +++ b/nptl/pthread_rwlock_rdlock.c >>>>> @@ -24,7 +24,7 @@ __pthread_rwlock_rdlock (pthread_rwlock_t >>>>> *rwlock) { >>>>> LIBC_PROBE (rdlock_entry, 1, rwlock); >>>> >>>> We need to move the systemtap probe to the 64-bit variant, so the >>>> 64-bit time will still trigger it. >>> >>> Those are syscalls, which don't require timespec time. >> >> These are in fact systemtap markers [1] and they are not related to >> syscalls. > > Ok. Thanks for the info (and link). > >> >>> >>> The LIBC_PROBE() macros were there before, so I left them as is and >>> only changed __pthread_rwlock_rdlock_full() to >>> __pthread_rwlock_rdlock_full64(). >>> >>> >>> On the other hand - for example: >>> __pthread_rwlock_clockwrlock() and __pthread_rwlock_clockwrlock64() >>> are only calling __pthread_rwlock_wrlock_full64(), and there were no >>> LIBC_PROBE() macros before. >>> >>> Do I understand correctly that you propose to add LIBC_PROBE() >>> macros to e.g. __pthread_rwlock_clockwrlock64() ? >> >> The idea of the LIBC_PROBE is to trigger an systemtap even when the >> function is called so systemtap can act accordingly (and the markers >> are enable only if --enable-systemtap is used on configure). >> > > Ok. > >> Without moving the LIBC_PROBE, 64-bit time architectures won't see >> the probes anymore since they will call the 64-bit time version >> instead. > > Please correct me if I'm wrong, but it seems to me that you are > concerned if > > - __pthread_rwlock_rdlock_full64 > - __pthread_rwlock_wrlock_full64 > > would be called as aliased (for e.g. x86-64) and redirected (for e.g. > arm)? > > This is not the case as above functions are local (i.e. helpers) ones > defined in ./nptl/pthread_rwlock_common.c (and are not exported). > > For them, the only change was to add '64' suffix. > > The LIBC_PROBE() calls have been left untouched, surrounding them, so I > think that we don't need to move them. > > > Or maybe I do miss something important here? Thanks in advance for your > help and explanation. In fact this is a wrong assumption from my part, there is no LIBC_PROBE on the timed variant rwlocks. The patch looks ok in this regard (sorry for the noise).