From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88490 invoked by alias); 28 Nov 2017 15:53:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 88479 invoked by uid 89); 28 Nov 2017 15:53:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=vDSO, HContent-Transfer-Encoding:8bit X-HELO: mail-qk0-f196.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T1nnl+sbJGBYFoNn2uPO3G1HsRDH0pFUMxMUMQ8kQFc=; b=iBLg8+04SX6eK6ELC87c8bJar2aWcdxsZi2WCCQ23FQTb0VriYt4abGMFZlSXEv73s L6cEs24NDeOOHc52nPNxYNi03IhyFNBb/C0dD6jtbKn6+EpkIAWgI2raIF14h4UGa0fc 6UmRVpx/eqHwWJwxwo2s3PmQRv1a0YJp14Fjh+9+RqWntysM6fY8CuP729HvXESi7xUW qVw00UQOvrGkkeUrJRsKnjBtuJuEmjs/nEl4Tt1aKKBFrIhq5GoQkt9ZJXDeuHbsfhhG qYilQ9VaFzR/0d0ckFhW8EmsLMPndOseRUrFWVt8b0X2ZBMsQobVWLL2skK3uLfZ1OC0 b+Fg== X-Gm-Message-State: AJaThX6P0mkUTRPk5LP0/ZXvhxkfPEnf2To93itXMlmsni0gOEmEtSeS /dzh3sSsV1qvQoi6TtFQDAKlp2TH0VU= X-Google-Smtp-Source: AGs4zMbOf0QnB00M6J25E3dbCOQ7CWOsRi90lmpLp8Y2xF5AR2N4fka0KE77awChLYZPX/e2fVyAoA== X-Received: by 10.55.204.131 with SMTP id n3mr63272220qkl.234.1511884418589; Tue, 28 Nov 2017 07:53:38 -0800 (PST) Subject: Re: [PATCH] S390: Fix backtrace in vdso functions. To: Florian Weimer , libc-alpha@sourceware.org References: <6698d098-aea3-14cc-8ed7-762def848dc9@linaro.org> <71c26ade-f3bd-fedd-d609-366c96174204@redhat.com> From: Adhemerval Zanella Message-ID: <163688cc-95d7-e7f1-6d52-67dd3d20b82a@linaro.org> Date: Tue, 28 Nov 2017 15:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <71c26ade-f3bd-fedd-d609-366c96174204@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-11/txt/msg00974.txt.bz2 On 28/11/2017 12:18, Florian Weimer wrote: > On 11/28/2017 02:09 PM, Adhemerval Zanella wrote: >> I am almost sure we can remove it for powerpc as well (I can't see >> no immediate gain on doing a function call using inline assembly >> as for INTERNAL_VSYSCALL_NO_SYSCALL_FALLBACK on powerpc). > > Is there another way to obtain the condition code for the error status? > >   /* The vDSO does not return an error (it clear cr0.so on returning).  */ >   INTERNAL_SYSCALL_DECL (err); >   result = >     INTERNAL_VSYSCALL_NO_SYSCALL_FALLBACK (get_tbfreq, err, uint64_t, 0); > > Thanks, > Florian I think we can simplify this call in specific since __kernel_get_tbfreq always succeed if the vDSO is present. The only issue is the symbol returns an uint64_t even for powerpc32.