From: Richard Henderson <richard.henderson@linaro.org>
To: Xi Ruoyao <xry111@xry111.site>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
"dengjianbo@loongson.cn" <dengjianbo@loongson.cn>
Cc: xuchenghua <xuchenghua@loongson.cn>,
"i.swmail" <i.swmail@xen0n.name>,
libc-alpha <libc-alpha@sourceware.org>,
joseph <joseph@codesourcery.com>, caiyinyu <caiyinyu@loongson.cn>
Subject: Re: [PATCH 0/2] LoongArch: Add optimized functions.
Date: Wed, 28 Sep 2022 07:22:33 -0700 [thread overview]
Message-ID: <1679af30-ee17-3016-1bd3-192f744ad8ef@linaro.org> (raw)
In-Reply-To: <8411c465e01de9608633f8b1fd2d82d3ef16f001.camel@xry111.site>
On 9/26/22 06:49, Xi Ruoyao via Libc-alpha wrote:
> Hi Adhemerval and Jianbo,
>
> I've customized string-fzi.h and string-maskoff.h for LoongArch (see
> attachment). With them on top of Adhermerval's v5 "Improve generic
> string routines" patch and GCC & Binutils trunk, the benchmark result
> seems comparable with the assembly version for strchr, strcmp, and
> strchrnul.
There is nothing in string-maskoff.h that the compiler should not be able to produce
itself from the generic version. Having a brief look, the compiler simply needs to be
improved to unify two current AND patterns (which is an existing bug) and add the
additional case for bstrins.d.
Similarly, there is nothing in string-fzi.h that should not be gotten from longlong.h;
your only changes are to use __builtin_clz, which longlong.h exports as count_trailing_zeros.
r~
next prev parent reply other threads:[~2022-09-28 14:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 8:57 caiyinyu
2022-08-15 8:57 ` [PATCH 1/2] LoongArch: Add optimized string functions: str{chr, chrnul, cmp, ncmp} caiyinyu
2022-08-15 8:57 ` [PATCH 2/2] LoongArch: Add optimized function: memmove caiyinyu
2022-08-15 14:02 ` [PATCH 0/2] LoongArch: Add optimized functions Carlos O'Donell
2022-08-15 20:46 ` Joseph Myers
[not found] ` <ccc3c93d-07d0-ea9b-562c-aeaec8914f20@loongson.cn>
2022-09-02 9:05 ` Fwd: " dengjianbo
2022-09-02 12:27 ` Adhemerval Zanella Netto
[not found] ` <403f78f0-55d9-48cf-c62a-4a0462a76987@loongson.cn>
2022-09-19 2:03 ` dengjianbo
2022-09-19 20:16 ` Adhemerval Zanella Netto
2022-09-20 9:54 ` Xi Ruoyao
2022-09-22 18:05 ` Adhemerval Zanella Netto
2022-09-26 13:49 ` Xi Ruoyao
2022-09-28 14:22 ` Richard Henderson [this message]
2022-09-28 16:42 ` Xi Ruoyao
2022-09-28 19:18 ` Richard Henderson
2022-10-10 1:39 ` Lulu Cheng
2022-09-29 3:00 ` Lulu Cheng
2022-09-29 11:45 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1679af30-ee17-3016-1bd3-192f744ad8ef@linaro.org \
--to=richard.henderson@linaro.org \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=dengjianbo@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).