From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97783 invoked by alias); 2 Nov 2016 17:03:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 97317 invoked by uid 89); 2 Nov 2016 17:03:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy=9377, EXT, 20729, automated X-HELO: mail-qt0-f174.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=o5VH6jXNYFBY/X0MhgydGCJEq8Em87N3TESIjWc8T3g=; b=c4yt7x0oEneWqyjajwEIXCkTAEoLS+pRznWQfe0BhirWbfqwWTOjGWtpKO0vKRc8Ex C4L+DSpQHTNl4T6Yya+7Al8bTMQJ9nHCpox1Yz3R/MtOg5t+CMhgd6WDULjeG844c1pS AxePYggy+4b5fPaM0a3RwVJMDlf0+GaBjeihbkfczUjnGWfA0b5wzIPuYF6PXxT8019K Y55I8b1Y6Gt+CQoWr1zPVTQPdmlvHSftLYvi5VSxpJmYqbwXWVXOO2uIa20KV2S7QM1b y7r0K09bRV1it6fskVscvIMjVE/Pw4C/UnpLOGo+OjyWu2Yg4ByJ7fxYVunCHQNO3yiZ bpOA== X-Gm-Message-State: ABUngvfbXTImEypEqg34GYUpR8fafx5H8qGfYiKzwd7KOjh8aDojtxu+mBjAVfHnam6Ewh+P X-Received: by 10.237.36.170 with SMTP id t39mr4317802qtc.115.1478106172951; Wed, 02 Nov 2016 10:02:52 -0700 (PDT) Subject: Re: [PATCH v4] Fix -Os related build and test failures. To: David Miller , Tamar.Christina@arm.com References: <87mvhjwod1.fsf@linux-m68k.org> <20161101.120625.1755763054875274977.davem@davemloft.net> Cc: joseph@codesourcery.com, schwab@linux-m68k.org, fweimer@redhat.com, libc-alpha@sourceware.org, nd@arm.com, Bin.Cheng@arm.com From: Carlos O'Donell Message-ID: <16b550f9-e5f0-ced0-38e9-022ccf3813b8@redhat.com> Date: Wed, 02 Nov 2016 17:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00068.txt.bz2 On 11/02/2016 07:52 AM, Carlos O'Donell wrote: > On 11/01/2016 12:06 PM, David Miller wrote: >> From: Tamar Christina >> Date: Tue, 1 Nov 2016 15:58:20 +0000 >> >>> This also breaks ARM and AArch64, >>> >>> Would it be worth reverting the commit until this is fixed? >>> It's currently blocking trunk builds. >> >> Mainline has been fixed already. > > No, there is one more issue left. My automated cleanup script > turned one of the DIAG's into an -Os diag by error. Joseph > noticed this and I'll fix it right now. > > I'm going to push out a Fedora Rawhide build to verify this > for: arm, aarch64, ppc64le, ppc64, s390, s390x, x86, and > x86_64. The changes to fix bug 20729 introduced an error which removed an ignore diagnostic from -O2 by using the new -Os related macro. This broke ppc64 builds. The following patch fixes the mistake. Tested on x86, x86_64, ppc64, ppc64le, arm, aarch64, and s390x. Checked in. 2016-11-02 Florian Weimer Carlos O'Donell [Bug #20729] * resolv/res_send.c (send_vc): Revert DIAG_IGNORE_Os_NEEDS_COMMENT change to non -Os related diagnostic. Use DIAG_IGNORE_Os_NEEDS_COMMENT for -Os related change. diff --git a/resolv/res_send.c b/resolv/res_send.c index 4ec8c1a..e96d5d4 100644 --- a/resolv/res_send.c +++ b/resolv/res_send.c @@ -664,7 +664,7 @@ send_vc(res_state statp, a false-positive. */ DIAG_PUSH_NEEDS_COMMENT; - DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); + DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); int resplen; DIAG_POP_NEEDS_COMMENT; struct iovec iov[4]; @@ -937,7 +937,7 @@ reopen (res_state statp, int *terrno, int ns) the function return -1 before control flow reaches the call to connect with slen. */ DIAG_PUSH_NEEDS_COMMENT; - DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); + DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized"); if (connect(EXT(statp).nssocks[ns], nsap, slen) < 0) { DIAG_POP_NEEDS_COMMENT; Aerror(statp, stderr, "connect(dg)", errno, nsap); --- Cheers, Carlos.