From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH v4] linux: make getcwd(3) fail if it cannot obtain an absolute path [BZ #22679]
Date: Fri, 12 Jan 2018 12:56:00 -0000 [thread overview]
Message-ID: <16b6bae9-68f9-1836-fbe0-0d8b6c571fad@redhat.com> (raw)
In-Reply-To: <20180111220320.GA20747@altlinux.org>
On 01/11/2018 11:03 PM, Dmitry V. Levin wrote:
> [BZ #22679]
> CVE-2018-1000001
> * sysdeps/unix/sysv/linux/getcwd.c (__getcwd): Fall back to
> generic_getcwd if the path returned by getcwd syscall is not absolute.
> * sysdeps/unix/sysv/linux/tst-getcwd-abspath.c: New test.
> * sysdeps/unix/sysv/linux/Makefile (tests): Add tst-getcwd-abspath.
The patch as such looks good to me. The test case should go into the
top-level io directory, where getcwd resides. I don't think it is
Linux-specific. Can you move it and commit it?
I still think we should have a realpath test as well, but that should
delaying committing this fix.
Thanks,
Florian
next prev parent reply other threads:[~2018-01-12 12:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 3:05 [PATCH] " Dmitry V. Levin
2018-01-07 8:23 ` Andreas Schwab
2018-01-07 11:33 ` Dmitry V. Levin
2018-01-07 12:20 ` Andreas Schwab
2018-01-07 12:36 ` Dmitry V. Levin
2018-01-07 12:41 ` [PATCH v2] " Dmitry V. Levin
2018-01-07 13:10 ` Florian Weimer
2018-01-07 13:39 ` [PATCH v3] " Dmitry V. Levin
2018-01-08 15:07 ` Dmitry V. Levin
2018-01-11 22:03 ` [PATCH v4] " Dmitry V. Levin
2018-01-11 23:44 ` Florian Weimer
2018-01-12 0:11 ` Dmitry V. Levin
2018-01-12 12:56 ` Florian Weimer [this message]
2018-01-07 15:53 ` [PATCH] " Zack Weinberg
2018-01-07 16:07 ` Andreas Schwab
2018-01-07 16:21 ` Zack Weinberg
2018-01-07 17:07 ` Dmitry V. Levin
2018-01-07 20:04 ` Zack Weinberg
2018-01-07 16:24 ` Dmitry V. Levin
2018-02-05 19:03 ` Florian Weimer
2018-02-05 19:18 ` Andreas Schwab
2018-02-05 20:03 ` Florian Weimer
2018-02-06 0:10 ` Dmitry V. Levin
2018-02-06 16:57 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16b6bae9-68f9-1836-fbe0-0d8b6c571fad@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).