From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102422 invoked by alias); 15 Nov 2016 20:57:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 102409 invoked by uid 89); 15 Nov 2016 20:57:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=defend, H*Ad:U*rth, Hx-languages-length:947, H*RU:74.125.82.65 X-HELO: mail-wm0-f65.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=y7lKStfXFm671kfU6A/z2MI73kFYW87qrWfMxxVWi70=; b=OnNcS2nixnV9tG6cwJ7yf1LY1Od8bJkD9kDIFDVJCRyC101t4Rtz9uHGFoY15PFII8 qYTNFmKKtgXBPmy6Hi5ssApJia0zQcIJv7U+LCNJfuGF8NkZljGPBaJWGxR3/+NXjgCd 2xR+yoZLihUhlZoZm1ke7O2G7B+Q0SJGnfeDD5UxeUpwXTpsBjB3LbYgL9pOPc+HbNqX ZQ+LLhKX9WAFSUdrg+Fn2kRAg2U31Cl17+C4nP7PL62MqBM3tXLEFaiW3XpiZ0iNskGP 7/fL3GnZWjfgudBJMe4bJHQBK/VJJvr6aI6ZB3vQ6IU0LZqQoPp+bUYsU3s5zryfvqV1 Q6PA== X-Gm-Message-State: ABUngvcTelL6120hdS3ThttOm8jXMMMyj7Weodhol2SIRGD8IiSVxezOJ1arFGq4VX6rHA== X-Received: by 10.28.211.72 with SMTP id k69mr5630681wmg.138.1479243451096; Tue, 15 Nov 2016 12:57:31 -0800 (PST) Subject: Re: [PATCH v7] getrandom system call wrapper [BZ #17252] To: Zack Weinberg , libc-alpha@sourceware.org References: <3dd5d3b8-c196-98fb-1671-90cd90ab90c7@redhat.com> <244f578c-889a-a4cf-c686-bb2a5e49cca1@panix.com> From: Richard Henderson Message-ID: <16cbe059-7128-05ad-7f9d-4e94abe0d9e3@twiddle.net> Date: Tue, 15 Nov 2016 20:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <244f578c-889a-a4cf-c686-bb2a5e49cca1@panix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2016-11/txt/msg00518.txt.bz2 On 11/14/2016 07:29 PM, Zack Weinberg wrote: > On 11/14/2016 12:44 PM, Florian Weimer wrote: >> I weakened the protection against accidental interposition somewhat. >> Since the declaration is a new header file, I do not use a function-like >> macro to prevent a definition of a function named “getrandom”, and >> non-GNU compilers do not get any redirection. > > We don't normally do this at all. I don't understand why this function > should be treated differently. Can you please explain what concrete > situations, involving real, existing code, you're trying to defend > against here? It has been proposed that we do this for all new non-standardized symbols. Which does make sense from a certain point of view. As far as I can see it can't hurt, and can only help when it comes to inter-operating with user binaries that could have legitimately used the symbols until now. r~