From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id C32303858C2B for ; Tue, 22 Nov 2022 16:20:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C32303858C2B Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1669134048; bh=nBdOoljmfzFsvw/e53ixaeDGpsGDDmqWplq0TPR6//k=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=TbaNULxlV5qMa0ukK62U+RtrtGu+UmXkg3kfg8N2RB9dFTPcSgXgzabcNjC4Hk1Dg 1/6HqbZsMkE5BvnCjdVKmVxbozfW2LZCmgQcKLCzbKVBCme9G4cJmGHA14ZB4HTPpW Us1k5lgr1P3ir8VtvoIRYoiTObHwVvmMSPsOkXtQ= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 8F6D26591B; Tue, 22 Nov 2022 11:20:46 -0500 (EST) Message-ID: <16d2603ead227edc39cd46bbd25c0fb4611c0392.camel@xry111.site> Subject: Re: [PATCH 0/9] LoongArch: Use builtins with GCC >= 13 From: Xi Ruoyao To: Xiaolin Tang , adhemerval.zanella@linaro.org, libc-alpha@sourceware.org, caiyinyu@loongson.cn Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn Date: Wed, 23 Nov 2022 00:20:44 +0800 In-Reply-To: <20221118112912.2501774-1-tangxiaolin@loongson.cn> References: <20221118112912.2501774-1-tangxiaolin@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD,KAM_NUMSUBJECT,LIKELY_SPAM_FROM,PDS_OTHER_BAD_TLD,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Xiaolin, I guess you need to resent the series because {1,8,9}/9 lacks the proper In-Reply-To: header, causing them missing from the patchwork interface (https://patchwork.sourceware.org/project/glibc/list/?series=3D14494).=20 The reviewers will use the patchwork interface to track the patches. On Fri, 2022-11-18 at 19:29 +0800, Xiaolin Tang wrote: > Patch 0001-0007: > GCC 13, LoongArch support builtins for {,l,ll}rint, logb, > use these built-ins instead of generic function implementation. >=20 > Patch 0008: > GCC 13, LoongArch support ___builtin_scalbn{,f} with -fno-math-errno, > but only "libm" can use -fno-math-errno in GLIBC, and scalbn is in > libc > instead of libm because __printf_fp calls it. So inline assembler of > the scalbn functions is a better choice for LoongArch. >=20 > Patch 0009: Add LoongArch support for scalb[f]. >=20 > Discuss with Xi Ruoyao > Link: > https://sourceware.org/pipermail/libc-alpha/2022-November/143425.html >=20 > Xi Ruoyao (1): > =C2=A0 LoongArch: Use __builtin_rint{,f} with GCC >=3D 13 >=20 > Xiaolin Tang (8): > =C2=A0 Use GCC builtins for lrint functions if desired. > =C2=A0 LoongArch: Use __builtin_lrint{,f} with GCC >=3D 13 > =C2=A0 Use GCC builtins for llrint functions if desired. > =C2=A0 LoongArch: Use __builtin_llrint{,f} with GCC >=3D 13 > =C2=A0 Use GCC builtins for logb functions if desired. > =C2=A0 LoongArch: Use __builtin_logb{,f} with GCC >=3D 13 > =C2=A0 LoongArch: Add support for scalbn[f] > =C2=A0 LoongArch: Add support for scalb[f] >=20 > =C2=A0sysdeps/generic/math-use-builtins-llrint.h=C2=A0=C2=A0=C2=A0 |=C2= =A0 4 ++ > =C2=A0sysdeps/generic/math-use-builtins-logb.h=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 4 ++ > =C2=A0sysdeps/generic/math-use-builtins-lrint.h=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0 4 ++ > =C2=A0sysdeps/generic/math-use-builtins.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 3 + > =C2=A0sysdeps/ieee754/dbl-64/s_llrint.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 18 ++++-- > =C2=A0sysdeps/ieee754/dbl-64/s_logb.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 5 ++ > =C2=A0sysdeps/ieee754/dbl-64/s_lrint.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 18 ++++-- > =C2=A0sysdeps/ieee754/float128/float128_private.h=C2=A0=C2=A0 |=C2=A0 6 += + > =C2=A0sysdeps/ieee754/flt-32/s_llrintf.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 18 ++++-- > =C2=A0sysdeps/ieee754/flt-32/s_logbf.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 5 ++ > =C2=A0sysdeps/ieee754/flt-32/s_lrintf.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 18 ++++-- > =C2=A0sysdeps/ieee754/ldbl-128/s_llrintl.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 17 ++++-- > =C2=A0sysdeps/ieee754/ldbl-128/s_logbl.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 6 ++ > =C2=A0sysdeps/ieee754/ldbl-128/s_lrintl.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 17 ++++-- > =C2=A0sysdeps/loongarch/fpu/e_scalb.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 60 > +++++++++++++++++++ > =C2=A0sysdeps/loongarch/fpu/e_scalbf.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 60 > +++++++++++++++++++ > =C2=A0.../loongarch/fpu/math-use-builtins-llrint.h=C2=A0 | 10 ++++ > =C2=A0.../loongarch/fpu/math-use-builtins-logb.h=C2=A0=C2=A0=C2=A0 | 10 += +++ > =C2=A0.../loongarch/fpu/math-use-builtins-lrint.h=C2=A0=C2=A0 | 10 ++++ > =C2=A0.../loongarch/fpu/math-use-builtins-rint.h=C2=A0=C2=A0=C2=A0 |=C2= =A0 9 +++ > =C2=A0sysdeps/loongarch/fpu/s_scalbn.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 29 +++++++++ > =C2=A0sysdeps/loongarch/fpu/s_scalbnf.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 29 +++++++++ > =C2=A022 files changed, 326 insertions(+), 34 deletions(-) > =C2=A0create mode 100644 sysdeps/generic/math-use-builtins-llrint.h > =C2=A0create mode 100644 sysdeps/generic/math-use-builtins-logb.h > =C2=A0create mode 100644 sysdeps/generic/math-use-builtins-lrint.h > =C2=A0create mode 100644 sysdeps/loongarch/fpu/e_scalb.c > =C2=A0create mode 100644 sysdeps/loongarch/fpu/e_scalbf.c > =C2=A0create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-llrint.h > =C2=A0create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-logb.h > =C2=A0create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-lrint.h > =C2=A0create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-rint.h > =C2=A0create mode 100644 sysdeps/loongarch/fpu/s_scalbn.c > =C2=A0create mode 100644 sysdeps/loongarch/fpu/s_scalbnf.c >=20 --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University