From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57908 invoked by alias); 24 Jul 2019 14:48:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 57900 invoked by uid 89); 24 Jul 2019 14:48:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=installation X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794] To: libc-alpha@sourceware.org References: <87muh4zpc2.fsf@linux.ibm.com> From: Stefan Liebler Date: Wed, 24 Jul 2019 14:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <87muh4zpc2.fsf@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit x-cbid: 19072414-0020-0000-0000-00000356BFFD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19072414-0021-0000-0000-000021AAB05B Message-Id: <17162ecb-9c00-34db-ffe6-2b0cfdcdcd44@linux.ibm.com> X-SW-Source: 2019-07/txt/msg00546.txt.bz2 Hi, starting with this commit, I see the following fail: cat nss/tst-nss-files-hosts-long.out error: tst-nss-files-hosts-long.c:35: ahostsv4 failed error: 1 test failures Does anybody else also see this fail? While running "make check" I've recognized the output of support/shell-container.c: sh: execing getent failed: No such file or directory File sh: execing /usr/bin/makedb failed: No such file or directory File And indeed getent does not exist in /testroot.root or /testroot.pristine. Without this commit, it was available. In older logs, I've found these commands: /usr/bin/install -c build/nss/getent build/testroot.pristine/usr/bin/getent.new /usr/bin/install -c build/nss/makedb build/testroot.pristine/usr/bin/makedb.new mv -f build/testroot.pristine/usr/bin/getent.new build/testroot.pristine/usr/bin/getent mv -f build/testroot.pristine/usr/bin/makedb.new build/testroot.pristine/usr/bin/makedb Can anybody help? Bye Stefan On 7/23/19 6:29 PM, Tulio Magno Quites Machado Filho wrote: > DJ Delorie writes: > >> Tulio Magno Quites Machado Filho writes: >>> Whenever a sub-make is created, it inherits the variable subdirs from its >>> parent. This is also true when make check is called with a restricted >>> list of subdirs. In this scenario, make install is executed "partially" >>> and testroot.pristine ends up with an incomplete installation. >> >> "obvious in retrospect" Sigh. >> >>> 2019-07-22 Tulio Magno Quites Machado Filho >>> >>> [BZ #24794] >>> * Makefile (testroot.pristine/install.stamp): Pass >>> subdirs='$(all-subdirs)' to make install. >> >> LGTM. Thanks! >> >> Reviewed-by: DJ Delorie > > Pushed as 35e038c1d2ccb. > > Thanks! >