From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 7DB413858D3C for ; Fri, 24 Nov 2023 12:30:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7DB413858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7DB413858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1035 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700829006; cv=none; b=AmDj9y90RNPURH7x52hbG4/60m3L1k+l5XxkeUz/s062M1Or6B166Bzh5J1qZ4gDBMeNQBvnJnh5UehA+wRPZBKYIUntxoZmGcm5j54LKVNysF88UVEG7bRoDQRP4hHAQiIPaNQINslOlZjqykJ1ojfPOZMO2k5ldRTZ/fG5z4k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700829006; c=relaxed/simple; bh=f7OwW9O6mzOddyunKSXvAopr4gqTB0vFYacMN6zIbME=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=u9/TQLu6DT90LkVJDzZVkEaKnk/YCntdzAxasOmzBRfYbEKEwGx/fuv9KCDxLXPlLxlDZi/IpTrnvP9Z+rtJOSJGxLmv135sxTCFyP8OFbs2XJOttyzcHfBpldbMPi5A84gsp3o+SOGFBQJ3dvXjwlSMEdap/F7BZRp7oWM7p9E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-285949d46d0so191163a91.0 for ; Fri, 24 Nov 2023 04:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700829002; x=1701433802; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xBXW+/FqaXsT21nrqCd792eFYc0JEoC/mDosSPbMmJY=; b=P9kYx0NrI6iBIBvIijxE3HsNEqx4ed6etjRpMMQW6/bqD2/XR4+ecVOb3h+ST2rSUJ /NOuQMOYbgFaE2Yj/8L/l9TyjJLTHck22zkEeNsVJqrOogpT94zxK9/F7HVJK5Xh9B1u 1S2P4x8tDtxrGgB2zTfYll9/UTWzWVpQaWSmFgk8C0gijAfIYmcvPXhwk10iZFSL4hp0 VF3kuGzOQu0XLoNW+u8oI3loMwCCoUT0qPsgo40OL/tJAJ8LX7Kudyi+aXwU9NosYbr2 kPH+NrQLYg5A5+pTdfKKV0pBo6V7Nk6A9LOz/ya0GbfdfM0V2blfzQ1hqKnnMXdavyu/ 5lSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700829002; x=1701433802; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xBXW+/FqaXsT21nrqCd792eFYc0JEoC/mDosSPbMmJY=; b=XIfYv3O5/9N0/9hVONQOnwP2T+0CEI6j8OjwxteqEKdO2Ujlip0GYig1hgHpG+BhyH dr2dDL538ypqU9zkOF91pF0AbMCnsoPo/rAdaDuiYG20XdafFyhU9lVcIl4DA9t3LmsT 1MYEcAEOwabUArNEvXbBqKInP8NLY4LSd3xszIwZcU6LawYGblt+SPSDzMGjiyXV4Vb7 CjoCG98Gc3eLbGk6ZWvSvScDVaqf6KdxvPCKERTffPYPuhNV47hbNMqAWxVMdM2dAknL kPfsTRV3aq3KhBp0ZcGY0y6XdDhkYbpo0JTJdSSX4bFEoDgNoMVdG/eGybRoR2sV7eJn yxMQ== X-Gm-Message-State: AOJu0YxuERepdX9NTsiCkZ1cV4we1pfGJYAji+vdBQFwh7HtnwdIj7t+ M1MzrL5QhsMYhhHH6Xzwz7fMdYcRuGQkQ4x9vZUNzg== X-Google-Smtp-Source: AGHT+IGifOeSWe/2UIqDeiNu0/N9kw+91fA9EPWVy4JakI/J2D4lYdVB0cUu1Rx+ZvpGIziukUkMXg== X-Received: by 2002:a17:90b:4b4f:b0:283:2873:88ad with SMTP id mi15-20020a17090b4b4f00b00283287388admr3667468pjb.10.1700829002457; Fri, 24 Nov 2023 04:30:02 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:94e:6d59:cb73:1a0b:30ad? ([2804:1b3:a7c2:94e:6d59:cb73:1a0b:30ad]) by smtp.gmail.com with ESMTPSA id s17-20020a170902ea1100b001c9c47d6cb9sm3065061plg.99.2023.11.24.04.29.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Nov 2023 04:30:00 -0800 (PST) Message-ID: <171e5ae6-bbad-4378-b65a-7c1845e2bc49@linaro.org> Date: Fri, 24 Nov 2023 09:29:59 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libio: Remove comment in Content-Language: en-US To: Jonny Grant , GNU C Library References: <7e2e9d58-53cd-40be-853a-6e1776cdd1c3@jguk.org> <18fa8de3-526f-4598-b6b3-c5611b1cd38e@linaro.org> <11e1625e-4f80-4534-b0ae-250fa44c4997@jguk.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <11e1625e-4f80-4534-b0ae-250fa44c4997@jguk.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/11/23 16:54, Jonny Grant wrote: > > > On 30/10/2023 12:36, Adhemerval Zanella Netto wrote: >> >> >> On 28/10/23 19:37, Jonny Grant wrote: >>> Hello >>> >>> Please find attached patch created against latest git. >>> >>> Regards, Jonny >> >> For new header the current practice is to add a one-line comment to >> describe it, so I think it would be better to follow it on old header >> changes. > > Hi Adhemerval > > May I clarify, this file has this after the copyright & license. I considered that was enough. Do you mean I should put that at the top of the file as well? > > /* > * ISO C99 Standard: 7.19 Input/output > */ > > With kind regards, Jonny Yes. Our current practice is always add one-line comment on a new file, even the installed ones, with a brief description.