From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C47353858D33 for ; Thu, 2 Mar 2023 17:40:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C47353858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677778813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MGU2zbM5nL85LXUIg95GN1TmvztoICVkUURCubWnKcY=; b=GSHsPeA0YJFQeWVxj8y0aBtBsE7uFut1rK4FxFUqUO51J2+GXkAQncBp+cQqpPj6Kf778T oDXcQ9LDGce+3i5v5jiMtS93wm4LGtmrbwdipj8BPQVIVgvy5ejcHChszWBV/TpSGo/uLw Kas4b8eIn4UWOOuTFxzSfiOUO1mCuoY= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-661-s9KjGfcXPd6JhJD2pyUp0Q-1; Thu, 02 Mar 2023 12:40:12 -0500 X-MC-Unique: s9KjGfcXPd6JhJD2pyUp0Q-1 Received: by mail-il1-f198.google.com with SMTP id l1-20020a056e021c0100b003180af2a284so115823ilh.1 for ; Thu, 02 Mar 2023 09:40:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677778812; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MGU2zbM5nL85LXUIg95GN1TmvztoICVkUURCubWnKcY=; b=ct6r9vfHpdZN1Z+A5MBfR1oWeeEBFkCL0YGfoRfc6KS7vVggP6kQNcx8btAJp9tk1l de6plQGHl/cOecW/TchBla+JvRCl/+w5TJ192VvbbSscX3kcmgXNovG56THpZjHlXXZT bjFL0uHToz5fBSzJe8SSKmfEEySp8n7TnWrBzuV6DytRPRe3GGbkPSvGE1H76Ra4ojCl VfN5SQy4wTuQCHGPMUxACZhwGGQOXZJt0I59PiGGa/DD7LswohIG6K22di/jh1BOmPDj b7+tdz7pln7h/THT8Vn1F0fVSKn9D/mxTLQOPU1m+upqJ/qNr8ITfoiQo4Fw3XofwdTk UWsg== X-Gm-Message-State: AO0yUKXgo4UfIZTLMHcIXHKn0hV/TWBeh6tOBWZPePUq27zJpdYvM7Oy I1EcVz00Mi4Hl42V7FIRNLvcsKCUA3+s7efURgWCjQ9MDmpIrklJAJJG/qrosCpVCHKHc9mK8Vi qLyQD1j+CLN90zGcPctnQ X-Received: by 2002:a05:6e02:174a:b0:319:23c7:5553 with SMTP id y10-20020a056e02174a00b0031923c75553mr847475ill.32.1677778811868; Thu, 02 Mar 2023 09:40:11 -0800 (PST) X-Google-Smtp-Source: AK7set/o94seopAgrugpWZdTMoQbpsq2CTaqLChYW9yg45uC55uBYkuNjW7x2VimgJ7tcDOQkUwI3Q== X-Received: by 2002:a05:6e02:174a:b0:319:23c7:5553 with SMTP id y10-20020a056e02174a00b0031923c75553mr847463ill.32.1677778811552; Thu, 02 Mar 2023 09:40:11 -0800 (PST) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id a23-20020a029997000000b003884192cc05sm25101jal.120.2023.03.02.09.40.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 09:40:11 -0800 (PST) Message-ID: <1724317d-aaa8-e200-0b09-00ce81ec01be@redhat.com> Date: Thu, 2 Mar 2023 12:40:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] fix pthread_mutexattr_gettype always return 0 To: =?UTF-8?B?YWJ1c2h3YW5nKOeOi+eDgSk=?= , "libc-alpha@sourceware.org" References: From: Carlos O'Donell Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/2/23 02:54, abushwang(王烁) via Libc-alpha wrote: > From 03481285aff8d0d5a993f1969fb87afc946e2a91 Mon Sep 17 00:00:00 2001 > From: Shuo Wang abushwang@tencent.com > Date: Thu, 2 Mar 2023 14:58:20 +0800 > Subject: [PATCH] fix pthread_mutexattr_gettype always return 0 > > According to posix, pthread_mutexattr_gettype will return EINVAL > when the value specified by attr is invalid. Fails CI: https://patchwork.sourceware.org/project/glibc/patch/c494dd3c4cc54544b14fc2f8ccea6266@tencent.com/ Patch fails to apply. Please review the contribution checklist: https://sourceware.org/glibc/wiki/Contribution%20checklist > --- > nptl/pthread_mutexattr_gettype.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/nptl/pthread_mutexattr_gettype.c b/nptl/pthread_mutexattr_gettype.c > index 21e0a9e946..ee5ee71a88 100644 > --- a/nptl/pthread_mutexattr_gettype.c > +++ b/nptl/pthread_mutexattr_gettype.c > @@ -28,6 +28,9 @@ __pthread_mutexattr_gettype (const pthread_mutexattr_t *attr, int *kind) > *kind = (iattr->mutexkind & ~PTHREAD_MUTEXATTR_FLAG_BITS > & ~PTHREAD_MUTEX_NO_ELISION_NP); > + if (kind < PTHREAD_MUTEX_NORMAL || kind > PTHREAD_MUTEX_ADAPTIVE_NP) > + return EINVAL; > + > return 0; > } > versioned_symbol (libc, __pthread_mutexattr_gettype, > -- > 2.36.1 > -- Cheers, Carlos.