public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Magnus Granberg <zorry@gentoo.org>
To: libc-alpha <libc-alpha@sourceware.org>
Subject: [PATCH] Bug 20662: checking whether x86_64-pc-linux-gnu-gcc implicitly enables -fstack-protector no (32bit gcc 6.2.0 pie and ssp enable)
Date: Thu, 20 Oct 2016 20:02:00 -0000	[thread overview]
Message-ID: <1784772.eOhSpX4WhJ@laptop1.gw.ume.nu> (raw)

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

When glibc get compile with gcc 6.2 that have been configured with
 --enable-default-pie and --enable-default-ssp. The check that check if the 
compiler use -fstack-protector as default fail on the 32bit part.

checking for libgd... no
checking for _FORTIFY_SOURCE predefine... yes
checking whether x86_64-pc-linux-gnu-gcc -m32 -Wl,-O1 -Wl,--as-needed 
implicitly enables -fstack-protector... no
checking whether the linker provides working __ehdr_start... yes

This patch make so we look for __stack_chk_fail_local in the check.
Tested on x86_64 multilib Gentoo

Changelog:

2016-10-20  Magnus Granberg  <zorry@gentoo.org>
		Denis Kaganovich  <mahatma@eu.by>

		* configure.ac:
		Add check for __stack_chk_fail_local in libc_cv_predef_stack_protector 	
		check.
		* configure: Regenerated.

---

[-- Attachment #2: glibc-gcc6.patch --]
[-- Type: text/x-patch, Size: 1039 bytes --]

diff --git a/configure.ac b/configure.ac
index a64aeb9..de42b6b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1667,12 +1668,14 @@ echo >&AS_MESSAGE_LOG_FD "libc_undefs='$libc_undefs'"
 # symbols (resolved by the linker), so filter out unknown symbols.
 # This will fail to produce the correct result if the compiler
 # defaults to -fstack-protector but this produces an undefined symbol
-# other than __stack_chk_fail.  However, compilers like that have not
-# been encountered in practice.
-libc_undefs=`echo "$libc_undefs" | egrep '^(foobar|__stack_chk_fail)$'`
+# other than __stack_chk_fail or __stack_chk_fail_local. However,
+# compilers like that have not been encountered in practice.
+libc_undefs=`echo "$libc_undefs" | \
+  egrep '^(foobar|__stack_chk_fail|__stack_chk_fail_local)$'`
 case "$libc_undefs" in
 foobar) libc_cv_predef_stack_protector=no ;;
 '__stack_chk_fail
+foobar'|'__stack_chk_fail_local
 foobar') libc_cv_predef_stack_protector=yes ;;
 *) AC_MSG_ERROR([unexpected symbols in test: $libc_undefs]) ;;
 esac],

             reply	other threads:[~2016-10-20 20:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20 20:02 Magnus Granberg [this message]
2016-10-21  8:58 ` Szabolcs Nagy
2016-10-22 13:03   ` Magnus Granberg
2016-11-15 19:37 ` [PATCH/committed 2.24] configure: accept __stack_chk_fail_local for ssp support too [BZ #20662] Mike Frysinger
2016-11-15 19:37 ` [PATCH/committed 2.23] " Mike Frysinger
2016-11-15 19:37 ` [PATCH] Bug 20662: checking whether x86_64-pc-linux-gnu-gcc implicitly enables -fstack-protector no (32bit gcc 6.2.0 pie and ssp enable) Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1784772.eOhSpX4WhJ@laptop1.gw.ume.nu \
    --to=zorry@gentoo.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).