From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7657E3858C98 for ; Wed, 28 Feb 2024 12:39:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7657E3858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7657E3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709123976; cv=none; b=FQm8wYfyOjefix5Jya6HPsVoysSiWojfnQB8F4heK7e9ZzJubU2lRTR4muEtPersOSQXYA1fVafmUhKbTZbYkvFXcLj4/arxjivRvcYcLP5vKTA4Vc2lXmtfWIna7JkAxCrp2tL64ydB4pCm1Sbzr2enW6jss+Yua2NEXhd4dH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709123976; c=relaxed/simple; bh=JvcX2SsHZgeSzDz5WIDhzhjRqsgvOKqo0nj9ayNBegk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=befXWPrfzD/8XR0aUTutGHYcbINSLzXW+BJoQMeyEIOLLWPmchGifDYBOmCvRQhAHLssEUhUUPfIAbMIm1ajtf3npJ2Y8e7LkzkeGOSpafROQH5J262KLADkU41XTjof593hoguDJvz7eTLxub7o4hijWw4j5Vke/JAaUkhLr/I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709123972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4NkaBDkhH4Ip+SSaQNGW7gDw+gQGSehsa/opWTendiQ=; b=NyGOGIhzjtXhXlR48Uulg6hsg0fjweKJ3wEWy+8EreTF193ReLxhG6MHRxXm+sJwjf7qgj EwQd33LNw1MZ6FUgu3/IPUhsxFXreIW+Xo5lqPs22p4vgwM8tH4Ad9Vx8YGR3ewQsqFCo8 p5wwUjEkSBFNw3fgh0lzQxmzmFuLhso= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-7mtdfHvtMBmCdaJuVB1ZkQ-1; Wed, 28 Feb 2024 07:39:30 -0500 X-MC-Unique: 7mtdfHvtMBmCdaJuVB1ZkQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-33de2dbe650so1408303f8f.0 for ; Wed, 28 Feb 2024 04:39:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709123969; x=1709728769; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4NkaBDkhH4Ip+SSaQNGW7gDw+gQGSehsa/opWTendiQ=; b=h/EIbaF6cfDMV7y86XlLGLm+8XN/jLzjYPoeXOEtu4M9Id13XMP50vYq0bGcq4VASt TDuSBRzUR1vXd6Ypj49U9NlUjQYnh/3mMxp3GlT8klw/KqfqbezxxH840lhIqnAPS8fz AiTsDpaX2TqJt7FrZhHy+UUUg6iwc7+DDOIvcPFE1AUCoZQOdI2gVh7kju1kgabx7cXO r0CPgJp31028lUil1zAoyz1eqk2/bYP5bXtKPmOy3flsXoXeOL6TuODpxqMEmCMfTwU1 Lobj0Y7w6nujTBFD5151cBb1iZ7mEGcZkk/eRtwnrsv+1SASo9GtJaB6CuQ8HY9ruPM6 tsfg== X-Gm-Message-State: AOJu0YwUH+so8aNJJlA7C3LL9dFjIAKuiOsyeUGJzEU3PRulymfgjv8j zpkXWPBWx9UUeClgcCdxi5LD+iJr3UFExHnlbfcKbCkFQakBhzwHpvA7TmhKctKgyZWI57FY6fB 9EggElmmGChsASIfUP5QjpKSzERaxfpNPd9qo5QzAReHMjuWAyMML6b28N0jJgGBJYQ== X-Received: by 2002:adf:ef87:0:b0:33d:942f:6784 with SMTP id d7-20020adfef87000000b0033d942f6784mr9353438wro.57.1709123969182; Wed, 28 Feb 2024 04:39:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcOvgmFbW8PkFsr5e7gRVCCZ+WtcIqzFLqwDEVLEEmHYzb4HpNxNt+CNYNHLJQIwudHeB0jw== X-Received: by 2002:adf:ef87:0:b0:33d:942f:6784 with SMTP id d7-20020adfef87000000b0033d942f6784mr9353424wro.57.1709123968825; Wed, 28 Feb 2024 04:39:28 -0800 (PST) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id t9-20020adfeb89000000b0033dbeb2eb4dsm14298806wrn.110.2024.02.28.04.39.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 04:39:28 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rfJD3-0005hg-Cd; Wed, 28 Feb 2024 12:38:53 +0000 Date: Wed, 28 Feb 2024 12:38:53 +0000 (UTC) From: Joseph Myers To: Florian Weimer cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 21/32] elf: _dl_rtld_map should not exist in static builds In-Reply-To: <6515a7c0cae19a148a3eb745aeb9f309e77d73fe.1701944612.git.fweimer@redhat.com> Message-ID: <17b73d45-e047-98ad-b7a-97742cc7cdcf@redhat.com> References: <6515a7c0cae19a148a3eb745aeb9f309e77d73fe.1701944612.git.fweimer@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Dec 2023, Florian Weimer wrote: > We have separate objects for SHARED and !SHARED, so there is no need > to make the rtld link map equality check somehow work in static > builds. Instead, hide the _dl_rtld_map reference in the new > is_rtld_link_map function, and simply define that to return false > for !SHARED because the static linked loader does not have a link > map. Probably this should replace all comparisons with &GL(dl_rtld_map) with calls to is_rtld_link_map (unless there's a specific reason such a replacement is problematic in a given case), even if no SHARED conditional is involved? I don't think it does at present. Maybe patch 11 (which I still need to review) was meant to remove dl-dst.h (which it doesn't; nor does it remove the include of dl-dst.h from elf/dl-origin.c), which would deal with IS_RTLD there. But what about sysdeps/x86/dl-prop.h and sysdeps/x86_64/dl-cet.c, or a few such comparisons in rtld.c itself? -- Joseph S. Myers josmyers@redhat.com