From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 4CBA43857820 for ; Mon, 25 Apr 2022 16:01:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4CBA43857820 Received: by mail-oi1-x22d.google.com with SMTP id q129so17605963oif.4 for ; Mon, 25 Apr 2022 09:01:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=hljcqBkScXv2tOiYjQT5zVr3IRhY6une4IT69wkNdeU=; b=6/09L8+0toRRWnheVjoYu25JNkyQ77GhvAnHgVmKPnMOGupDOhp0IMSPDiyUPuLsPb TmEDprAouS0nP1l/o+WcasI7Ji6U4uk6N7MHSexxXRcVxTHx2bh2pkLym1nr3jrSMNbC xM83O9xt/MbvoyvCt9hSeN0WEso3PKIBVbt783A6dyUJmpHmlY+179SsmSp7tNJJrFFy nmVu1mHt9XjN1Od3/pQLcbL7TkUQGg190aZIAILIBjugAII+op6/8/iOVuPl7avRRq0V /NtIFqLy5SxIYTTaGf9zj2icHqCKEmMXaaqoC/o7i7PXyOTHyjtmwfbc5BT5J6DfDwyG VGzA== X-Gm-Message-State: AOAM530Xs8g5nSG5bvBrsFzxQcS6/2za9rBipvl+YorZeo+0wBVYFYYF uC8FRGsLi4M5NIo6FzwF9Xx9menM04DY8Q== X-Google-Smtp-Source: ABdhPJyuNWH5A/sb3GXfvX8KZvnr9iZMrWtIfShZCCf+ptUCQ6GckkVoOhq4bXN838Bx68tywjpYjQ== X-Received: by 2002:a05:6808:2021:b0:322:ba69:53d2 with SMTP id q33-20020a056808202100b00322ba6953d2mr12912657oiw.22.1650902468169; Mon, 25 Apr 2022 09:01:08 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:4214:b4dd:3339:98d6:1ec0? ([2804:431:c7ca:4214:b4dd:3339:98d6:1ec0]) by smtp.gmail.com with ESMTPSA id g17-20020a544f91000000b003255010d173sm374481oiy.54.2022.04.25.09.01.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 09:01:07 -0700 (PDT) Message-ID: <17de1f0b-1907-5c45-6693-7b6d1b3a5f7f@linaro.org> Date: Mon, 25 Apr 2022 13:01:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 1/6] elf: Refactor dl_new_hash so it can be tested / benchmarked Content-Language: en-US To: libc-alpha@sourceware.org References: <20220414041231.926415-1-goldstein.w.n@gmail.com> <20220425155814.3558359-1-goldstein.w.n@gmail.com> From: Adhemerval Zanella In-Reply-To: <20220425155814.3558359-1-goldstein.w.n@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 16:01:11 -0000 On 25/04/2022 12:58, Noah Goldstein via Libc-alpha wrote: > +#include > + > +static uint32_t > +_dl_new_hash (const char *s) > +{ > + uint32_t h = 5381; > + for (unsigned char c = *s; c != '\0'; c = *++s) > + h = h * 33 + c; > + return h; > +} > + > + > +#endif /* dl-new-hash.h */ If you use a static inline you don't need to use a namespace reversed name. And I think it does make sense to use inline here.