From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by sourceware.org (Postfix) with ESMTPS id A788D3887CC4 for ; Thu, 8 Dec 2022 19:15:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A788D3887CC4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-1443a16b71cso2914737fac.13 for ; Thu, 08 Dec 2022 11:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fr3YW4mUuDI+xoiN6zSCKO6oiDwSDCIJ3+PVCVHP03s=; b=nP8OnT9UTNTfgxqduuXEKJUiP2Re31xrs6V7HCQ92hTWkH6rnlBk2stqsErUmsA8nH FjTDBuTTfzTqovYyF+OXA5rnev9alELJn8KG5CmTpMl+L8TRKAPs0L0vEZgXSxbNZg31 3esJjomjbhK/Gf0WzSBzYoo6zgKJt2Fz3ovi8D3UBBQPw4b9NgP/j9YUpBpGdtw3DP0Z EYTwXe023syFyTjL9O7XvlOqunvncAk5qHlRWpip2D/n8namEedyvyGJIBHpB89oc41a 2XLjDm56e1lLcFQBKcE9SOiCtBjZDe6LC+DZCEPKWifhOa3BJXcmwsgjSD7A6B8lMpx4 eW3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fr3YW4mUuDI+xoiN6zSCKO6oiDwSDCIJ3+PVCVHP03s=; b=BpOwqMTbDYBXCoOxXugwwEnz8f8Z6e3jMbt1/5+IMaayAHDSF8Eg6noFOrISDZYcVT L4ezY3Eum0iKFmFNdVO9aW6UmnXrWUBbENxo/T8yMqD7SeRnwYUIugPAXAyvAgkAjLZp LMibHrkCUJQvACCoLUERW5p4lm9IJw+GK0lnRlLDOTQvdlgYeQxD4I16Hn9XHOVSKfYC Mk90pUOr6H7m1b1378yjCm8utQLDU9PwuxOFxPJUH/gguFibQtlVP9GoJ/X+gp0w4dPq 1D+4aij3svnteKkIHVXHS/Gp+PM0KvanZwTFCnjbn8KVE67cTNaGgcF9httWdlMiMoeT Yjxg== X-Gm-Message-State: ANoB5pmjNJKPL9cHZqVz7Ad1Xp/x7yA4lHwjqPJHVwYDCt3+aB4+6LQm vYF1H1tpTOv0MJGx8bPXnpX7vSPgr0q5wpKIN3w= X-Google-Smtp-Source: AA0mqf42xw4ST6uw4JlvzvKdFi0Pmr02KxQxUfwQZsZuoD6jj1lg30p2jvTnjlXcqJuvm0STbl3eXw== X-Received: by 2002:a05:6871:a6a2:b0:144:8645:e78f with SMTP id wh34-20020a056871a6a200b001448645e78fmr10228554oab.39.1670526933864; Thu, 08 Dec 2022 11:15:33 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:6793:d83e:e871:6162:c8c0? ([2804:1b3:a7c2:6793:d83e:e871:6162:c8c0]) by smtp.gmail.com with ESMTPSA id v10-20020a05687105ca00b00143776f70d3sm13994072oan.29.2022.12.08.11.15.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 11:15:33 -0800 (PST) Message-ID: <17f1da40-afd1-fb99-3185-82ce93ba19e8@linaro.org> Date: Thu, 8 Dec 2022 16:15:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 0/1] __libc_start_main() now uses auxv to obtain phdr's address [BZ #29864] Content-Language: en-US To: libc-alpha@sourceware.org References: <73l3eC0YTCoWnmm2zGV-SIY9-W5DQ-peyx7secTao121qocwqub-R4Zhrpkai8_LRxy4xsn7ARdHRbI7NnzSysk6ACmQWfiavdpz-tA70xc=@protonmail.com> <877cz1hgjl.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <877cz1hgjl.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/12/22 15:54, Florian Weimer via Libc-alpha wrote: > * Yago Gutiérrez via Libc-alpha: > >> From bf2371ce732194f652719aff4af0f9021f9cbd90 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?Yago=20Guti=C3=A9rrez?= >> Date: Wed, 7 Dec 2022 12:49:22 +0100 >> Subject: [PATCH 1/1] __libc_start_main() now uses auxv to obtain phdr's >> address [BZ #29864] >> To: libc-alpha@sourceware.org > > This needs a much more elaborate commit message. > > I don't quite get why you need to add this to _rtld_global. This is > only used by the static startup code. > > This looks like it is a fix for the refactoring in: > > commit 73fc4e28b9464f0e13edc719a5372839970e7ddb > Author: Florian Weimer > Date: Mon Feb 28 11:50:41 2022 +0100 > > Linux: Consolidate auxiliary vector parsing (redo) > > And optimize it slightly. > > This is commit 8c8510ab2790039e58995ef3a22309582413d3ff revised. > > In _dl_aux_init in elf/dl-support.c, use an explicit loop > and -fno-tree-loop-distribute-patterns to avoid memset. > > Reviewed-by: Szabolcs Nagy > > What are the actual failures you see? Even if it does not fix a user visible failure, I think align the dl_phdr value with the kernel provided ones (since it is the responsible to actually load the binary) makes sense.