From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
"H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] nptl: Zero-extend arguments to SETXID syscalls [BZ #26248]
Date: Fri, 17 Jul 2020 11:52:19 -0400 [thread overview]
Message-ID: <180ab9db-d012-52c9-736f-437eecafc35b@redhat.com> (raw)
In-Reply-To: <87sgdqp434.fsf@oldenburg2.str.redhat.com>
On 7/17/20 11:13 AM, Florian Weimer wrote:
> * Carlos O'Donell:
>
>> This test should run in a container, and it should attempt two setgroups
>> calls, one with groups and one empty with a bad address.
>
> Why do you think this needs a container?
We are trying to successfully call setgroups(), and to do that we need
CAP_SETGID. The way this test is exercising this is by making the test
an xtests which can require root and thus you get CAP_SETGID in that way.
My suggestion is to move the test from xtests to tests-container to increase
the usage of the test. In the container we have a CLONE_NEWUSER so we have
a distinct usersnamespace that can be used in conjunction with becoming
root, getting CAP_SETGID, and calling setgroups() without restricting this
test to `make xcheck`.
I see that we don't explicitly say `make xcheck` may require root.
Is this something I just taught myself implicitly? :-)
Note: We may need to adjust the gid_map writing code in test-container.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2020-07-17 15:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 11:26 [PATCH] nptl: Properly inline setgroups syscall " H.J. Lu
2020-07-16 12:03 ` Florian Weimer
2020-07-16 12:46 ` [PATCH] nptl: Zero-extend arguments to SETXID syscalls " H.J. Lu
2020-07-16 15:57 ` Florian Weimer
2020-07-16 16:00 ` H.J. Lu
2020-07-16 19:38 ` Aurelien Jarno
2020-07-16 19:45 ` Aurelien Jarno
2020-07-16 21:42 ` H.J. Lu
2020-07-17 2:14 ` Carlos O'Donell
2020-07-17 2:46 ` H.J. Lu
2020-07-17 15:01 ` Carlos O'Donell
2020-07-17 15:13 ` Florian Weimer
2020-07-17 15:52 ` Carlos O'Donell [this message]
2020-07-17 19:31 ` H.J. Lu
2020-07-17 21:22 ` Carlos O'Donell
2020-07-23 20:03 ` H.J. Lu
2020-07-23 21:11 ` Carlos O'Donell
2020-07-23 21:17 ` Adhemerval Zanella
2020-07-23 21:20 ` Carlos O'Donell
2020-07-27 3:37 ` Carlos O'Donell
2020-07-27 6:00 ` Florian Weimer
2020-07-27 11:55 ` H.J. Lu
2020-07-27 12:20 ` Florian Weimer
2020-07-27 14:29 ` V3 " H.J. Lu
2020-07-27 15:49 ` Florian Weimer
2020-07-27 19:17 ` H.J. Lu
2020-07-20 11:38 ` Florian Weimer
2020-07-17 19:42 ` V2 " H.J. Lu
2020-07-17 22:27 ` Aurelien Jarno
2020-07-17 22:31 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=180ab9db-d012-52c9-736f-437eecafc35b@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).