From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by sourceware.org (Postfix) with ESMTPS id 7ECB2385801D for ; Mon, 22 Feb 2021 14:23:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7ECB2385801D Received: by mail-qk1-x736.google.com with SMTP id z128so8140432qkc.12 for ; Mon, 22 Feb 2021 06:23:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v7uXCg/swrwiGjrtL/J7Qbb1G7v2Z4oj22uHTBja3NI=; b=muyT0jYjXuqSWwFdOpc2bvCxYdhg6YzmZ9X0iK1nvOws7rTU074cNbgbs9nrsg5xLa ysP3YH5AMoaSLH0zt/9hGD+VGF1dU4SCh2Kx5c4NkIVIlWpjGAn0H+2r0S/kCESQVOK7 evHIoknXlAG1q6CGwbuTTPfg/+D7RDGUjmUGRxoy5Po6abZq0sF0XTVM4G02LWdre7Do OkI1I25Bof5arcc9/C2CqVbVhh/HYRywd4VbdPkfllP6VBgSxz5NJMQTyyR9emqidd3N imWD+/ff/1S+96urj6ObZ7Nh5Fnqzl7672w1jxVFmvxvdC//2BVKHPt8SlnI64Jjq+7M Q1kg== X-Gm-Message-State: AOAM531JD7PoN/cp40ewTJKSU84AWZKQTh3lBZehAqFZojptieKEiWKL jngGDf4Rkff0Y/NvuBZJA/PC2g== X-Google-Smtp-Source: ABdhPJxToScpYoj6CjujsC2FIq+rLfVkbRC4PxoSwF6OjFKakCnvUpmFBopUAbrpVpBPtCpp/ADWbg== X-Received: by 2002:a05:620a:23d:: with SMTP id u29mr20486891qkm.411.1614003830792; Mon, 22 Feb 2021 06:23:50 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id r80sm12522250qke.97.2021.02.22.06.23.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Feb 2021 06:23:50 -0800 (PST) Subject: Re: [PATCH 1/6] nptl: Split libpthread-routines into one routine per line To: libc-alpha@sourceware.org, Florian Weimer References: <26e80fbbc1331f7b7adaac2ccdf1434fcdb57fa3.1613582255.git.fweimer@redhat.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <182a34f3-1f4e-16b8-1216-9c2dc6d7d5d2@linaro.org> Date: Mon, 22 Feb 2021 11:23:48 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <26e80fbbc1331f7b7adaac2ccdf1434fcdb57fa3.1613582255.git.fweimer@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 14:23:53 -0000 On 17/02/2021 14:21, Florian Weimer via Libc-alpha wrote: > And sort the lines lexicographically. This will make it easier to review > patches which move symbols from libpthread to libc. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > nptl/Makefile | 238 ++++++++++++++++++++++++++++++++------------------ > 1 file changed, 152 insertions(+), 86 deletions(-) > > diff --git a/nptl/Makefile b/nptl/Makefile > index 8fb7fee6db..94c3873623 100644 > --- a/nptl/Makefile > +++ b/nptl/Makefile > @@ -85,92 +85,158 @@ pthread-compat-wrappers = \ > sigwait sigsuspend \ > recvmsg sendmsg > > -libpthread-routines = nptl-init nptlfreeres vars events version pt-interp \ > - pthread_create pthread_exit pthread_detach \ > - pthread_join pthread_tryjoin pthread_timedjoin \ > - pthread_clockjoin pthread_join_common pthread_yield \ > - pthread_getconcurrency pthread_setconcurrency \ > - pthread_setschedprio \ > - pthread_attr_getguardsize pthread_attr_setguardsize \ > - pthread_attr_getstackaddr pthread_attr_setstackaddr \ > - pthread_attr_getstacksize pthread_attr_setstacksize \ > - pthread_attr_getstack pthread_attr_setstack \ > - pthread_mutex_init pthread_mutex_destroy \ > - pthread_mutex_lock pthread_mutex_trylock \ > - pthread_mutex_timedlock pthread_mutex_unlock \ > - pthread_mutex_cond_lock \ > - pthread_mutexattr_init pthread_mutexattr_destroy \ > - pthread_mutexattr_getpshared \ > - pthread_mutexattr_setpshared \ > - pthread_mutexattr_gettype pthread_mutexattr_settype \ > - pthread_rwlock_init pthread_rwlock_destroy \ > - pthread_rwlock_rdlock pthread_rwlock_timedrdlock \ > - pthread_rwlock_clockrdlock \ > - pthread_rwlock_wrlock pthread_rwlock_timedwrlock \ > - pthread_rwlock_clockwrlock \ > - pthread_rwlock_tryrdlock pthread_rwlock_trywrlock \ > - pthread_rwlock_unlock \ > - pthread_rwlockattr_init pthread_rwlockattr_destroy \ > - pthread_rwlockattr_getpshared \ > - pthread_rwlockattr_setpshared \ > - pthread_rwlockattr_getkind_np \ > - pthread_rwlockattr_setkind_np \ > - pthread_cond_wait \ > - pthread_cond_signal pthread_cond_broadcast \ > - old_pthread_cond_wait old_pthread_cond_timedwait \ > - old_pthread_cond_signal old_pthread_cond_broadcast \ > - pthread_condattr_getpshared pthread_condattr_setpshared \ > - pthread_condattr_getclock pthread_condattr_setclock \ > - pthread_spin_init pthread_spin_destroy \ > - pthread_spin_lock pthread_spin_trylock \ > - pthread_spin_unlock \ > - pthread_barrier_init pthread_barrier_destroy \ > - pthread_barrier_wait \ > - pthread_barrierattr_init pthread_barrierattr_destroy \ > - pthread_barrierattr_getpshared \ > - pthread_barrierattr_setpshared \ > - pthread_key_create pthread_key_delete \ > - pthread_getspecific pthread_setspecific \ > - pthread_kill pthread_sigqueue \ > - pthread_cancel pthread_testcancel \ > - pthread_setcancelstate pthread_setcanceltype \ > - pthread_once \ > - old_pthread_atfork \ > - pthread_getcpuclockid \ > - sem_init sem_destroy sem_routines \ > - sem_open sem_close sem_unlink \ > - sem_getvalue \ > - sem_wait sem_timedwait sem_clockwait sem_post \ > - cleanup cleanup_defer cleanup_compat \ > - cleanup_defer_compat unwind \ > - pt-longjmp pt-cleanup\ > - cancellation \ > - lowlevellock \ > - pt-fork pt-fcntl \ > - $(pthread-compat-wrappers) \ > - pt-raise pt-system \ > - flockfile ftrylockfile funlockfile \ > - sigaction \ > - herrno res pt-allocrtsig \ > - pthread_kill_other_threads \ > - pthread_setaffinity \ > - pthread_attr_getaffinity \ > - pthread_mutexattr_getrobust pthread_mutexattr_setrobust \ > - pthread_mutex_consistent \ > - cleanup_routine unwind-forcedunwind \ > - pthread_mutexattr_getprotocol \ > - pthread_mutexattr_setprotocol \ > - pthread_mutexattr_getprioceiling \ > - pthread_mutexattr_setprioceiling tpp \ > - pthread_mutex_getprioceiling \ > - pthread_mutex_setprioceiling \ > - pthread_setname pthread_getname \ > - pthread_setattr_default_np pthread_getattr_default_np \ > - pthread_mutex_conf \ > - libpthread-compat > - > -libpthread-shared-only-routines = version pt-interp pt-allocrtsig \ > - unwind-forcedunwind > +libpthread-routines = \ > + $(pthread-compat-wrappers) \ > + cancellation \ > + cleanup \ > + cleanup_compat \ > + cleanup_defer \ > + cleanup_defer_compat \ > + cleanup_routine \ > + events \ > + flockfile \ > + ftrylockfile \ > + funlockfile \ > + herrno \ > + libpthread-compat \ > + lowlevellock \ > + nptl-init \ > + nptlfreeres \ > + old_pthread_atfork \ > + old_pthread_cond_broadcast \ > + old_pthread_cond_signal \ > + old_pthread_cond_timedwait \ > + old_pthread_cond_wait \ > + pt-allocrtsig \ > + pt-cleanup \ > + pt-fcntl \ > + pt-fork \ > + pt-interp \ > + pt-longjmp \ > + pt-raise \ > + pt-system \ > + pthread_attr_getaffinity \ > + pthread_attr_getguardsize \ > + pthread_attr_getstack \ > + pthread_attr_getstackaddr \ > + pthread_attr_getstacksize \ > + pthread_attr_setguardsize \ > + pthread_attr_setstack \ > + pthread_attr_setstackaddr \ > + pthread_attr_setstacksize \ > + pthread_barrier_destroy \ > + pthread_barrier_init \ > + pthread_barrier_wait \ > + pthread_barrierattr_destroy \ > + pthread_barrierattr_getpshared \ > + pthread_barrierattr_init \ > + pthread_barrierattr_setpshared \ > + pthread_cancel \ > + pthread_clockjoin \ > + pthread_cond_broadcast \ > + pthread_cond_signal \ > + pthread_cond_wait \ > + pthread_condattr_getclock \ > + pthread_condattr_getpshared \ > + pthread_condattr_setclock \ > + pthread_condattr_setpshared \ > + pthread_create \ > + pthread_detach \ > + pthread_exit \ > + pthread_getattr_default_np \ > + pthread_getconcurrency \ > + pthread_getcpuclockid \ > + pthread_getname \ > + pthread_getspecific \ > + pthread_join \ > + pthread_join_common \ > + pthread_key_create \ > + pthread_key_delete \ > + pthread_kill \ > + pthread_kill_other_threads \ > + pthread_mutex_cond_lock \ > + pthread_mutex_conf \ > + pthread_mutex_consistent \ > + pthread_mutex_destroy \ > + pthread_mutex_getprioceiling \ > + pthread_mutex_init \ > + pthread_mutex_lock \ > + pthread_mutex_setprioceiling \ > + pthread_mutex_timedlock \ > + pthread_mutex_trylock \ > + pthread_mutex_unlock \ > + pthread_mutexattr_destroy \ > + pthread_mutexattr_getprioceiling \ > + pthread_mutexattr_getprotocol \ > + pthread_mutexattr_getpshared \ > + pthread_mutexattr_getrobust \ > + pthread_mutexattr_gettype \ > + pthread_mutexattr_init \ > + pthread_mutexattr_setprioceiling \ > + pthread_mutexattr_setprotocol \ > + pthread_mutexattr_setpshared \ > + pthread_mutexattr_setrobust \ > + pthread_mutexattr_settype \ > + pthread_once \ > + pthread_rwlock_clockrdlock \ > + pthread_rwlock_clockwrlock \ > + pthread_rwlock_destroy \ > + pthread_rwlock_init \ > + pthread_rwlock_rdlock \ > + pthread_rwlock_timedrdlock \ > + pthread_rwlock_timedwrlock \ > + pthread_rwlock_tryrdlock \ > + pthread_rwlock_trywrlock \ > + pthread_rwlock_unlock \ > + pthread_rwlock_wrlock \ > + pthread_rwlockattr_destroy \ > + pthread_rwlockattr_getkind_np \ > + pthread_rwlockattr_getpshared \ > + pthread_rwlockattr_init \ > + pthread_rwlockattr_setkind_np \ > + pthread_rwlockattr_setpshared \ > + pthread_setaffinity \ > + pthread_setattr_default_np \ > + pthread_setcancelstate \ > + pthread_setcanceltype \ > + pthread_setconcurrency \ > + pthread_setname \ > + pthread_setschedprio \ > + pthread_setspecific \ > + pthread_sigqueue \ > + pthread_spin_destroy \ > + pthread_spin_init \ > + pthread_spin_lock \ > + pthread_spin_trylock \ > + pthread_spin_unlock \ > + pthread_testcancel \ > + pthread_timedjoin \ > + pthread_tryjoin \ > + pthread_yield \ > + res \ > + sem_clockwait \ > + sem_close \ > + sem_destroy \ > + sem_getvalue \ > + sem_init \ > + sem_open \ > + sem_post \ > + sem_routines \ > + sem_timedwait \ > + sem_unlink \ > + sem_wait \ > + sigaction \ > + tpp \ > + unwind \ > + unwind-forcedunwind \ > + vars \ > + version \ > + > +libpthread-shared-only-routines = \ > + pt-allocrtsig \ > + pt-interp \ > + unwind-forcedunwind \ > + version \ > > # Since cancellation handling is in large parts handled using exceptions > # we have to compile some files with exception handling enabled, some >