Re: [PATCH v6 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #23758]

[Rafal Luzynski <digitalfreak@lingonborough.com>]

16.01.2019 17:17 Zack Weinberg <zackw@panix.com> wrote:
> 
> This review covers only the documentation and commit message.

Thank you Zack and Paul for your reviews.  They were the most
missing part.  I believe we will help ourselves with the rest
of the patches.

> [...]
> (It seems to me that this extension ought to be generalized to all of
> the "macro" formats (%c, %D, %F, %r, %R, %T, %x, %X, %Ec, %Ex, %EX),
> and to all format flags and field widths, but that would be a separate
> patch and not appropriate for 2.29 at this point.)

This may be too ambiguous and therefore impossible to implement.

> [...]
> Paul's suggested revision of this addition is technically incorrect;
> he got confused about which way around the flag propagates.  I would
> recommend using a separate bullet point for this change, and I would
> also recommend not describing the behavior in terms of implementation
> details:
> 
> | * As a GNU extension, the '-' and '_' flags can now be applied to '%EY'
> |   to control how the year number is formatted; they have the same effect
> |   that they would on %Ey.

"they would" or "they would have"?

Also, shouldn't all format specifiers be consequently quoted, like "%EY"
and "%Ey"?  I don't mind single quotes, especially for the flags, I just
think that %Ey (without any quotes) may not be absolutely clear.

Regards,

Rafal