From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 007983851408 for ; Thu, 21 Jul 2022 02:44:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 007983851408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.187] (unknown [10.20.4.187]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxT9J9vdhi1MYrAA--.40645S3; Thu, 21 Jul 2022 10:44:14 +0800 (CST) Subject: Re: [PATCH v7 00/13] GLIBC LoongArch PATCHES To: Adhemerval Zanella Netto , libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com, i.swmail@xen0n.name References: <20220719012056.1461897-1-caiyinyu@loongson.cn> <087092dc-2e2f-bb3e-74b9-a3462cff5763@linaro.org> From: caiyinyu Message-ID: <1854f1a0-cbc5-c5f3-7194-c66b0b54b455@loongson.cn> Date: Thu, 21 Jul 2022 10:44:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <087092dc-2e2f-bb3e-74b9-a3462cff5763@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf9DxT9J9vdhi1MYrAA--.40645S3 X-Coremail-Antispam: 1UD129KBjvJXoWxZryUGw4kuF47GrykJrWkWFg_yoW5Kry8pa yfuanxKFWYyr42ywn2kw1Dur1kZw4xK345XF45Xr10krWUZryFgryIyr4v9FyDC345tF9F q34UAa4xXF1qv3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv2b7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4 vEx4A2jsIEc7CjxVAFwI0_Cr1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVAC Y4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJV W8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG 8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r12 6r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE 14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa 7IU5PpnJUUUUU== X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 02:44:25 -0000 This version looks good to me, everything I have pointed out in previous release was addressed, build-many-glibcs.py and make check does not trigger any issue, and some qemu tests show that the generated loader and binaries are corrected generated. If you want, I can push it upstream.  Carlos is ok to install it? ------------------------------------- Very glad to know that you agreed to install Loongarch ports and I have submitted application for write access to the Loongarch parts of glibc. Waiting for Carlos' advice. Thank everyone for their efforts. 在 2022/7/21 上午1:19, Adhemerval Zanella Netto 写道: > > On 18/07/22 22:20, caiyinyu wrote: >> Hello, these are LoongArch patches v7, and we really need your futher suggestions: >> >> There are 6 parts in total. >> >> 1. HISTORY: >> LoongArch patches v1: https://sourceware.org/pipermail/libc-alpha/2021-August/130262.html >> LoongArch patches v2: https://sourceware.org/pipermail/libc-alpha/2021-December/134811.html >> LoongArch patches v3: https://sourceware.org/pipermail/libc-alpha/2022-April/137888.html >> LoongArch patches v4: https://sourceware.org/pipermail/libc-alpha/2022-May/subject.html >> LoongArch patches v5: https://sourceware.org/pipermail/libc-alpha/2022-June/139262.html >> LoongArch patches v6: https://sourceware.org/pipermail/libc-alpha/2022-July/140446.html >> >> 2. LoongArch-Doc: https://github.com/loongson/LoongArch-Documentation >> >> We add new section: procedure calling convention. >> https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html#_procedure_calling_convention >> >> >> 3. Linux kernel, GCC and Binutils Loongarch parts have been into GNU Open Source community. >> >> >> 4. From Adhemerval Zanella Netto: >>> I finished my review for the port and it looks ok in general, however there >>> some pieces that would require a v7: >>> >>> 1. Add R_LARCH_NONE handling on bootstrap, binutils 2.38 does generated it >>> and from previous discussion it should be considered a missed >>> optimizations instead of a linker error. >> R_LARCH_NONE handling has been added on bootstrap. >>> 2. Remove the __loongarch_soft_float parts, since there is no support for >>> soft floating-point. >> All __loongarch_soft_float removed. >>> 3. Remove sysdeps/unix/sysv/linux/loongarch/ldconfig.h, this file is not >>> required. >> This file has been removed. >>> 4. Some minor style issues. >> See previous emails. >> https://sourceware.org/pipermail/libc-alpha/2022-July/thread.html >>> 5. Either remove HAVE_GETTIMEOFDAY_VSYSCALL or add a gettimeofday ifunc >>> optimization. >> Removed now. >>> The only part really prevent port inclusion is 1. I am also assuming ifunc >>> is support (at least you have added support on the Linux ABI part) with >>> binutils 2.38. If not, you will need to remove support until you fix it on >>> binutils. >>> >>> And also, you need to check and report the test results using the expected >>> defined release branches, using out-of-tree branches are not acceptable for >>> inclusion. >> 5. There are some new changes: > This version looks good to me, everything I have pointed out in previous release > was addressed, build-many-glibcs.py and make check does not trigger any issue, > and some qemu tests show that the generated loader and binaries are corrected > generated. > > If you want, I can push it upstream. Carlos is ok to install it?