public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>,
	GNU C Library <libc-alpha@sourceware.org>
Subject: Re: What to do about libidn?
Date: Fri, 11 Nov 2016 20:00:00 -0000	[thread overview]
Message-ID: <18643b68-d90e-9621-bafc-dcd95c9b58b7@redhat.com> (raw)
In-Reply-To: <44cead16-9db0-a4c0-82cd-1f6178260ed7@redhat.com>

On 11/08/2016 06:52 AM, Florian Weimer wrote:
> 7. On the glibc side, IDN only applies to getaddrinfo, is opt-in via
> AI_IDN, and requires a non-ASCII locale.  Everything else sends
> unencoded bytes over the wire via DNS.
> 
> What should we do to improve this situation?  I would really like to
> remove AI_IDN, but this is likely not an option.
> 
> Should we remove our internal copy and try to dlopen libidn2?  Maybe
> falling back to libidn if libdn2 is unavailable?  Bundle libidn2?
> Write our own implementation?

I think that AI_IDN was layered at the wrong level.

Applications need much more rich APIs to handle IDN than we give them.

I'm in favour of removing AI_IDN support for _new_ binaries, which means
versioning and stripping out AI_IDN support in new version of getaddrinfo.

For existing binaries I think we must continue to provide the support
we have but freeze out the code so we can eventually remove it.

If there are security issues in using the existing code as-is then I think
a dlopen of libidn (the system library with fixes) is acceptable.

Transitioning to libidn2 doesn't seem like a feasible solution.

I think this lines up with Joseph's recommendations.

-- 
Cheers,
Carlos.

      parent reply	other threads:[~2016-11-11 20:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 11:52 Florian Weimer
2016-11-08 15:27 ` Zack Weinberg
2016-11-08 15:59   ` Florian Weimer
2016-11-09  7:53     ` Petr Spacek
2016-11-08 23:30 ` Joseph Myers
2016-11-09 12:02   ` Florian Weimer
2016-11-09 16:03     ` Joseph Myers
2016-11-11 19:53     ` Carlos O'Donell
2016-11-10 15:32   ` Florian Weimer
2016-11-11 19:49   ` Carlos O'Donell
2016-11-11 21:16     ` Joseph Myers
2016-11-11 19:41 ` Mike Frysinger
2016-11-11 20:00 ` Carlos O'Donell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18643b68-d90e-9621-bafc-dcd95c9b58b7@redhat.com \
    --to=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).