From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 00/10] Unwinder interface consolidation
Date: Mon, 1 Mar 2021 08:54:12 -0500 [thread overview]
Message-ID: <18781e1d-bc4a-d835-359b-f2aa57425083@redhat.com> (raw)
In-Reply-To: <cover.1613577607.git.fweimer@redhat.com>
On 2/17/21 11:02 AM, Florian Weimer via Libc-alpha wrote:
> This series is basically a repost. I had to tweak it somewhat to pick
> up the <unwind-arch.h> customization for MIPS. I switched to reusing
> that header for all customization.
>
> This is a prequiste for consolidating and libc and nptl implementations
> of unwinding, and moving the cancellation implementation into libc.
This is a great idea. It has been a long standing problem that we have
two distinct copies of unwinding for backtrace and cancellation and
that they are not harmonized to avoid duplication or mistakes.
Thank you for tackling this cleanup.
The series as a whole looks good to me.
Reviewed-by: Carlos <carlos@redhat.com>
> Thanks,
> Florian
>
> Florian Weimer (10):
> Implement <unwind-link.h> for dynamically loading the libgcc_s
> unwinder
> backtrace: Implement on top of <unwind-link.h>
> arm: Implement backtrace on top of <unwind-link.h>
> i386: Implement backtrace on top of <unwind-link.h>
> m68k: Implement backtrace on top of <unwind-link.h>
> sparc: Implement backtrace on top <unwind-link.h>
> __frame_state_for: Use <unwind-link.h> for unwinder access
> Move sysdeps/gnu/unwind-resume.c to sysdeps/generic/unwind-resume.c
> Implement _Unwind_Resume in libc on top of <unwind-link.h>
> nptl: Use <unwind-link.h> for accessing the libgcc_s unwinder
>
> debug/backtrace.c | 86 +++--------
> malloc/set-freeres.c | 5 +
> misc/Makefile | 2 +-
> misc/Versions | 1 +
> misc/unwind-link.c | 145 ++++++++++++++++++
> nptl/nptlfreeres.c | 1 -
> nptl/pthreadP.h | 6 +-
> nptl/pthread_cancel.c | 3 +-
> sysdeps/alpha/unwind-arch.h | 28 ++++
> sysdeps/arm/arm-unwind-resume.S | 26 ++--
> sysdeps/arm/backtrace.c | 77 +++-------
> sysdeps/arm/nptl/unwind-forcedunwind.c | 25 +++
> sysdeps/arm/pt-arm-unwind-resume.S | 22 ++-
> sysdeps/arm/unwind-arch.h | 39 +++++
> sysdeps/arm/unwind-resume.c | 25 +++
> sysdeps/generic/framestate.c | 21 +--
> sysdeps/generic/unwind-arch.h | 27 ++--
> sysdeps/generic/unwind-link.h | 106 +++++++++++++
> sysdeps/generic/unwind-resume.c | 46 ++++++
> sysdeps/gnu/unwind-resume.c | 83 ----------
> sysdeps/i386/backtrace.c | 82 +++-------
> sysdeps/i386/unwind-arch.h | 39 +++++
> sysdeps/ia64/unwind-arch.h | 32 ++++
> sysdeps/m68k/backtrace.c | 82 +++-------
> sysdeps/m68k/m680x0/unwind-arch.h | 26 ++++
> sysdeps/m68k/unwind-arch.h | 35 +++++
> sysdeps/mach/hurd/fork.c | 3 +
> .../{unix/sysv/linux => }/mips/unwind-arch.h | 17 +-
> sysdeps/nptl/fork.c | 3 +
> sysdeps/nptl/unwind-forcedunwind.c | 115 ++------------
> sysdeps/powerpc/powerpc32/unwind-arch.h | 28 ++++
> sysdeps/s390/unwind-arch.h | 28 ++++
> sysdeps/sh/unwind-arch.h | 28 ++++
> sysdeps/sparc/backtrace.c | 66 ++------
> sysdeps/sparc/unwind-arch.h | 28 ++++
> .../sysv/linux/ia64/unwind-forcedunwind.c | 16 +-
> 36 files changed, 852 insertions(+), 550 deletions(-)
> create mode 100644 misc/unwind-link.c
> create mode 100644 sysdeps/alpha/unwind-arch.h
> create mode 100644 sysdeps/arm/nptl/unwind-forcedunwind.c
> create mode 100644 sysdeps/arm/unwind-arch.h
> create mode 100644 sysdeps/arm/unwind-resume.c
> create mode 100644 sysdeps/generic/unwind-link.h
> create mode 100644 sysdeps/generic/unwind-resume.c
> delete mode 100644 sysdeps/gnu/unwind-resume.c
> create mode 100644 sysdeps/i386/unwind-arch.h
> create mode 100644 sysdeps/ia64/unwind-arch.h
> create mode 100644 sysdeps/m68k/m680x0/unwind-arch.h
> create mode 100644 sysdeps/m68k/unwind-arch.h
> rename sysdeps/{unix/sysv/linux => }/mips/unwind-arch.h (85%)
> create mode 100644 sysdeps/powerpc/powerpc32/unwind-arch.h
> create mode 100644 sysdeps/s390/unwind-arch.h
> create mode 100644 sysdeps/sh/unwind-arch.h
> create mode 100644 sysdeps/sparc/unwind-arch.h
>
--
Cheers,
Carlos.
prev parent reply other threads:[~2021-03-01 13:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 16:02 Florian Weimer
2021-02-17 16:02 ` [PATCH 01/10] Implement <unwind-link.h> for dynamically loading the libgcc_s unwinder Florian Weimer
2021-03-01 13:54 ` Carlos O'Donell
2021-02-17 16:02 ` [PATCH 02/10] backtrace: Implement on top of <unwind-link.h> Florian Weimer
2021-03-01 13:54 ` Carlos O'Donell
2021-02-17 16:02 ` [PATCH 03/10] arm: Implement backtrace " Florian Weimer
2021-03-01 13:54 ` Carlos O'Donell
2021-02-17 16:03 ` [PATCH 04/10] i386: " Florian Weimer
2021-03-01 13:54 ` Carlos O'Donell
2021-02-17 16:03 ` [PATCH 05/10] m68k: " Florian Weimer
2021-03-01 13:54 ` Carlos O'Donell
2021-02-17 16:03 ` [PATCH 06/10] sparc: Implement backtrace on top <unwind-link.h> Florian Weimer
2021-03-01 13:54 ` Carlos O'Donell
2021-02-17 16:03 ` [PATCH 07/10] __frame_state_for: Use <unwind-link.h> for unwinder access Florian Weimer
2021-03-01 13:54 ` Carlos O'Donell
2021-02-17 16:03 ` [PATCH 08/10] Move sysdeps/gnu/unwind-resume.c to sysdeps/generic/unwind-resume.c Florian Weimer
2021-03-01 13:55 ` Carlos O'Donell
2021-02-17 16:03 ` [PATCH 09/10] Implement _Unwind_Resume in libc on top of <unwind-link.h> Florian Weimer
2021-03-01 13:55 ` Carlos O'Donell
2021-02-17 16:03 ` [PATCH 10/10] nptl: Use <unwind-link.h> for accessing the libgcc_s unwinder Florian Weimer
2021-03-01 13:55 ` Carlos O'Donell
2021-03-01 13:54 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18781e1d-bc4a-d835-359b-f2aa57425083@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).